<div dir="ltr">Yeah, bus... ;)<br><br>-eric</div><br><div class="gmail_quote"><div dir="ltr">On Fri, Jun 5, 2015 at 10:28 AM Jim Grosbach <<a href="mailto:grosbach@apple.com">grosbach@apple.com</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Thanks. Your attempt to get me to remove it encountered the fact that I hadn’t gotten that far in my email yet this morning. :)<br>
<br>
> On Jun 5, 2015, at 10:27 AM, Duncan P. N. Exon Smith <<a href="mailto:dexonsmith@apple.com" target="_blank">dexonsmith@apple.com</a>> wrote:<br>
><br>
> I guess my lazy attempt to get someone else to remove it failed;<br>
> fixed in r239165 :).<br>
><br>
>> On 2015-Jun-05, at 10:23, Eric Christopher <<a href="mailto:echristo@gmail.com" target="_blank">echristo@gmail.com</a>> wrote:<br>
>><br>
>> It was a stray, happens on occasion. :)<br>
>><br>
>><br>
>> On Fri, Jun 5, 2015, 10:16 AM Duncan P. N. Exon Smith <<a href="mailto:dexonsmith@apple.com" target="_blank">dexonsmith@apple.com</a>> wrote:<br>
>><br>
>>> On 2015-Jun-04, at 16:25, Jim Grosbach <<a href="mailto:grosbach@apple.com" target="_blank">grosbach@apple.com</a>> wrote:<br>
>>><br>
>>> Author: grosbach<br>
>>> Date: Thu Jun  4 18:25:05 2015<br>
>>> New Revision: 239117<br>
>>><br>
>>> URL: <a href="https://urldefense.proofpoint.com/v2/url?u=http-3A__llvm.org_viewvc_llvm-2Dproject-3Frev-3D239117-26view-3Drev&d=AwMFaQ&c=8hUWFZcy2Z-Za5rBPlktOQ&r=mQ4LZ2PUj9hpadE3cDHZnIdEwhEBrbAstXeMaFoB9tg&m=-eJQnBZK_O6g9daswk4X0VPrWVcF9kCh3roRH5SQDyk&s=Fd-g-VWXby-WICW-erzeQTytneFFNYdeEzbjBN2y6lM&e=" target="_blank">http://llvm.org/viewvc/llvm-project?rev=239117&view=rev</a><br>
>>> Log:<br>
>>> MC: Tidy up formatting and doc comments. NFC.<br>
>>><br>
>>> Modified:<br>
>>>   llvm/trunk/include/llvm/MC/MCMachObjectWriter.h<br>
>>><br>
>>> Modified: llvm/trunk/include/llvm/MC/MCMachObjectWriter.h<br>
>>> URL: <a href="https://urldefense.proofpoint.com/v2/url?u=http-3A__llvm.org_viewvc_llvm-2Dproject_llvm_trunk_include_llvm_MC_MCMachObjectWriter.h-3Frev-3D239117-26r1-3D239116-26r2-3D239117-26view-3Ddiff&d=AwMFaQ&c=8hUWFZcy2Z-Za5rBPlktOQ&r=mQ4LZ2PUj9hpadE3cDHZnIdEwhEBrbAstXeMaFoB9tg&m=-eJQnBZK_O6g9daswk4X0VPrWVcF9kCh3roRH5SQDyk&s=Tw33jg_V0TzNE7SQ1PvWGp__nfwmaZk9NkRboTTOVFQ&e=" target="_blank">http://llvm.org/viewvc/llvm-project/llvm/trunk/include/llvm/MC/MCMachObjectWriter.h?rev=239117&r1=239116&r2=239117&view=diff</a><br>
>>> ==============================================================================<br>
>>> --- llvm/trunk/include/llvm/MC/MCMachObjectWriter.h (original)<br>
>>> +++ llvm/trunk/include/llvm/MC/MCMachObjectWriter.h Thu Jun  4 18:25:05 2015<br>
>>> @@ -43,7 +43,7 @@ public:<br>
>>>  /// \name Lifetime Management<br>
>>>  /// @{<br>
>>><br>
>>> -  virtual void reset() {};<br>
>>> +  virtual void reset(){};<br>
>><br>
>> Any idea what this semi-colon is for?<br>
>><br>
>> (Without it, I think clang format prefers a space before the {}...)<br>
>> _______________________________________________<br>
>> llvm-commits mailing list<br>
>> <a href="mailto:llvm-commits@cs.uiuc.edu" target="_blank">llvm-commits@cs.uiuc.edu</a><br>
>> <a href="http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits" target="_blank">http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits</a><br>
><br>
<br>
</blockquote></div>