<p dir="ltr">Yeah, ignore that "class" for a while. It's still in design phase. But those methods should have users... I'll have a look what happened. </p>
<p dir="ltr">Cheers, <br>
Renato </p>
<div class="gmail_quote">On 5 Jun 2015 10:52 pm, "Benjamin Kramer" <<a href="mailto:benny.kra@gmail.com">benny.kra@gmail.com</a>> wrote:<br type="attribution"><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">On Fri, Jun 5, 2015 at 5:20 PM, David Blaikie <<a href="mailto:dblaikie@gmail.com">dblaikie@gmail.com</a>> wrote:<br>
><br>
><br>
> On Fri, Jun 5, 2015 at 7:33 AM, Benjamin Kramer <<a href="mailto:benny.kra@googlemail.com">benny.kra@googlemail.com</a>><br>
> wrote:<br>
>><br>
>> Author: d0k<br>
>> Date: Fri Jun  5 09:33:02 2015<br>
>> New Revision: 239158<br>
>><br>
>> URL: <a href="https://urldefense.proofpoint.com/v2/url?u=http-3A__llvm.org_viewvc_llvm-2Dproject-3Frev-3D239158-26view-3Drev&d=AwMFaQ&c=8hUWFZcy2Z-Za5rBPlktOQ&r=mQ4LZ2PUj9hpadE3cDHZnIdEwhEBrbAstXeMaFoB9tg&m=djKSALkSJpdKRgPB9ZZxAqqnAuKOOOdhha2fGP_B5sc&s=oosUw_aEjaJpH6WHA2-_CrdNbn6EmENP4aZANVsxEz8&e=" target="_blank">http://llvm.org/viewvc/llvm-project?rev=239158&view=rev</a><br>
>> Log:<br>
>> [TargetParser] Properly attach functions of ARMTargetParser to the class<br>
><br>
><br>
> How did these functions work previously? If they can be non-members, should<br>
> they just remain that way? (I assume not, because I saw you made a change<br>
> like that in another commit & I expect there's a reason it wasn't applicable<br>
> here - just can't see it from the diff alone)<br>
<br>
They didn't, but there are no callers. The other option was just<br>
DCE'ing them but it seems that this code is still new and in flux so<br>
that might've been rude ;)<br>
<br>
- Ben<br>
<br>
><br>
>><br>
>><br>
>> Modified:<br>
>>  Â  Â llvm/trunk/lib/Support/TargetParser.cpp<br>
>><br>
>> Modified: llvm/trunk/lib/Support/TargetParser.cpp<br>
>> URL:<br>
>> <a href="https://urldefense.proofpoint.com/v2/url?u=http-3A__llvm.org_viewvc_llvm-2Dproject_llvm_trunk_lib_Support_TargetParser.cpp-3Frev-3D239158-26r1-3D239157-26r2-3D239158-26view-3Ddiff&d=AwMFaQ&c=8hUWFZcy2Z-Za5rBPlktOQ&r=mQ4LZ2PUj9hpadE3cDHZnIdEwhEBrbAstXeMaFoB9tg&m=djKSALkSJpdKRgPB9ZZxAqqnAuKOOOdhha2fGP_B5sc&s=ilkU9k6wxblQ7kiQWhZmtPCipddnIRWHTQaKjDd2acQ&e=" target="_blank">http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Support/TargetParser.cpp?rev=239158&r1=239157&r2=239158&view=diff</a><br>
>><br>
>> ==============================================================================<br>
>> --- llvm/trunk/lib/Support/TargetParser.cpp (original)<br>
>> +++ llvm/trunk/lib/Support/TargetParser.cpp Fri Jun  5 09:33:02 2015<br>
>> @@ -223,8 +223,6 @@ struct {<br>
>><br>
>>  } // namespace<br>
>><br>
>> -namespace llvm {<br>
>> -<br>
>>  // ======================================================= //<br>
>>  // Information by ID<br>
>>  // ======================================================= //<br>
>> @@ -241,13 +239,13 @@ unsigned ARMTargetParser::getFPUVersion(<br>
>>  Â  return FPUNames[FPUKind].FPUVersion;<br>
>>  }<br>
>><br>
>> -unsigned getFPUNeonSupportLevel(unsigned FPUKind) {<br>
>> +unsigned ARMTargetParser::getFPUNeonSupportLevel(unsigned FPUKind) {<br>
>>  Â  if (FPUKind >= ARM::FK_LAST)<br>
>>  Â  Â  return 0;<br>
>>  Â  return FPUNames[FPUKind].NeonSupport;<br>
>>  }<br>
>><br>
>> -unsigned getFPURestriction(unsigned FPUKind) {<br>
>> +unsigned ARMTargetParser::getFPURestriction(unsigned FPUKind) {<br>
>>  Â  if (FPUKind >= ARM::FK_LAST)<br>
>>  Â  Â  return 0;<br>
>>  Â  return FPUNames[FPUKind].Restriction;<br>
>> @@ -587,5 +585,3 @@ unsigned ARMTargetParser::parseArchVersi<br>
>>  Â  }<br>
>>  Â  return 0;<br>
>>  }<br>
>> -<br>
>> -} // namespace llvm<br>
>><br>
>><br>
>> _______________________________________________<br>
>> llvm-commits mailing list<br>
>> <a href="mailto:llvm-commits@cs.uiuc.edu">llvm-commits@cs.uiuc.edu</a><br>
>> <a href="http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits" target="_blank">http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits</a><br>
><br>
><br>
_______________________________________________<br>
llvm-commits mailing list<br>
<a href="mailto:llvm-commits@cs.uiuc.edu">llvm-commits@cs.uiuc.edu</a><br>
<a href="http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits" target="_blank">http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits</a><br>
</blockquote></div>