<div dir="ltr">Cool. It's best to state that in the reversion email rather than after the fact. :)<br><br>-eric</div><br><div class="gmail_quote"><div dir="ltr">On Thu, Jun 4, 2015 at 5:22 PM Alexey Samsonov <<a href="mailto:vonosmas@gmail.com">vonosmas@gmail.com</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr">It failed on the hexagon bot: <a href="https://urldefense.proofpoint.com/v2/url?u=http-3A__lab.llvm.org-3A8011_builders_clang-2Dhexagon-2Delf_builds_27412_steps_check-2Dall_logs_FAIL-253A-2520LLVM-253A-253Adwarfdump-2Dinvalid.test&d=AwMFaQ&c=8hUWFZcy2Z-Za5rBPlktOQ&r=mQ4LZ2PUj9hpadE3cDHZnIdEwhEBrbAstXeMaFoB9tg&m=u6OcGE8uaRxezFFpx5dYQdGHTJ3RFSCv_lkyo9N28rk&s=KL21yB8J6KD4ELN0_7uadVfaWXp924D3bJJznmWO7bI&e=" target="_blank">http://lab.llvm.org:8011/builders/clang-hexagon-elf/builds/27412/steps/check-all/logs/FAIL%3A%20LLVM%3A%3Adwarfdump-invalid.test</a><div>I've asked Rick if he could provide a full backtrace.</div></div><div class="gmail_extra"></div><div class="gmail_extra"><br><div class="gmail_quote">On Thu, Jun 4, 2015 at 5:14 PM, Eric Christopher <span dir="ltr"><<a href="mailto:echristo@gmail.com" target="_blank">echristo@gmail.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr">Any reason, or just a hatred toward the number 239124?<span><font color="#888888"><br><br><div>-eric</div></font></span></div><div><div><br><div class="gmail_quote"><div dir="ltr">On Thu, Jun 4, 2015 at 5:14 PM Alexey Samsonov <<a href="mailto:vonosmas@gmail.com" target="_blank">vonosmas@gmail.com</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Author: samsonov<br>
Date: Thu Jun  4 18:58:31 2015<br>
New Revision: 239125<br>
<br>
URL: <a href="https://urldefense.proofpoint.com/v2/url?u=http-3A__llvm.org_viewvc_llvm-2Dproject-3Frev-3D239125-26view-3Drev&d=AwMFaQ&c=8hUWFZcy2Z-Za5rBPlktOQ&r=mQ4LZ2PUj9hpadE3cDHZnIdEwhEBrbAstXeMaFoB9tg&m=u6OcGE8uaRxezFFpx5dYQdGHTJ3RFSCv_lkyo9N28rk&s=62nNsDcdKs6EfiJExlj3Fcd03men5ThAMZWlFtwbTpg&e=" target="_blank">http://llvm.org/viewvc/llvm-project?rev=239125&view=rev</a><br>
Log:<br>
Revert "[Object, ELF] Fix segmentation fault in ELFFile::getSectionName()."<br>
<br>
This reverts commit r239124.<br>
<br>
Removed:<br>
    llvm/trunk/test/DebugInfo/Inputs/invalid.elf.no-shstrtab<br>
Modified:<br>
    llvm/trunk/include/llvm/Object/ELF.h<br>
    llvm/trunk/test/DebugInfo/dwarfdump-invalid.test<br>
<br>
Modified: llvm/trunk/include/llvm/Object/ELF.h<br>
URL: <a href="https://urldefense.proofpoint.com/v2/url?u=http-3A__llvm.org_viewvc_llvm-2Dproject_llvm_trunk_include_llvm_Object_ELF.h-3Frev-3D239125-26r1-3D239124-26r2-3D239125-26view-3Ddiff&d=AwMFaQ&c=8hUWFZcy2Z-Za5rBPlktOQ&r=mQ4LZ2PUj9hpadE3cDHZnIdEwhEBrbAstXeMaFoB9tg&m=u6OcGE8uaRxezFFpx5dYQdGHTJ3RFSCv_lkyo9N28rk&s=ku1-zBJYmS_J1U_NVUeTsjRmEwV25OiYoBcSMYgOxrg&e=" target="_blank">http://llvm.org/viewvc/llvm-project/llvm/trunk/include/llvm/Object/ELF.h?rev=239125&r1=239124&r2=239125&view=diff</a><br>
==============================================================================<br>
--- llvm/trunk/include/llvm/Object/ELF.h (original)<br>
+++ llvm/trunk/include/llvm/Object/ELF.h Thu Jun  4 18:58:31 2015<br>
@@ -928,7 +928,7 @@ ErrorOr<StringRef> ELFFile<ELFT>::getSym<br>
 template <class ELFT><br>
 ErrorOr<StringRef><br>
 ELFFile<ELFT>::getSectionName(const Elf_Shdr *Section) const {<br>
-  if (!dot_shstrtab_sec || Section->sh_name >= dot_shstrtab_sec->sh_size)<br>
+  if (Section->sh_name >= dot_shstrtab_sec->sh_size)<br>
     return object_error::parse_failed;<br>
   return StringRef(getString(dot_shstrtab_sec, Section->sh_name));<br>
 }<br>
<br>
Removed: llvm/trunk/test/DebugInfo/Inputs/invalid.elf.no-shstrtab<br>
URL: <a href="https://urldefense.proofpoint.com/v2/url?u=http-3A__llvm.org_viewvc_llvm-2Dproject_llvm_trunk_test_DebugInfo_Inputs_invalid.elf.no-2Dshstrtab-3Frev-3D239124-26view-3Dauto&d=AwMFaQ&c=8hUWFZcy2Z-Za5rBPlktOQ&r=mQ4LZ2PUj9hpadE3cDHZnIdEwhEBrbAstXeMaFoB9tg&m=u6OcGE8uaRxezFFpx5dYQdGHTJ3RFSCv_lkyo9N28rk&s=FSGMPd7VGD0rRjTeiqlK9C1D62izvsPKbc9ND7oUA_4&e=" target="_blank">http://llvm.org/viewvc/llvm-project/llvm/trunk/test/DebugInfo/Inputs/invalid.elf.no-shstrtab?rev=239124&view=auto</a><br>
==============================================================================<br>
Binary files llvm/trunk/test/DebugInfo/Inputs/invalid.elf.no-shstrtab (original) and llvm/trunk/test/DebugInfo/Inputs/invalid.elf.no-shstrtab (removed) differ<br>
<br>
Modified: llvm/trunk/test/DebugInfo/dwarfdump-invalid.test<br>
URL: <a href="https://urldefense.proofpoint.com/v2/url?u=http-3A__llvm.org_viewvc_llvm-2Dproject_llvm_trunk_test_DebugInfo_dwarfdump-2Dinvalid.test-3Frev-3D239125-26r1-3D239124-26r2-3D239125-26view-3Ddiff&d=AwMFaQ&c=8hUWFZcy2Z-Za5rBPlktOQ&r=mQ4LZ2PUj9hpadE3cDHZnIdEwhEBrbAstXeMaFoB9tg&m=u6OcGE8uaRxezFFpx5dYQdGHTJ3RFSCv_lkyo9N28rk&s=QD_0Wdh8T4StGX7cReMMWUn5UlLHTY_nzXvD8huy_Ow&e=" target="_blank">http://llvm.org/viewvc/llvm-project/llvm/trunk/test/DebugInfo/dwarfdump-invalid.test?rev=239125&r1=239124&r2=239125&view=diff</a><br>
==============================================================================<br>
--- llvm/trunk/test/DebugInfo/dwarfdump-invalid.test (original)<br>
+++ llvm/trunk/test/DebugInfo/dwarfdump-invalid.test Thu Jun  4 18:58:31 2015<br>
@@ -4,6 +4,3 @@ RUN: llvm-dwarfdump %p/Inputs/invalid.el<br>
 RUN: llvm-dwarfdump %p/Inputs/invalid.elf.2 2>&1 | FileCheck %s --check-prefix=INVALID-ELF<br>
 RUN: llvm-dwarfdump %p/Inputs/invalid.elf.3 2>&1 | FileCheck %s --check-prefix=INVALID-ELF<br>
 INVALID-ELF: Invalid data was encountered while parsing the file<br>
-<br>
-RUN: llvm-dwarfdump %p/Inputs/invalid.elf.no-shstrtab 2>&1 | FileCheck %s --check-prefix=EMPTY<br>
-EMPTY: .debug_info contents:<br>
<br>
<br>
_______________________________________________<br>
llvm-commits mailing list<br>
<a href="mailto:llvm-commits@cs.uiuc.edu" target="_blank">llvm-commits@cs.uiuc.edu</a><br>
<a href="http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits" target="_blank">http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits</a><br>
</blockquote></div>
</div></div></blockquote></div><br><br clear="all"><div><br></div></div><div class="gmail_extra">-- <br><div><div dir="ltr">Alexey Samsonov<br><a href="mailto:vonosmas@gmail.com" target="_blank">vonosmas@gmail.com</a></div></div>
</div></blockquote></div>