<html><head><meta http-equiv="Content-Type" content="text/html charset=utf-8"></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space;" class=""><div class="">I added some simple regex filters to the run and machines page. They would work for this purpose too.</div><div class=""><br class=""></div><div class="">Server side filtering has the advantage of limiting the query size, which is super useful for me. Our 7 day reports runs on enough machines that it is slow (~100k samples returned by the query). Being able to limit it would be handy.</div><div class=""><br class=""></div><br class=""><div><blockquote type="cite" class=""><div class="">On Jun 4, 2015, at 7:04 AM, Kristof Beyls <<a href="mailto:kristof.beyls@arm.com" class="">kristof.beyls@arm.com</a>> wrote:</div><br class="Apple-interchange-newline"><div class=""><meta http-equiv="Content-Type" content="text/html; charset=utf-8" class=""><meta name="Generator" content="Microsoft Word 14 (filtered medium)" class=""><style class=""><!--
/* Font Definitions */
@font-face
{font-family:Calibri;
panose-1:2 15 5 2 2 2 4 3 2 4;}
@font-face
{font-family:Tahoma;
panose-1:2 11 6 4 3 5 4 4 2 4;}
/* Style Definitions */
p.MsoNormal, li.MsoNormal, div.MsoNormal
{margin:0cm;
margin-bottom:.0001pt;
font-size:12.0pt;
font-family:"Times New Roman","serif";}
a:link, span.MsoHyperlink
{mso-style-priority:99;
color:blue;
text-decoration:underline;}
a:visited, span.MsoHyperlinkFollowed
{mso-style-priority:99;
color:purple;
text-decoration:underline;}
span.EmailStyle17
{mso-style-type:personal-reply;
font-family:"Calibri","sans-serif";
color:#1F497D;}
.MsoChpDefault
{mso-style-type:export-only;
font-family:"Calibri","sans-serif";
mso-fareast-language:EN-US;}
@page WordSection1
{size:612.0pt 792.0pt;
margin:72.0pt 72.0pt 72.0pt 72.0pt;}
div.WordSection1
{page:WordSection1;}
--></style><!--[if gte mso 9]><xml>
<o:shapedefaults v:ext="edit" spidmax="1026" />
</xml><![endif]--><!--[if gte mso 9]><xml>
<o:shapelayout v:ext="edit">
<o:idmap v:ext="edit" data="1" />
</o:shapelayout></xml><![endif]--><div lang="EN-GB" link="blue" vlink="purple" class=""><div class="WordSection1"><div class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1F497D" class="">Yeah – that’s another possibility.<o:p class=""></o:p></span></div><div class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1F497D" class="">I do like keeping the functionality that with the URL you can specify which machines to see by default, e.g.<br class="">allowing to bookmark your favourite machines.<br class="">I’m assuming it’s easy to access URL query parameters from javascript. If so, the query parameter could<br class="">control which checkboxes are enabled by default.<o:p class=""></o:p></span></div><div class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1F497D" class=""><o:p class=""> </o:p></span></div><div class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1F497D" class="">I think the biggest disadvantage of doing it with javascript is that the interface becomes inconsistent<br class="">with the “lnt send-daily-report” command, as that command obviously cannot run javascript regexes.<o:p class=""></o:p></span></div><div class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1F497D" class="">I haven’t checked in detail, but there probably are differences between javascript regexes and python regexes.<o:p class=""></o:p></span></div><div class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1F497D" class=""><o:p class=""> </o:p></span></div><div class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1F497D" class="">Another potential advantage of doing the filtering server-side is that the size of the daily report<br class="">page could be reduced. However, I haven’t seen examples of huge daily report pages so far, so<br class="">I think this is currently just a theoretical advantage.<o:p class=""></o:p></span></div><div class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1F497D" class=""><o:p class=""> </o:p></span></div><div class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1F497D" class="">Overall, I like your suggestion of checkboxes and enabling interactive filtering – but it would be nice<br class="">to find some kind of solution to keep the interface between the daily report webui and the daily report<br class="">emailing command consistent. Maybe the differences between javascript regexes and python regexes<br class="">won’t be much of a problem in practice?<o:p class=""></o:p></span></div><div class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1F497D" class=""><o:p class=""> </o:p></span></div><div class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1F497D" class="">Thanks,<o:p class=""></o:p></span></div><div class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1F497D" class=""><o:p class=""> </o:p></span></div><div class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1F497D" class="">Kristof<o:p class=""></o:p></span></div><div class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1F497D" class=""><o:p class=""> </o:p></span></div><div style="border:none;border-left:solid blue 1.5pt;padding:0cm 0cm 0cm 4.0pt" class=""><div class=""><div style="border:none;border-top:solid #B5C4DF 1.0pt;padding:3.0pt 0cm 0cm 0cm" class=""><div class="MsoNormal"><b class=""><span lang="EN-US" style="font-size:10.0pt;font-family:"Tahoma","sans-serif"" class="">From:</span></b><span lang="EN-US" style="font-size:10.0pt;font-family:"Tahoma","sans-serif"" class=""> James Molloy [<a href="mailto:james@jamesmolloy.co.uk" class="">mailto:james@jamesmolloy.co.uk</a>] <br class=""><b class="">Sent:</b> 04 June 2015 13:51<br class=""><b class="">To:</b> Kristof Beyls; Chris Matthews<br class=""><b class="">Cc:</b> llvm-commits<br class=""><b class="">Subject:</b> Re: [PATCH][LNT] Add ability to filter machines on daily report page + refactor LNT regression tests to enable properly testing it.<o:p class=""></o:p></span></div></div></div><div class="MsoNormal"><o:p class=""> </o:p></div><div class=""><p class="MsoNormal" style="margin-bottom:12.0pt">Hi Kristof,<o:p class=""></o:p></p><div class=""><div class="MsoNormal">I was thinking about this today, and I think the easiest way to work this from a UI perspective would be to just provide checkboxes next to the machine in the overview table - toggling these boxes would toggle the visibility of results from that run on-the-fly (via javascript), similar to how the new test regexp filter box works in the v4_runs page.<o:p class=""></o:p></div></div><div class=""><div class="MsoNormal"><o:p class=""> </o:p></div></div><div class=""><div class="MsoNormal">What do you think?<o:p class=""></o:p></div></div><div class=""><div class="MsoNormal"><o:p class=""> </o:p></div></div><div class=""><div class="MsoNormal">Cheers,<o:p class=""></o:p></div></div><div class=""><div class="MsoNormal"><o:p class=""> </o:p></div></div><div class=""><div class="MsoNormal">James<o:p class=""></o:p></div></div></div><div class="MsoNormal"><o:p class=""> </o:p></div><div class=""><div class=""><div class="MsoNormal">On Thu, 4 Jun 2015 at 12:09 Kristof Beyls <<a href="mailto:kristof.beyls@arm.com" class="">kristof.beyls@arm.com</a>> wrote:<o:p class=""></o:p></div></div><blockquote style="border:none;border-left:solid #CCCCCC 1.0pt;padding:0cm 0cm 0cm 6.0pt;margin-left:4.8pt;margin-right:0cm" class="" type="cite"><div class="MsoNormal">Thanks for the review, I've committed the test refactorings as<br class="">r238296-r238300. You're right, it makes sense to filter machines<br class="">based on a pattern rather than on the full name. I've considered<br class="">just a sub-string search, matching with a glob or matching with<br class="">a python regex. I feel that matching with a python regex is the<br class="">best solution as it allows the most flexible filtering.<br class=""><br class="">I went for "?filter-machine-regex=" to enable filtering on the<br class="">daily report webui and "--filter_machine_regex" to enable<br class="">filtering when using the lnt send-daily-report command.<br class=""><br class="">See attached patch for details. Does this look OK to you?<br class=""><br class="">Kristof<br class=""><br class="">> -----Original Message-----<br class="">> From: Chris Matthews [mailto:<a href="mailto:chris.matthews@apple.com" target="_blank" class="">chris.matthews@apple.com</a>]<br class="">> Sent: 26 May 2015 19:28<br class="">> To: Kristof Beyls<br class="">> Cc: llvm-commits<br class="">> Subject: Re: [PATCH][LNT] Add ability to filter machines on daily report<br class="">> page + refactor LNT regression tests to enable properly testing it.<br class="">><br class="">> I completely agree with this testing strategy. This is a much better way<br class="">> to test.<br class="">><br class="">> I'm fine with an explicit machine list, but I wonder if a more useful<br class="">> way to do this is to have a machine name filter? That way queries like<br class="">> "?filter-machine=AArch64&" could be possible along with an explicit<br class="">> "?filter-machine=lvm-juno-lnt-perf__LNT-AArch64-A53-<br class="">> O3__clang_DEV__aarch64&". Just substring matching on the machine name.<br class="">> That would make it very easy to grab classes of machines.<br class="">><br class="">> Please add period to end of comment on patch 6 line 46.<br class="">><br class="">> Could you update the command line daily report tool<br class="">> (lnt/lnttool/main.py:304) to also have this functioanltiy? I think the<br class="">> change should be really simple.<br class="">><br class="">> Otherwise looks good!<br class="">><br class="">> > On May 26, 2015, at 3:41 AM, Kristof Beyls <<a href="mailto:kristof.beyls@arm.com" target="_blank" class="">kristof.beyls@arm.com</a>><br class="">> wrote:<br class="">> ><br class="">> > Hi Chris,<br class="">> ><br class="">> > I'd like to be able to filter on the daily report page, e.g.<br class="">> > <a href="https://urldefense.proofpoint.com/v2/url?u=http-3A__llvm.org_perf_db-5Fdefault_v4_nts_daily-5Freport_2015_5_21-3Fnum-5Fdays&d=AwMFaQ&c=8hUWFZcy2Z-Za5rBPlktOQ&r=mQ4LZ2PUj9hpadE3cDHZnIdEwhEBrbAstXeMaFoB9tg&m=cn3DBvJBU8b-B5Z9jK1VNYAuz_SOIT3nZZ_pSim0wUE&s=LvnSvUxLkT0MeD7-uCQe17bwH61LqonKgNAL88t1Fjo&e=" target="_blank" class="">http://llvm.org/perf/db_default/v4/nts/daily_report/2015/5/21?num_days</a><br class="">> > =7, so that it only shows data for a subset of the builders. The<br class="">> > previous link shows many results coming from the penryn builders,<br class="">> > which make it hard to just investigate the results coming from the<br class="">> > juno board.<br class="">> ><br class="">> > 0006-Enable-filtering-of-machines-shown-on-LNT-daily-repo.patch adds<br class="">> > support for this; the user visible behaviour I went for is adding<br class="">> > machines={comma-separated list of machine names} to the query string<br class="">> > of the url, e.g.<br class="">> > <a href="https://urldefense.proofpoint.com/v2/url?u=http-3A__llvm.org_perf_db-5Fdefault_v4_nts_daily-5Freport_2015_5_21-3Fnum-5Fdays&d=AwMFaQ&c=8hUWFZcy2Z-Za5rBPlktOQ&r=mQ4LZ2PUj9hpadE3cDHZnIdEwhEBrbAstXeMaFoB9tg&m=cn3DBvJBU8b-B5Z9jK1VNYAuz_SOIT3nZZ_pSim0wUE&s=LvnSvUxLkT0MeD7-uCQe17bwH61LqonKgNAL88t1Fjo&e=" target="_blank" class="">http://llvm.org/perf/db_default/v4/nts/daily_report/2015/5/21?num_days</a><br class="">> > =7&mac<br class="">> > hines=llvm-juno-lnt-perf__LNT-AArch64-A53-O3__clang_DEV__aarch64.<br class="">> ><br class="">> > To be able to add a proper regression test/unit test for this, I also<br class="">> > had to refactor the LNT regression tests a bit, which is what the<br class="">> > other patches contain. In a number of steps, they transform the tests<br class="">> > using tests/SharedInputs/SmallInstance/lnt.db to using a database<br class="">> > constructed from human-readable SQL statements, creating the sqlite<br class="">> > file on the fly during test execution. This enables adding per-test<br class="">> > records to the database:<br class="">> ><br class="">> > - 0001-For-the-regression-tests-make-temporary-LNT-db-insta.patch<br class="">> > - 0002-Replace-binary-test-lnt.db-with-human-readable-text-.patch<br class="">> > - 0003-replace-hexadecimal-encoding-of-blobs-with-textual-r.patch<br class="">> > - 0004-remove-most-of-the-unnecessary-insert-statement-from.patch<br class="">> > - 0005-Enable-adding-test-specific-records-to-test-database.patch<br class="">> ><br class="">> > My hope is that this refactoring enables creating new functionality<br class="">> > for the LNT ui in a more Test-Driven Development way, which should<br class="">> > make it easier for more people to contribute to LNT & to reduce the<br class="">> > likelihood of regressions in LNT.<br class="">> ><br class="">> > What do you think?<br class="">> > Is the refactoring of the regression tests a step in the right<br class="">> direction?<br class="">> > Any objections to adding the machine= filter to the daily report page?<br class="">> ><br class="">> > Thanks,<br class="">> ><br class="">> > Kristof<br class="">> > <0001-For-the-regression-tests-make-temporary-LNT-db-insta.patch><0002<br class="">> > -Replace-binary-test-lnt.db-with-human-readable-text-.patch><0003-repl<br class="">> > ace-hexadecimal-encoding-of-blobs-with-textual-r.patch><0004-remove-mo<br class="">> > st-of-the-unnecessary-insert-statement-from.patch><0005-Enable-adding-<br class="">> > test-specific-records-to-test-database.patch><0006-Enable-filtering-of<br class="">> > -machines-shown-on-LNT-daily-repo.patch><br class=""><br class="">_______________________________________________<br class="">llvm-commits mailing list<br class=""><a href="mailto:llvm-commits@cs.uiuc.edu" target="_blank" class="">llvm-commits@cs.uiuc.edu</a><br class=""><a href="http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits" target="_blank" class="">http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits</a><o:p class=""></o:p></div></blockquote></div></div></div></div></div></blockquote></div><br class=""></body></html>