<div dir="ltr"><br><div class="gmail_extra"><br><div class="gmail_quote">2015-05-27 17:27 GMT-07:00 Duncan P. N. Exon Smith <span dir="ltr"><<a href="mailto:dexonsmith@apple.com" target="_blank">dexonsmith@apple.com</a>></span>:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><span><br>
> On 2015 May 27, at 11:43, Alex Lorenz <<a href="mailto:arphaman@gmail.com" target="_blank">arphaman@gmail.com</a>> wrote:<br>
><br>
> I rebased this patch on the reorganized initial MIR commit that landed in r238341.<br>
<br>
</span>and from elsewhere in the thread:<br>
<span>> Please take another look, since I rebased the patch based on reorganized MIR library.<br>
<br>
</span>I don't think this needs another review, unless you're suspicious<br>
of your rebase?<br></blockquote><div><br></div><div>I think the rebased patch is fine, I just moved things around so it's not a clean rebase.</div><div>I will commit this later today.</div><div><br></div><div>Alex</div><div> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<br>
Let me know if you really want someone to look, otherwise LGTM<br>
(somewhat blindly)!<br>
<span><br>
><br>
><br>
> REPOSITORY<br>
>  rL LLVM<br>
><br>
> <a href="https://urldefense.proofpoint.com/v2/url?u=http-3A__reviews.llvm.org_D9841&d=AwMFaQ&c=8hUWFZcy2Z-Za5rBPlktOQ&r=mQ4LZ2PUj9hpadE3cDHZnIdEwhEBrbAstXeMaFoB9tg&m=vgndxNF1h8AeUGmxz8CKaopEumSbG2yddB6OEfkAA9A&s=b8WRAGMUY7KA2BLH-2ekM2JUnd21j_KN3YJbd3x0zok&e=" target="_blank">http://reviews.llvm.org/D9841</a><br>
><br>
> Files:<br>
>  include/llvm/CodeGen/MIRYamlMapping.h<br>
>  lib/CodeGen/MIRParser/MIRParser.cpp<br>
>  lib/CodeGen/MIRPrintingPass.cpp<br>
>  test/CodeGen/MIR/machine-function-missing-name.mir<br>
>  test/CodeGen/MIR/machine-function.mir<br>
><br>
> EMAIL PREFERENCES<br>
>  <a href="https://urldefense.proofpoint.com/v2/url?u=http-3A__reviews.llvm.org_settings_panel_emailpreferences_&d=AwMFaQ&c=8hUWFZcy2Z-Za5rBPlktOQ&r=mQ4LZ2PUj9hpadE3cDHZnIdEwhEBrbAstXeMaFoB9tg&m=vgndxNF1h8AeUGmxz8CKaopEumSbG2yddB6OEfkAA9A&s=f0Iz8tMssqrBD3_2Wu3S2i0_aiovn_8lFxjSbdY648U&e=" target="_blank">http://reviews.llvm.org/settings/panel/emailpreferences/</a><br>
</span>> <D9841.26623.patch><br>
<br>
</blockquote></div><br></div></div>