<div dir="ltr"><div class="gmail_extra"><div class="gmail_quote">On Wed, May 27, 2015 at 5:13 AM, Rafael Espindola <span dir="ltr"><<a href="mailto:rafael.espindola@gmail.com" target="_blank">rafael.espindola@gmail.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Author: rafael<br>
Date: Wed May 27 07:13:06 2015<br>
New Revision: 238311<br>
<br>
URL: <a href="https://urldefense.proofpoint.com/v2/url?u=http-3A__llvm.org_viewvc_llvm-2Dproject-3Frev-3D238311-26view-3Drev&d=AwMFaQ&c=8hUWFZcy2Z-Za5rBPlktOQ&r=mQ4LZ2PUj9hpadE3cDHZnIdEwhEBrbAstXeMaFoB9tg&m=KOnCcmUdHrrqZbQAn-S59F0Fj--YW9z_XMeGfsidJoY&s=EB0CK_ISljXwscljqPixhYbpxdv_E67t4p_9XdPBJbo&e=" target="_blank">http://llvm.org/viewvc/llvm-project?rev=238311&view=rev</a><br>
Log:<br>
We always have an InstPrinter.<br>
<br>
Modified:<br>
    llvm/trunk/lib/MC/MCAsmStreamer.cpp<br>
<br>
Modified: llvm/trunk/lib/MC/MCAsmStreamer.cpp<br>
URL: <a href="https://urldefense.proofpoint.com/v2/url?u=http-3A__llvm.org_viewvc_llvm-2Dproject_llvm_trunk_lib_MC_MCAsmStreamer.cpp-3Frev-3D238311-26r1-3D238310-26r2-3D238311-26view-3Ddiff&d=AwMFaQ&c=8hUWFZcy2Z-Za5rBPlktOQ&r=mQ4LZ2PUj9hpadE3cDHZnIdEwhEBrbAstXeMaFoB9tg&m=KOnCcmUdHrrqZbQAn-S59F0Fj--YW9z_XMeGfsidJoY&s=1WmejqGWGBhIJss5AbT7NU3PNfFrpRXBWHhpCAQgdF8&e=" target="_blank">http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/MC/MCAsmStreamer.cpp?rev=238311&r1=238310&r2=238311&view=diff</a><br>
==============================================================================<br>
--- llvm/trunk/lib/MC/MCAsmStreamer.cpp (original)<br>
+++ llvm/trunk/lib/MC/MCAsmStreamer.cpp Wed May 27 07:13:06 2015<br>
@@ -65,8 +65,9 @@ public:<br>
         AsmBackend(asmbackend), CommentStream(CommentToEmit),<br>
         IsVerboseAsm(isVerboseAsm), ShowInst(showInst),<br>
         UseDwarfDirectory(useDwarfDirectory) {<br>
-    if (InstPrinter && IsVerboseAsm)<br>
-      InstPrinter->setCommentStream(CommentStream);<br>
+    assert(InstPrinter);<br>
+    if (IsVerboseAsm)<br>
+        InstPrinter->setCommentStream(CommentStream);<br>
   }<br></blockquote><div><br></div><div>Why the assert here?If there's a reason, why not in the other chunks too?</div><div><br></div><div>  Filipe</div><div><br></div><div> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">   inline void EmitEOL() {<br>
@@ -945,7 +946,7 @@ void MCAsmStreamer::EmitCFIEndProcImpl(M<br>
 }<br>
<br>
 void MCAsmStreamer::EmitRegisterName(int64_t Register) {<br>
-  if (InstPrinter && !MAI->useDwarfRegNumForCFI()) {<br>
+  if (!MAI->useDwarfRegNumForCFI()) {<br>
     const MCRegisterInfo *MRI = getContext().getRegisterInfo();<br>
     unsigned LLVMRegister = MRI->getLLVMRegNum(Register, true);<br>
     InstPrinter->printRegName(OS, LLVMRegister);<br>
@@ -1259,11 +1260,8 @@ void MCAsmStreamer::EmitInstruction(cons<br>
     GetCommentOS() << "\n";<br>
   }<br>
<br>
-  // If we have an AsmPrinter, use that to print, otherwise print the MCInst.<br>
-  if (InstPrinter)<br>
-    InstPrinter->printInst(&Inst, OS, "", STI);<br>
-  else<br>
-    Inst.print(OS);<br>
+  InstPrinter->printInst(&Inst, OS, "", STI);<br>
+<br>
   EmitEOL();<br>
 }<br>
<br>
<br>
<br>
_______________________________________________<br>
llvm-commits mailing list<br>
<a href="mailto:llvm-commits@cs.uiuc.edu">llvm-commits@cs.uiuc.edu</a><br>
<a href="http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits" target="_blank">http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits</a><br>
</blockquote></div><br></div></div>