<div dir="ltr"><br><div class="gmail_extra"><br><div class="gmail_quote">On Wed, May 27, 2015 at 6:24 PM, Sean Silva <span dir="ltr"><<a href="mailto:chisophugis@gmail.com" target="_blank">chisophugis@gmail.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr">I've always thought that it was confusing that SmallString internally did so much processing on the number you give it to actually choose the buffer size. Maybe we can just static_assert it is a power of 2 so it is always WYSIWYG?</div></blockquote><div><br></div><div>(and all the other conditions it does, such as requiring 0 to mean "no buffer")</div><div><br></div><div>-- Sean Silva</div><div> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr"><span class="HOEnZb"><font color="#888888"><div><br></div><div>-- Sean Silva</div></font></span></div><div class="HOEnZb"><div class="h5"><div class="gmail_extra"><br><div class="gmail_quote">On Sat, May 23, 2015 at 10:20 AM, Benjamin Kramer <span dir="ltr"><<a href="mailto:benny.kra@googlemail.com" target="_blank">benny.kra@googlemail.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Author: d0k<br>
Date: Sat May 23 12:20:53 2015<br>
New Revision: 238104<br>
<br>
URL: <a href="https://urldefense.proofpoint.com/v2/url?u=http-3A__llvm.org_viewvc_llvm-2Dproject-3Frev-3D238104-26view-3Drev&d=AwMFaQ&c=8hUWFZcy2Z-Za5rBPlktOQ&r=mQ4LZ2PUj9hpadE3cDHZnIdEwhEBrbAstXeMaFoB9tg&m=LgffmjNWeJcV6JlcUQDfPEiSOgj2pgD-jpzNpnH4P3M&s=eIshgBzGUrR9am1aclVZs8SiEXraBLPj9Oky-5Fd-bs&e=" target="_blank">http://llvm.org/viewvc/llvm-project?rev=238104&view=rev</a><br>
Log:<br>
Bump SmallString to the minimum required amount for raw_ostream to avoid allocation.<br>
<br>
NFC.<br>
<br>
Modified:<br>
    llvm/trunk/lib/Target/TargetMachine.cpp<br>
<br>
Modified: llvm/trunk/lib/Target/TargetMachine.cpp<br>
URL: <a href="https://urldefense.proofpoint.com/v2/url?u=http-3A__llvm.org_viewvc_llvm-2Dproject_llvm_trunk_lib_Target_TargetMachine.cpp-3Frev-3D238104-26r1-3D238103-26r2-3D238104-26view-3Ddiff&d=AwMFaQ&c=8hUWFZcy2Z-Za5rBPlktOQ&r=mQ4LZ2PUj9hpadE3cDHZnIdEwhEBrbAstXeMaFoB9tg&m=LgffmjNWeJcV6JlcUQDfPEiSOgj2pgD-jpzNpnH4P3M&s=byR9dkznNxcVkbpwNLg9jnUYqx6PQniW1mj5bHqhbTI&e=" target="_blank">http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Target/TargetMachine.cpp?rev=238104&r1=238103&r2=238104&view=diff</a><br>
==============================================================================<br>
--- llvm/trunk/lib/Target/TargetMachine.cpp (original)<br>
+++ llvm/trunk/lib/Target/TargetMachine.cpp Sat May 23 12:20:53 2015<br>
@@ -185,7 +185,7 @@ void TargetMachine::getNameWithPrefix(Sm<br>
 }<br>
<br>
 MCSymbol *TargetMachine::getSymbol(const GlobalValue *GV, Mangler &Mang) const {<br>
-  SmallString<60> NameStr;<br>
+  SmallString<128> NameStr;<br>
   getNameWithPrefix(NameStr, GV, Mang);<br>
   const TargetLoweringObjectFile *TLOF = getObjFileLowering();<br>
   return TLOF->getContext().getOrCreateSymbol(NameStr);<br>
<br>
<br>
_______________________________________________<br>
llvm-commits mailing list<br>
<a href="mailto:llvm-commits@cs.uiuc.edu" target="_blank">llvm-commits@cs.uiuc.edu</a><br>
<a href="http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits" target="_blank">http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits</a><br>
</blockquote></div><br></div>
</div></div></blockquote></div><br></div></div>