<div dir="ltr">I'm coming around to the position that we should simply disable this optimization for PIC calls to symbols with default visibility. The current change disables all tail calls when generating PIC code, which is undesirable.<div><br></div><div>We can add a flag later if someone asks, and call it -f[no-]optimize-pic-sibling-calls.</div></div><div class="gmail_extra"><br><div class="gmail_quote">On Wed, May 27, 2015 at 10:34 AM, David <span dir="ltr"><<a href="mailto:davidxl@google.com" target="_blank">davidxl@google.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Changing the default may affect users who depend on the current behavior which has been the case for a couple of releases.   Another possible solution is to emit a warning for cases like this so that debugging similar issues in the future will become easier.<br>
<div class="HOEnZb"><div class="h5"><br>
<br>
<a href="https://urldefense.proofpoint.com/v2/url?u=http-3A__reviews.llvm.org_D9799&d=AwMFaQ&c=8hUWFZcy2Z-Za5rBPlktOQ&r=mQ4LZ2PUj9hpadE3cDHZnIdEwhEBrbAstXeMaFoB9tg&m=ki5d_Hfc_nfQj7RMw5WzyZm_MTvwld8VFfpYUa6oTec&s=InkNfBNDO91CJzTaMGW8wFIWkh02V1mKiWghaFqS-kU&e=" target="_blank">http://reviews.llvm.org/D9799</a><br>
<br>
EMAIL PREFERENCES<br>
  <a href="https://urldefense.proofpoint.com/v2/url?u=http-3A__reviews.llvm.org_settings_panel_emailpreferences_&d=AwMFaQ&c=8hUWFZcy2Z-Za5rBPlktOQ&r=mQ4LZ2PUj9hpadE3cDHZnIdEwhEBrbAstXeMaFoB9tg&m=ki5d_Hfc_nfQj7RMw5WzyZm_MTvwld8VFfpYUa6oTec&s=JJDlMcHAB0XiuwyxHE4shpp0W68l2lv2Y55S5pSXOTE&e=" target="_blank">http://reviews.llvm.org/settings/panel/emailpreferences/</a><br>
<br>
<br>
</div></div></blockquote></div><br></div>