<div dir="ltr"><br><div class="gmail_extra"><br><div class="gmail_quote">On Mon, May 25, 2015 at 5:32 PM, Rafael Espindola <span dir="ltr"><<a href="mailto:rafael.espindola@gmail.com" target="_blank">rafael.espindola@gmail.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Author: rafael<br>
Date: Mon May 25 19:32:28 2015<br>
New Revision: 238161<br>
<br>
URL: <a href="https://urldefense.proofpoint.com/v2/url?u=http-3A__llvm.org_viewvc_llvm-2Dproject-3Frev-3D238161-26view-3Drev&d=AwMFaQ&c=8hUWFZcy2Z-Za5rBPlktOQ&r=mQ4LZ2PUj9hpadE3cDHZnIdEwhEBrbAstXeMaFoB9tg&m=ekVui95UX9_0SKt6i8RpRYbEnBUtXSohguqVQjxut9Q&s=4QFXEQJJO091GNVeCNzHEUPOFNeUlo4BS-ZWYUMEBfE&e=" target="_blank">http://llvm.org/viewvc/llvm-project?rev=238161&view=rev</a><br>
Log:<br>
Call the destructors of the MCSections.<br>
<br>
They now contain the fragments. If we don't call the destructors the<br>
fragments leak.<br>
<br>
Found by an asan bot.<br>
<br>
Modified:<br>
    llvm/trunk/lib/MC/MCContext.cpp<br>
<br>
Modified: llvm/trunk/lib/MC/MCContext.cpp<br>
URL: <a href="https://urldefense.proofpoint.com/v2/url?u=http-3A__llvm.org_viewvc_llvm-2Dproject_llvm_trunk_lib_MC_MCContext.cpp-3Frev-3D238161-26r1-3D238160-26r2-3D238161-26view-3Ddiff&d=AwMFaQ&c=8hUWFZcy2Z-Za5rBPlktOQ&r=mQ4LZ2PUj9hpadE3cDHZnIdEwhEBrbAstXeMaFoB9tg&m=ekVui95UX9_0SKt6i8RpRYbEnBUtXSohguqVQjxut9Q&s=ddzUI2D6F5gRLb3OC7Xcj5cHRLZStwTn4v1GIwsUHuk&e=" target="_blank">http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/MC/MCContext.cpp?rev=238161&r1=238160&r2=238161&view=diff</a><br>
==============================================================================<br>
--- llvm/trunk/lib/MC/MCContext.cpp (original)<br>
+++ llvm/trunk/lib/MC/MCContext.cpp Mon May 25 19:32:28 2015<br>
@@ -10,6 +10,7 @@<br>
 #include "llvm/MC/MCContext.h"<br>
 #include "llvm/ADT/SmallString.h"<br>
 #include "llvm/ADT/Twine.h"<br>
+#include "llvm/MC/MCAssembler.h"<br>
 #include "llvm/MC/MCAsmInfo.h"<br>
 #include "llvm/MC/MCDwarf.h"<br>
 #include "llvm/MC/MCLabel.h"<br>
@@ -54,6 +55,13 @@ MCContext::MCContext(const MCAsmInfo *ma<br>
 }<br>
<br>
 MCContext::~MCContext() {<br>
+  // Call the destructors so the fragments are freed<br>
+  for (auto &I : ELFUniquingMap)<br>
+    I.second->~MCSectionELF();<br></blockquote><div><br>I'm guessing these aren't actually deleted because they're allocated with a BumpPtrAllocator or something?<br> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
+  for (auto &I : COFFUniquingMap)<br>
+    I.second->~MCSectionCOFF();<br>
+  for (auto &I : MachOUniquingMap)<br>
+    I.second->~MCSectionMachO();<br>
<br>
   if (AutoReset)<br>
     reset();<br>
<br>
<br>
_______________________________________________<br>
llvm-commits mailing list<br>
<a href="mailto:llvm-commits@cs.uiuc.edu">llvm-commits@cs.uiuc.edu</a><br>
<a href="http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits" target="_blank">http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits</a><br>
</blockquote></div><br></div></div>