<div dir="ltr"><br><div class="gmail_extra"><br><div class="gmail_quote">On Tue, May 26, 2015 at 5:25 AM, Daniel Sanders <span dir="ltr"><<a href="mailto:daniel.sanders@imgtec.com" target="_blank">daniel.sanders@imgtec.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Author: dsanders<br>
Date: Tue May 26 07:25:36 2015<br>
New Revision: 238197<br>
<br>
URL: <a href="https://urldefense.proofpoint.com/v2/url?u=http-3A__llvm.org_viewvc_llvm-2Dproject-3Frev-3D238197-26view-3Drev&d=AwMFaQ&c=8hUWFZcy2Z-Za5rBPlktOQ&r=mQ4LZ2PUj9hpadE3cDHZnIdEwhEBrbAstXeMaFoB9tg&m=MzBa_oMdvLFd9X8neB_jCURmRw9-KkSe9uaQhhoTMZY&s=PhxhaHIKHRWLKRZfDAdo48weyr_CLLrAygNtXCJzfmk&e=" target="_blank">http://llvm.org/viewvc/llvm-project?rev=238197&view=rev</a><br>
Log:<br>
Fix warning introduced in r238190 about lack of virtual destructor in MCObjectFileInfo.<br>
<br>
<br>
Modified:<br>
    llvm/trunk/include/llvm/MC/MCObjectFileInfo.h<br>
<br>
Modified: llvm/trunk/include/llvm/MC/MCObjectFileInfo.h<br>
URL: <a href="https://urldefense.proofpoint.com/v2/url?u=http-3A__llvm.org_viewvc_llvm-2Dproject_llvm_trunk_include_llvm_MC_MCObjectFileInfo.h-3Frev-3D238197-26r1-3D238196-26r2-3D238197-26view-3Ddiff&d=AwMFaQ&c=8hUWFZcy2Z-Za5rBPlktOQ&r=mQ4LZ2PUj9hpadE3cDHZnIdEwhEBrbAstXeMaFoB9tg&m=MzBa_oMdvLFd9X8neB_jCURmRw9-KkSe9uaQhhoTMZY&s=beOKOryi3-euYAs2FOIsLoqW1GRv_5zQnlmSaTiy8po&e=" target="_blank">http://llvm.org/viewvc/llvm-project/llvm/trunk/include/llvm/MC/MCObjectFileInfo.h?rev=238197&r1=238196&r2=238197&view=diff</a><br>
==============================================================================<br>
--- llvm/trunk/include/llvm/MC/MCObjectFileInfo.h (original)<br>
+++ llvm/trunk/include/llvm/MC/MCObjectFileInfo.h Tue May 26 07:25:36 2015<br>
@@ -188,6 +188,8 @@ protected:<br>
   MCSection *XDataSection;<br>
<br>
 public:<br>
+  virtual ~MCObjectFileInfo() { };<br></blockquote><div><br>Are these objects actually destroyed polymorphically? If not, we should make the dtor non-virtual and protected and the derived classes should be final.<br> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
+<br>
   void InitMCObjectFileInfo(StringRef TT, Reloc::Model RM, CodeModel::Model CM,<br>
                             MCContext &ctx);<br>
<br>
<br>
<br>
_______________________________________________<br>
llvm-commits mailing list<br>
<a href="mailto:llvm-commits@cs.uiuc.edu">llvm-commits@cs.uiuc.edu</a><br>
<a href="http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits" target="_blank">http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits</a><br>
</blockquote></div><br></div></div>