<div dir="ltr">+thumbs up</div><div class="gmail_extra"><br><div class="gmail_quote">On Fri, May 22, 2015 at 9:01 AM, Benjamin Kramer <span dir="ltr"><<a href="mailto:benny.kra@googlemail.com" target="_blank">benny.kra@googlemail.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Author: d0k<br>
Date: Fri May 22 11:01:21 2015<br>
New Revision: 238030<br>
<br>
URL: <a href="https://urldefense.proofpoint.com/v2/url?u=http-3A__llvm.org_viewvc_llvm-2Dproject-3Frev-3D238030-26view-3Drev&d=AwMFaQ&c=8hUWFZcy2Z-Za5rBPlktOQ&r=mQ4LZ2PUj9hpadE3cDHZnIdEwhEBrbAstXeMaFoB9tg&m=Pk6hRqCBgCZkpAqgb8N2GRetBz4zlsDsOSmqZU_dnFY&s=KcRACeYLhC9pvQU6z5l30LcrULyl4xLReNqFmDO3S8E&e=" target="_blank">http://llvm.org/viewvc/llvm-project?rev=238030&view=rev</a><br>
Log:<br>
[ELF] Remove redundant unique_ptr moves found by -Wpessimizing-move.<br>
<br>
Modified:<br>
    lld/trunk/lib/ReaderWriter/ELF/Mips/MipsDynamicLibraryWriter.h<br>
    lld/trunk/lib/ReaderWriter/ELF/Mips/MipsExecutableWriter.h<br>
    lld/trunk/lib/ReaderWriter/ELF/OutputELFWriter.cpp<br>
    lld/trunk/lib/ReaderWriter/ELF/Reader.cpp<br>
<br>
Modified: lld/trunk/lib/ReaderWriter/ELF/Mips/MipsDynamicLibraryWriter.h<br>
URL: <a href="https://urldefense.proofpoint.com/v2/url?u=http-3A__llvm.org_viewvc_llvm-2Dproject_lld_trunk_lib_ReaderWriter_ELF_Mips_MipsDynamicLibraryWriter.h-3Frev-3D238030-26r1-3D238029-26r2-3D238030-26view-3Ddiff&d=AwMFaQ&c=8hUWFZcy2Z-Za5rBPlktOQ&r=mQ4LZ2PUj9hpadE3cDHZnIdEwhEBrbAstXeMaFoB9tg&m=Pk6hRqCBgCZkpAqgb8N2GRetBz4zlsDsOSmqZU_dnFY&s=t6GaE1Gr8vlRXsS6SJBLQ2TUZZhNY8YkXLZHsovppg4&e=" target="_blank">http://llvm.org/viewvc/llvm-project/lld/trunk/lib/ReaderWriter/ELF/Mips/MipsDynamicLibraryWriter.h?rev=238030&r1=238029&r2=238030&view=diff</a><br>
==============================================================================<br>
--- lld/trunk/lib/ReaderWriter/ELF/Mips/MipsDynamicLibraryWriter.h (original)<br>
+++ lld/trunk/lib/ReaderWriter/ELF/Mips/MipsDynamicLibraryWriter.h Fri May 22 11:01:21 2015<br>
@@ -61,7 +61,7 @@ template <class ELFT><br>
 void MipsDynamicLibraryWriter<ELFT>::createImplicitFiles(<br>
     std::vector<std::unique_ptr<File>> &result) {<br>
   DynamicLibraryWriter<ELFT>::createImplicitFiles(result);<br>
-  result.push_back(std::move(_writeHelper.createRuntimeFile()));<br>
+  result.push_back(_writeHelper.createRuntimeFile());<br>
 }<br>
<br>
 template <class ELFT><br>
<br>
Modified: lld/trunk/lib/ReaderWriter/ELF/Mips/MipsExecutableWriter.h<br>
URL: <a href="https://urldefense.proofpoint.com/v2/url?u=http-3A__llvm.org_viewvc_llvm-2Dproject_lld_trunk_lib_ReaderWriter_ELF_Mips_MipsExecutableWriter.h-3Frev-3D238030-26r1-3D238029-26r2-3D238030-26view-3Ddiff&d=AwMFaQ&c=8hUWFZcy2Z-Za5rBPlktOQ&r=mQ4LZ2PUj9hpadE3cDHZnIdEwhEBrbAstXeMaFoB9tg&m=Pk6hRqCBgCZkpAqgb8N2GRetBz4zlsDsOSmqZU_dnFY&s=YKy1CShRR4IGk9ys8HwFHY6nwjQv8mnPshaY6-Zhen8&e=" target="_blank">http://llvm.org/viewvc/llvm-project/lld/trunk/lib/ReaderWriter/ELF/Mips/MipsExecutableWriter.h?rev=238030&r1=238029&r2=238030&view=diff</a><br>
==============================================================================<br>
--- lld/trunk/lib/ReaderWriter/ELF/Mips/MipsExecutableWriter.h (original)<br>
+++ lld/trunk/lib/ReaderWriter/ELF/Mips/MipsExecutableWriter.h Fri May 22 11:01:21 2015<br>
@@ -113,7 +113,7 @@ template <class ELFT><br>
 void MipsExecutableWriter<ELFT>::createImplicitFiles(<br>
     std::vector<std::unique_ptr<File>> &result) {<br>
   ExecutableWriter<ELFT>::createImplicitFiles(result);<br>
-  result.push_back(std::move(_writeHelper.createRuntimeFile()));<br>
+  result.push_back(_writeHelper.createRuntimeFile());<br>
 }<br>
<br>
 template <class ELFT><br>
<br>
Modified: lld/trunk/lib/ReaderWriter/ELF/OutputELFWriter.cpp<br>
URL: <a href="https://urldefense.proofpoint.com/v2/url?u=http-3A__llvm.org_viewvc_llvm-2Dproject_lld_trunk_lib_ReaderWriter_ELF_OutputELFWriter.cpp-3Frev-3D238030-26r1-3D238029-26r2-3D238030-26view-3Ddiff&d=AwMFaQ&c=8hUWFZcy2Z-Za5rBPlktOQ&r=mQ4LZ2PUj9hpadE3cDHZnIdEwhEBrbAstXeMaFoB9tg&m=Pk6hRqCBgCZkpAqgb8N2GRetBz4zlsDsOSmqZU_dnFY&s=c-GH4LUuvF8y1UBqF6iSp7epZyuq4sxyMzLuICijQQk&e=" target="_blank">http://llvm.org/viewvc/llvm-project/lld/trunk/lib/ReaderWriter/ELF/OutputELFWriter.cpp?rev=238030&r1=238029&r2=238030&view=diff</a><br>
==============================================================================<br>
--- lld/trunk/lib/ReaderWriter/ELF/OutputELFWriter.cpp (original)<br>
+++ lld/trunk/lib/ReaderWriter/ELF/OutputELFWriter.cpp Fri May 22 11:01:21 2015<br>
@@ -242,7 +242,7 @@ template <class ELFT> void OutputELFWrit<br>
   // Don't create .symtab and .strtab sections if we're going to<br>
   // strip all the symbols.<br>
   if (!_ctx.stripSymbols()) {<br>
-    _symtab = std::move(this->createSymbolTable());<br>
+    _symtab = this->createSymbolTable();<br>
     _strtab.reset(new (_alloc) StringTable<ELFT>(<br>
         _ctx, ".strtab", TargetLayout<ELFT>::ORDER_STRING_TABLE));<br>
     _layout.addSection(_symtab.get());<br>
@@ -270,10 +270,10 @@ template <class ELFT> void OutputELFWrit<br>
   }<br>
<br>
   if (_ctx.isDynamic()) {<br>
-    _dynamicTable = std::move(createDynamicTable());<br>
+    _dynamicTable = createDynamicTable();<br>
     _dynamicStringTable.reset(new (_alloc) StringTable<ELFT>(<br>
         _ctx, ".dynstr", TargetLayout<ELFT>::ORDER_DYNAMIC_STRINGS, true));<br>
-    _dynamicSymbolTable = std::move(createDynamicSymbolTable());<br>
+    _dynamicSymbolTable = createDynamicSymbolTable();<br>
     _hashTable.reset(new (_alloc) HashSection<ELFT>(<br>
         _ctx, ".hash", TargetLayout<ELFT>::ORDER_HASH));<br>
     // Set the hash table in the dynamic symbol table so that the entries in the<br>
<br>
Modified: lld/trunk/lib/ReaderWriter/ELF/Reader.cpp<br>
URL: <a href="https://urldefense.proofpoint.com/v2/url?u=http-3A__llvm.org_viewvc_llvm-2Dproject_lld_trunk_lib_ReaderWriter_ELF_Reader.cpp-3Frev-3D238030-26r1-3D238029-26r2-3D238030-26view-3Ddiff&d=AwMFaQ&c=8hUWFZcy2Z-Za5rBPlktOQ&r=mQ4LZ2PUj9hpadE3cDHZnIdEwhEBrbAstXeMaFoB9tg&m=Pk6hRqCBgCZkpAqgb8N2GRetBz4zlsDsOSmqZU_dnFY&s=UfdpY7M02FIyEySDaew9MSB9Olg0doEn6L8E19I_qKw&e=" target="_blank">http://llvm.org/viewvc/llvm-project/lld/trunk/lib/ReaderWriter/ELF/Reader.cpp?rev=238030&r1=238029&r2=238030&view=diff</a><br>
==============================================================================<br>
--- lld/trunk/lib/ReaderWriter/ELF/Reader.cpp (original)<br>
+++ lld/trunk/lib/ReaderWriter/ELF/Reader.cpp Fri May 22 11:01:21 2015<br>
@@ -29,7 +29,7 @@ namespace lld {<br>
 void Registry::addSupportELFObjects(ELFLinkingContext &ctx) {<br>
<br>
   // Tell registry about the ELF object file parser.<br>
-  add(std::move(ctx.getTargetHandler().getObjReader()));<br>
+  add(ctx.getTargetHandler().getObjReader());<br>
<br>
   // Tell registry about the relocation name to number mapping for this arch.<br>
   ctx.registerRelocationNames(*this);<br>
<br>
<br>
_______________________________________________<br>
llvm-commits mailing list<br>
<a href="mailto:llvm-commits@cs.uiuc.edu">llvm-commits@cs.uiuc.edu</a><br>
<a href="http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits" target="_blank">http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits</a><br>
</blockquote></div><br></div>