<div dir="ltr">I just tested that EarlyCSE after NaryReassociate will work. <div><br></div><div>Not sure about the one after SLSR. Running EarlyCSE there used to emit significantly worse code, but things may have changed. Will test that too. </div></div><div class="gmail_extra"><br><div class="gmail_quote">On Fri, May 22, 2015 at 2:23 PM, Daniel Berlin <span dir="ltr"><<a href="mailto:dberlin@dberlin.org" target="_blank">dberlin@dberlin.org</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">FWIW: Rerunning GVN can be *really* expensive.<br>
I can make EarlyCSE really fast by removing the scoped hash table if<br>
that works for you instead?<br>
<div><div class="h5"><br>
<br>
<br>
On Fri, May 22, 2015 at 2:14 PM, Jingyue Wu <<a href="mailto:jingyue@google.com">jingyue@google.com</a>> wrote:<br>
> Hi broune, meheff,<br>
><br>
> This patch made two improvements to NaryReassociate and the NVPTX pipeline<br>
><br>
> 1. Run EarlyCSE/GVN after NaryReassociate to get rid of redundant common<br>
> expressions.<br>
><br>
> 2. When adding an instruction to SeenExprs, maps both the SCEV before and after<br>
> reassociation to that instruction.<br>
><br>
> <a href="https://urldefense.proofpoint.com/v2/url?u=http-3A__reviews.llvm.org_D9947&d=AwMFaQ&c=8hUWFZcy2Z-Za5rBPlktOQ&r=mQ4LZ2PUj9hpadE3cDHZnIdEwhEBrbAstXeMaFoB9tg&m=TEaI3UKOCBEeXBW9dWDsj6zZYLkgrXeNd5AEXjvNSyY&s=gbe9634tr2o1ejwjeptPX7lwz_CYP4z9wto1G9nlLpI&e=" target="_blank">http://reviews.llvm.org/D9947</a><br>
><br>
> Files:<br>
>   lib/Target/NVPTX/NVPTXTargetMachine.cpp<br>
>   lib/Transforms/Scalar/NaryReassociate.cpp<br>
>   test/Transforms/NaryReassociate/NVPTX/nary-gep.ll<br>
><br>
> EMAIL PREFERENCES<br>
>   <a href="https://urldefense.proofpoint.com/v2/url?u=http-3A__reviews.llvm.org_settings_panel_emailpreferences_&d=AwMFaQ&c=8hUWFZcy2Z-Za5rBPlktOQ&r=mQ4LZ2PUj9hpadE3cDHZnIdEwhEBrbAstXeMaFoB9tg&m=TEaI3UKOCBEeXBW9dWDsj6zZYLkgrXeNd5AEXjvNSyY&s=xJmS07T3kfHxG7nCoCGGt2giCFMp60zSR2Hrwh1W4iE&e=" target="_blank">http://reviews.llvm.org/settings/panel/emailpreferences/</a><br>
><br>
</div></div>> _______________________________________________<br>
> llvm-commits mailing list<br>
> <a href="mailto:llvm-commits@cs.uiuc.edu">llvm-commits@cs.uiuc.edu</a><br>
> <a href="http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits" target="_blank">http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits</a><br>
><br>
</blockquote></div><br></div>