<div dir="ltr"><br><div class="gmail_extra"><br><div class="gmail_quote">2015-05-20 13:27 GMT-07:00 Matthias Braun <span dir="ltr"><<a href="mailto:matze@braunis.de" target="_blank">matze@braunis.de</a>></span>:<br><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex"><span class="">> Thanks for checking.  This LGTM if Matthias agrees.<br>
<br>
<br>
</span>I still think LLLexer should be changed in the long term to use getNextChar() consistently and a range check included in it. While technically it can be indeed faster to check for a sentinel value like '\0' in this case the check was not included in the relevant switches but was a separate check in getNextChar() anyway, so I don't think it would have had any impact; Even if we would get rid of the check I'd be surprised if you could actually measure the difference.<br>
<br>
Anyway I can understand that we may not want to change it right now, so this patch LGTM.<br></blockquote><div><br></div><div>Thanks, I committed the patch in r237833.</div><div> </div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex">
<span class=""><br>
<br>
REPOSITORY<br>
  rL LLVM<br>
<br>
<a href="https://urldefense.proofpoint.com/v2/url?u=http-3A__reviews.llvm.org_D9883&d=AwMFaQ&c=8hUWFZcy2Z-Za5rBPlktOQ&r=mQ4LZ2PUj9hpadE3cDHZnIdEwhEBrbAstXeMaFoB9tg&m=oCd7No84JPVcjvCC3ILjLNpOd4SoB-lbDTU4EaeDQco&s=R3NvfjMqaMVoDW0azrYDmcoD5BFKFtE9VqhhgYMNHOw&e=" target="_blank">http://reviews.llvm.org/D9883</a><br>
<br>
</span>EMAIL PREFERENCES<br>
  <a href="https://urldefense.proofpoint.com/v2/url?u=http-3A__reviews.llvm.org_settings_panel_emailpreferences_&d=AwMFaQ&c=8hUWFZcy2Z-Za5rBPlktOQ&r=mQ4LZ2PUj9hpadE3cDHZnIdEwhEBrbAstXeMaFoB9tg&m=oCd7No84JPVcjvCC3ILjLNpOd4SoB-lbDTU4EaeDQco&s=ryDcuNHSKCxGH57raRZn2FiISQJQmoW1BBsF8CWXpNA&e=" target="_blank">http://reviews.llvm.org/settings/panel/emailpreferences/</a><br>
<br>
<br>
</blockquote></div><br></div></div>