<div dir="ltr"><br><div class="gmail_extra"><br><div class="gmail_quote">On Tue, May 19, 2015 at 11:24 AM, Sanjay Patel <span dir="ltr"><<a href="mailto:spatel@rotateright.com" target="_blank">spatel@rotateright.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Author: spatel<br>
Date: Tue May 19 13:24:33 2015<br>
New Revision: 237711<br>
<br>
URL: <a href="http://llvm.org/viewvc/llvm-project?rev=237711&view=rev" target="_blank">http://llvm.org/viewvc/llvm-project?rev=237711&view=rev</a><br>
Log:<br>
use range-based for-loop<br>
<br>
Modified:<br>
    llvm/trunk/lib/CodeGen/SelectionDAG/DAGCombiner.cpp<br>
<br>
Modified: llvm/trunk/lib/CodeGen/SelectionDAG/DAGCombiner.cpp<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/CodeGen/SelectionDAG/DAGCombiner.cpp?rev=237711&r1=237710&r2=237711&view=diff" target="_blank">http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/CodeGen/SelectionDAG/DAGCombiner.cpp?rev=237711&r1=237710&r2=237711&view=diff</a><br>
==============================================================================<br>
--- llvm/trunk/lib/CodeGen/SelectionDAG/DAGCombiner.cpp (original)<br>
+++ llvm/trunk/lib/CodeGen/SelectionDAG/DAGCombiner.cpp Tue May 19 13:24:33 2015<br>
@@ -8280,12 +8280,9 @@ SDValue DAGCombiner::visitFDIV(SDNode *N<br>
<br>
     SmallVector<SDNode *, 4> Users;<br>
     // Find all FDIV users of the same divisor.<br>
-    for (SDNode::use_iterator UI = N1.getNode()->use_begin(),<br>
-                              UE = N1.getNode()->use_end();<br>
-         UI != UE; ++UI) {<br>
-      SDNode *User = UI.getUse().getUser();<br>
-      if (User->getOpcode() == ISD::FDIV && User->getOperand(1) == N1)<br>
-        Users.push_back(User);<br>
+    for (auto U : N1->uses()) {<br>
+      if (U->getOpcode() == ISD::FDIV && U->getOperand(1) == N1)<br>
+        Users.push_back(U);<br>
     }<br>
<br>
     if (TLI.combineRepeatedFPDivisors(Users.size())) {<br>
@@ -8294,7 +8291,7 @@ SDValue DAGCombiner::visitFDIV(SDNode *N<br>
       SDValue Reciprocal = DAG.getNode(ISD::FDIV, DL, VT, FPOne, N1);<br>
<br>
       // Dividend / Divisor -> Dividend * Reciprocal<br>
-      for (auto &U : Users) {<br>
+      for (auto U : Users) {<br></blockquote><div><br>Pleas use "auto *" for pointer types, rather than straight "auto" - makes it clear there's no deep copying happening, etc. (same in the previous change above)<br> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
         if (U->getOperand(0) != FPOne) {<br>
           SDValue NewNode = DAG.getNode(ISD::FMUL, SDLoc(U), VT,<br>
                                         U->getOperand(0), Reciprocal);<br>
<br>
<br>
_______________________________________________<br>
llvm-commits mailing list<br>
<a href="mailto:llvm-commits@cs.uiuc.edu">llvm-commits@cs.uiuc.edu</a><br>
<a href="http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits" target="_blank">http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits</a><br>
</blockquote></div><br></div></div>