<div dir="rtl"><div dir="ltr">OK, reverted it.</div><div dir="ltr"><br></div></div><div class="gmail_extra"><div dir="ltr"><br><div class="gmail_quote">2015-05-19 14:46 GMT+03:00 Paweł Bylica <span dir="ltr"><<a href="mailto:chfast@gmail.com" target="_blank">chfast@gmail.com</a>></span>:<br><blockquote class="gmail_quote" style="margin:0 .8ex;border-left:1px #ccc solid;border-right:1px #ccc solid;padding-left:1ex;padding-right:1ex">I wanted to fix some MSVC warnings in LLVM headers, but it caused many problems like the one you fixed. I do not plan to put it back.<br><br>It requires a much more thinking about. And probably some global policy about headers C++ coding standards...</blockquote></div><div class="HOEnZb"><div class="h5"><br><div class="gmail_quote">On Tue, May 19, 2015 at 1:32 PM Yaron Keren <<a href="mailto:yaron.keren@gmail.com" target="_blank">yaron.keren@gmail.com</a>> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="rtl"><div dir="ltr">Oops, crossed e-mails.</div><div dir="ltr">Do you plan to bring this change back sometime? if so, at least this issue is fixed for you.</div><div dir="ltr"><br></div><div dir="ltr">If not I should revert my change as well, the cast is harmless but useless.</div><div dir="ltr"><br></div></div><div class="gmail_extra"><div dir="ltr"><br><div class="gmail_quote">2015-05-19 14:27 GMT+03:00 Paweł Bylica <span dir="ltr"><<a href="mailto:chfast@gmail.com" target="_blank">chfast@gmail.com</a>></span>:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">I reverted that change. Sorry about causing problems.<br></blockquote></div><div><div><br><div class="gmail_quote">On Tue, May 19, 2015 at 1:24 PM Yaron Keren <<a href="mailto:yaron.keren@gmail.com" target="_blank">yaron.keren@gmail.com</a>> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Author: yrnkrn<br>
Date: Tue May 19 06:18:10 2015<br>
New Revision: 237683<br>
<br>
URL: <a href="http://llvm.org/viewvc/llvm-project?rev=237683&view=rev" target="_blank">http://llvm.org/viewvc/llvm-project?rev=237683&view=rev</a><br>
Log:<br>
Fix Visual C++ errors C2784, C2780, C2782 after r237678.<br>
It does not like std::min(unsigned, uint32_t).<br>
<br>
<br>
Modified:<br>
    llvm/trunk/lib/IR/ConstantFold.cpp<br>
<br>
Modified: llvm/trunk/lib/IR/ConstantFold.cpp<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/IR/ConstantFold.cpp?rev=237683&r1=237682&r2=237683&view=diff" target="_blank">http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/IR/ConstantFold.cpp?rev=237683&r1=237682&r2=237683&view=diff</a><br>
==============================================================================<br>
--- llvm/trunk/lib/IR/ConstantFold.cpp (original)<br>
+++ llvm/trunk/lib/IR/ConstantFold.cpp Tue May 19 06:18:10 2015<br>
@@ -1057,7 +1057,8 @@ Constant *llvm::ConstantFoldBinaryInstru<br>
<br>
           if (GVAlign > 1) {<br>
             unsigned DstWidth = CI2->getType()->getBitWidth();<br>
-            unsigned SrcWidth = std::min(DstWidth, Log2_32(GVAlign));<br>
+            unsigned SrcWidth =<br>
+                std::min(DstWidth, static_cast<unsigned>(Log2_32(GVAlign)));<br>
             APInt BitsNotSet(APInt::getLowBitsSet(DstWidth, SrcWidth));<br>
<br>
             // If checking bits we know are clear, return zero.<br>
<br>
<br>
_______________________________________________<br>
llvm-commits mailing list<br>
<a href="mailto:llvm-commits@cs.uiuc.edu" target="_blank">llvm-commits@cs.uiuc.edu</a><br>
<a href="http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits" target="_blank">http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits</a><br>
</blockquote></div>
</div></div></div></div>
</blockquote></div>
</div></div></div></div>