<html><head><meta http-equiv="Content-Type" content="text/html charset=windows-1252"></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space;" class="">LGTM.<div class=""><br class=""><div><blockquote type="cite" class=""><div class="">On May 18, 2015, at 10:48 AM, Kristof Beyls <<a href="mailto:kristof.beyls@arm.com" class="">kristof.beyls@arm.com</a>> wrote:</div><br class="Apple-interchange-newline"><div class=""><div class="WordSection1" style="page: WordSection1; font-family: Helvetica; font-size: 13px; font-style: normal; font-variant: normal; font-weight: normal; letter-spacing: normal; line-height: normal; orphans: auto; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; widows: auto; word-spacing: 0px; -webkit-text-stroke-width: 0px;"><div style="margin: 0cm 0cm 0.0001pt; font-size: 11pt; font-family: Calibri, sans-serif;" class="">Hi,<o:p class=""></o:p></div><div style="margin: 0cm 0cm 0.0001pt; font-size: 11pt; font-family: Calibri, sans-serif;" class=""><o:p class=""> </o:p></div><div style="margin: 0cm 0cm 0.0001pt; font-size: 11pt; font-family: Calibri, sans-serif;" class="">The attached patch makes it possible to not submit specific metrics/stats to the server when doing an lnt benchmark-run.<o:p class=""></o:p></div><div style="margin: 0cm 0cm 0.0001pt; font-size: 11pt; font-family: Calibri, sans-serif;" class="">The use on the command line looks as follows:<span class="Apple-converted-space"> </span><span style="font-size: 10pt; font-family: 'Courier New';" class="">lnt runtest nt --submit … --exclude-stat-from-submission=compile …<o:p class=""></o:p></span></div><div style="margin: 0cm 0cm 0.0001pt; font-size: 11pt; font-family: Calibri, sans-serif;" class=""><span style="font-size: 10pt; font-family: 'Courier New';" class=""> </span></div><div style="margin: 0cm 0cm 0.0001pt; font-size: 11pt; font-family: Calibri, sans-serif;" class="">The motivation for being able to disable submitting certain stats is that the compile time metric on<br class=""><a href="http://llvm.org/perf/db_default/v4/nts/machine/39" style="color: purple; text-decoration: underline;" class="">http://llvm.org/perf/db_default/v4/nts/machine/39</a><span class="Apple-converted-space"> </span>should not be submitted, as it is highly noisy and not suitable for analysis.<br class="">The reason for that is that this is a big.LITTLE board, with 2 Cortex-A57s and 4 Cortex-A53s, and during different builds, the<br class="">same program will be compiled on a different set of A57s or A53s. I also don’t want to pin the compile on a single core, as that<br class="">would slow down the bot, and it’s main purpose is to measure the speed of generated AArch64 code.<o:p class=""></o:p></div><div style="margin: 0cm 0cm 0.0001pt; font-size: 11pt; font-family: Calibri, sans-serif;" class=""><o:p class=""> </o:p></div><div style="margin: 0cm 0cm 0.0001pt; font-size: 11pt; font-family: Calibri, sans-serif;" class="">Please review,<o:p class=""></o:p></div><div style="margin: 0cm 0cm 0.0001pt; font-size: 11pt; font-family: Calibri, sans-serif;" class=""><o:p class=""> </o:p></div><div style="margin: 0cm 0cm 0.0001pt; font-size: 11pt; font-family: Calibri, sans-serif;" class="">Kristof<o:p class=""></o:p></div><div style="margin: 0cm 0cm 0.0001pt; font-size: 11pt; font-family: Calibri, sans-serif;" class=""><o:p class=""> </o:p></div><div style="margin: 0cm 0cm 0.0001pt; font-size: 11pt; font-family: Calibri, sans-serif;" class=""><o:p class=""> </o:p></div></div><span id="cid:E753A41A-C9BA-4238-9C06-465E544ECDF7@apple.com"><disable_submission_of_certain_stats.diff></span></div></blockquote></div><br class=""></div></body></html>