<html><head><meta http-equiv="Content-Type" content="text/html charset=utf-8"></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space;" class="">Thanks for the quick review! r237309.<div class=""><br class=""></div><div class="">Pete<br class=""><div class=""><div><blockquote type="cite" class=""><div class="">On May 13, 2015, at 3:38 PM, David Blaikie <<a href="mailto:dblaikie@gmail.com" class="">dblaikie@gmail.com</a>> wrote:</div><br class="Apple-interchange-newline"><div class=""><div dir="ltr" class="">Looks like exactly the same SFINAE as the existing ArrayRef->ArrayRef case, so it sounds good to me.<br class=""><br class="">Thanks!<br class=""><br class="">- Dave</div><div class="gmail_extra"><br class=""><div class="gmail_quote">On Wed, May 13, 2015 at 3:31 PM, Pete Cooper <span dir="ltr" class=""><<a href="mailto:peter_cooper@apple.com" target="_blank" class="">peter_cooper@apple.com</a>></span> wrote:<br class=""><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Hi David<br class="">
<br class="">
This was on the discussion of r237226 (<a href="http://lists.cs.uiuc.edu/pipermail/llvm-commits/Week-of-Mon-20150511/276285.html" target="_blank" class="">http://lists.cs.uiuc.edu/pipermail/llvm-commits/Week-of-Mon-20150511/276285.html</a>).<br class="">
<br class="">
This patch allows construction of ArrayRef<const T*> from SmallVector<T*> and std::vector<T*>. This avoids having to use an intermediate call to makeArrayRef which is the current method to achieve this.<br class="">
<br class="">
I’ve used this to update the calls in LICM and SROA which had been changed to use makeArrayRef in r237226.<br class="">
<br class="">
Comments welcome.<br class="">
<br class="">
Cheers,<br class="">
Pete<br class="">
<br class="">
</blockquote></div><br class=""></div>
</div></blockquote></div><br class=""></div></div></body></html>