<div dir="ltr"><br><div class="gmail_extra"><br><div class="gmail_quote">On Fri, May 8, 2015 at 5:06 PM, Quentin Colombet <span dir="ltr"><<a href="mailto:qcolombet@apple.com" target="_blank">qcolombet@apple.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div style="word-wrap:break-word">I’ve reverted this commit in <span style="font-family:Menlo;font-size:11px">Committed revision 236919.</span></div></blockquote><div><br>Thanks - sorry about that.<br> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div style="word-wrap:break-word"><span class="HOEnZb"><font color="#888888"><div><br></div><div>Q.</div></font></span><div><div class="h5"><div><br><blockquote type="cite"><div>On May 8, 2015, at 4:28 PM, Quentin Colombet <<a href="mailto:qcolombet@apple.com" target="_blank">qcolombet@apple.com</a>> wrote:</div><br><div><div style="word-wrap:break-word">This one may be less exotic to reproduce :)<div><a href="http://lab.llvm.org:8080/green/job/clang-stage1-cmake-RA-incremental_check/8452/" target="_blank">http://lab.llvm.org:8080/green/job/clang-stage1-cmake-RA-incremental_check/8452/</a></div><div><br><div><blockquote type="cite"><div>On May 8, 2015, at 4:21 PM, Quentin Colombet <<a href="mailto:qcolombet@apple.com" target="_blank">qcolombet@apple.com</a>> wrote:</div><br><div><div style="word-wrap:break-word">Hi David,<div><br></div><div>Looks like this change broke a couple of bots:</div><div><a href="http://lab.llvm.org:8011/builders/clang-hexagon-elf/builds/26334" target="_blank">http://lab.llvm.org:8011/builders/clang-hexagon-elf/builds/26334</a></div><div><a href="http://lab.llvm.org:8011/builders/clang-cmake-thumbv7-a15/builds/2144" target="_blank">http://lab.llvm.org:8011/builders/clang-cmake-thumbv7-a15/builds/2144</a></div><div><br></div><div>Could you revert or fix please?</div><div><br></div><div>Thanks,</div><div>-Quentin<br><div><blockquote type="cite"><div>On May 8, 2015, at 3:47 PM, David Blaikie <<a href="mailto:dblaikie@gmail.com" target="_blank">dblaikie@gmail.com</a>> wrote:</div><br><div>Author: dblaikie<br>Date: Fri May  8 17:47:50 2015<br>New Revision: 236912<br><br>URL: <a href="http://llvm.org/viewvc/llvm-project?rev=236912&view=rev" target="_blank">http://llvm.org/viewvc/llvm-project?rev=236912&view=rev</a><br>Log:<br>[opaque pointer type] Cleanup a few references to pointee types using nearby non-pointee types of the same value<br><br>& cleanup a convoluted return expression while I'm here<br><br>Modified:<br>    llvm/trunk/lib/IR/Verifier.cpp<br><br>Modified: llvm/trunk/lib/IR/Verifier.cpp<br>URL: <a href="http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/IR/Verifier.cpp?rev=236912&r1=236911&r2=236912&view=diff" target="_blank">http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/IR/Verifier.cpp?rev=236912&r1=236911&r2=236912&view=diff</a><br>==============================================================================<br>--- llvm/trunk/lib/IR/Verifier.cpp (original)<br>+++ llvm/trunk/lib/IR/Verifier.cpp Fri May  8 17:47:50 2015<br>@@ -1503,7 +1503,7 @@ void Verifier::VerifyStatepoint(Immutabl<br>   const PointerType *PT = dyn_cast<PointerType>(Target->getType());<br>   Assert(PT && PT->getElementType()->isFunctionTy(),<br>          "gc.statepoint callee must be of function pointer type", &CI, Target);<br>-  FunctionType *TargetFuncType = cast<FunctionType>(PT->getElementType());<br>+  FunctionType *TargetFuncType = CS.getFunctionType();<br><br>   const Value *NumCallArgsV = CS.getArgument(1);<br>   Assert(isa<ConstantInt>(NumCallArgsV),<br>@@ -3065,8 +3065,8 @@ bool Verifier::VerifyIntrinsicType(Type<br>       dyn_cast<PointerType>(ThisArgVecTy->getVectorElementType());<br>     if (!ThisArgEltTy)<br>       return true;<br>-    return (!(ThisArgEltTy->getElementType() ==<br>-            ReferenceType->getVectorElementType()));<br>+    return ThisArgEltTy->getElementType() !=<br>+           ReferenceType->getVectorElementType();<br>   }<br>   }<br>   llvm_unreachable("unhandled");<br>@@ -3192,7 +3192,7 @@ void Verifier::visitIntrinsicFunctionCal<br>       Assert(AI, "llvm.gcroot parameter #1 must be an alloca.", &CI);<br>       Assert(isa<Constant>(CI.getArgOperand(1)),<br>              "llvm.gcroot parameter #2 must be a constant.", &CI);<br>-      if (!AI->getType()->getElementType()->isPointerTy()) {<br>+      if (!AI->getAllocatedType()->isPointerTy()) {<br>         Assert(!isa<ConstantPointerNull>(CI.getArgOperand(1)),<br>                "llvm.gcroot parameter #1 must either be a pointer alloca, "<br>                "or argument #2 must be a non-null constant.",<br><br><br>_______________________________________________<br>llvm-commits mailing list<br><a href="mailto:llvm-commits@cs.uiuc.edu" target="_blank">llvm-commits@cs.uiuc.edu</a><br><a href="http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits" target="_blank">http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits</a><br></div></blockquote></div><br></div></div>_______________________________________________<br>llvm-commits mailing list<br><a href="mailto:llvm-commits@cs.uiuc.edu" target="_blank">llvm-commits@cs.uiuc.edu</a><br><a href="http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits" target="_blank">http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits</a><br></div></blockquote></div><br></div></div>_______________________________________________<br>llvm-commits mailing list<br><a href="mailto:llvm-commits@cs.uiuc.edu" target="_blank">llvm-commits@cs.uiuc.edu</a><br><a href="http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits" target="_blank">http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits</a><br></div></blockquote></div><br></div></div></div></blockquote></div><br></div></div>