<div dir="ltr"><br><div class="gmail_extra"><br><div class="gmail_quote">On Mon, May 4, 2015 at 4:01 PM, Eric Christopher <span dir="ltr"><<a href="mailto:echristo@gmail.com" target="_blank">echristo@gmail.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr">You can use llvm-as %s -o - | llvm-dis | FileCheck or something similar.</div></blockquote><div><br>Doesn't actually test the upgrading, since the assembler will produce current bitcode, not the old stuff that needs upgrading.<br><br>For all the autoupgrade support for bitcode changes I've been making I've just checked in old bitcode.<br> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr"><span class="HOEnZb"><font color="#888888"><br><br>-eric<br></font></span></div><div class="HOEnZb"><div class="h5"><br><div class="gmail_quote">On Mon, May 4, 2015 at 4:00 PM Adrian Prantl <<a href="mailto:aprantl@apple.com" target="_blank">aprantl@apple.com</a>> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Here's the requested autoupgrade code.<br>
<br>
Duncan, is the ad-hoc fashion I implemented this the way to go, or is there a way to better separate the upgrades from the parser?<br>
Also, is there a way to test the autoupgrade without checking in binary bitcode?<br>
<br>
<br>
<a href="http://reviews.llvm.org/D9488" target="_blank">http://reviews.llvm.org/D9488</a><br>
<br>
Files:<br>
  include/llvm/IR/DIBuilder.h<br>
  include/llvm/IR/DebugInfoMetadata.h<br>
  lib/AsmParser/LLParser.cpp<br>
  lib/Bitcode/Reader/BitcodeReader.cpp<br>
  lib/Bitcode/Writer/BitcodeWriter.cpp<br>
  lib/IR/AsmWriter.cpp<br>
  lib/IR/DIBuilder.cpp<br>
  lib/IR/DebugInfoMetadata.cpp<br>
  lib/IR/LLVMContextImpl.h<br>
  test/Assembler/mdcompileunit.ll<br>
  unittests/IR/MetadataTest.cpp<br>
<br>
EMAIL PREFERENCES<br>
  <a href="http://reviews.llvm.org/settings/panel/emailpreferences/" target="_blank">http://reviews.llvm.org/settings/panel/emailpreferences/</a><br>
</blockquote></div>
</div></div></blockquote></div><br></div></div>