<div dir="ltr">Should be pretty simple. If you need a hand let me know.<br><br>-eric<br></div><br><div class="gmail_quote">On Mon, May 4, 2015 at 9:55 AM Tom Stellard <<a href="mailto:tom@stellard.net">tom@stellard.net</a>> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">On Tue, Apr 28, 2015 at 05:58:51PM +0000, Eric Christopher wrote:<br>
> Does this really need to be a subtarget feature? It's weird and seems like<br>
> it should just be a command line option.<br>
><br>
<br>
It could be a command line option.  I will look into this.<br>
<br>
-Tom<br>
<br>
> -eric<br>
><br>
> On Tue, Apr 28, 2015 at 10:48 AM Tom Stellard <<a href="mailto:thomas.stellard@amd.com" target="_blank">thomas.stellard@amd.com</a>><br>
> wrote:<br>
><br>
> > Author: tstellar<br>
> > Date: Tue Apr 28 12:37:00 2015<br>
> > New Revision: 236003<br>
> ><br>
> > URL: <a href="http://llvm.org/viewvc/llvm-project?rev=236003&view=rev" target="_blank">http://llvm.org/viewvc/llvm-project?rev=236003&view=rev</a><br>
> > Log:<br>
> > R600/SI: Add a lower case alias for subtarget feature: +DumpCode<br>
> ><br>
> > llc converts all feature strings to lower case, while the LLVM C API<br>
> > does not, so we need a lower case alias in order to test this with llc.<br>
> ><br>
> > Modified:<br>
> >     llvm/trunk/lib/Target/R600/AMDGPU.td<br>
> ><br>
> > Modified: llvm/trunk/lib/Target/R600/AMDGPU.td<br>
> > URL:<br>
> > <a href="http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Target/R600/AMDGPU.td?rev=236003&r1=236002&r2=236003&view=diff" target="_blank">http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Target/R600/AMDGPU.td?rev=236003&r1=236002&r2=236003&view=diff</a><br>
> ><br>
> > ==============================================================================<br>
> > --- llvm/trunk/lib/Target/R600/AMDGPU.td (original)<br>
> > +++ llvm/trunk/lib/Target/R600/AMDGPU.td Tue Apr 28 12:37:00 2015<br>
> > @@ -20,6 +20,11 @@ def FeatureDumpCode : SubtargetFeature <<br>
> >          "true",<br>
> >          "Dump MachineInstrs in the CodeEmitter">;<br>
> ><br>
> > +def FeatureDumpCodeLower : SubtargetFeature <"dumpcode",<br>
> > +        "DumpCode",<br>
> > +        "true",<br>
> > +        "Dump MachineInstrs in the CodeEmitter">;<br>
> > +<br>
> >  def FeatureIRStructurizer : SubtargetFeature <"disable-irstructurizer",<br>
> >          "EnableIRStructurizer",<br>
> >          "false",<br>
> ><br>
> ><br>
> > _______________________________________________<br>
> > llvm-commits mailing list<br>
> > <a href="mailto:llvm-commits@cs.uiuc.edu" target="_blank">llvm-commits@cs.uiuc.edu</a><br>
> > <a href="http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits" target="_blank">http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits</a><br>
> ><br>
<br>
> _______________________________________________<br>
> llvm-commits mailing list<br>
> <a href="mailto:llvm-commits@cs.uiuc.edu" target="_blank">llvm-commits@cs.uiuc.edu</a><br>
> <a href="http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits" target="_blank">http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits</a><br>
<br>
</blockquote></div>