<html><head><meta http-equiv="Content-Type" content="text/html charset=utf-8"></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space;" class=""><div class="">It’s because of these lines in ubsan_diag.cc in MaybePrintStackTrace:</div><div class=""><br class=""></div><div class=""><div class=""> if (StackTrace::WillUseFastUnwind(false))</div><div class=""> return;</div></div><div class=""><br class=""></div><div class="">On Darwin, we only have fast unwind working, so WillUseFastUnwind is always true. Removing these two lines makes the test pass, but it probably has some other bad consequences.</div><div class=""><br class=""></div><div class="">Kuba</div><br class=""><div><blockquote type="cite" class=""><div class="">On Apr 29, 2015, at 11:56 PM, Alexey Samsonov <<a href="mailto:vonosmas@gmail.com" class="">vonosmas@gmail.com</a>> wrote:</div><br class="Apple-interchange-newline"><div class=""><div dir="ltr" class="">(sigh) reverted to XFAIL again in r236165. Kuba, could you take a look at why UBSAN_OPTIONS=print_stacktrace=1 doesn't trigger printing a stacktrace on Darwin?</div><div class="gmail_extra"><br class=""><div class="gmail_quote">On Wed, Apr 29, 2015 at 1:46 PM, Alexey Samsonov <span dir="ltr" class=""><<a href="mailto:vonosmas@gmail.com" target="_blank" class="">vonosmas@gmail.com</a>></span> wrote:<br class=""><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr" class="">I've submitted r236152 that improves the test case and once again removes XFAIL:darwin. Watching the bot (<a href="http://lab.llvm.org:8080/green/job/clang-stage1-cmake-RA_check/" target="_blank" class="">http://lab.llvm.org:8080/green/job/clang-stage1-cmake-RA_check/</a>).</div><div class="gmail_extra"><div class=""><div class="h5"><br class=""><div class="gmail_quote">On Wed, Apr 29, 2015 at 11:41 AM, Alexey Samsonov <span dir="ltr" class=""><<a href="mailto:vonosmas@gmail.com" target="_blank" class="">vonosmas@gmail.com</a>></span> wrote:<br class=""><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr" class=""><div class="gmail_extra"><br class=""><div class="gmail_quote"><span class="">On Wed, Apr 29, 2015 at 10:52 AM, Ahmed Bougacha <span dir="ltr" class=""><<a href="mailto:ahmed.bougacha@gmail.com" target="_blank" class="">ahmed.bougacha@gmail.com</a>></span> wrote:<br class=""><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">I went ahead and XFAIL-ed vptr.cpp in r236135,</blockquote><div class=""><br class=""></div></span><div class="">Sure, thank you! Sorry for the breakage.</div><span class=""><div class=""> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"> let me know if you need<br class="">
help reproducing.<br class=""></blockquote><div class=""><br class=""></div></span><div class="">I think I know what the issue is (UBSan on Mac doesn't support weak hooks). I'll get back to you and ask to test the patch shortly.</div><div class=""><div class=""><div class=""> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<span class=""><font color="#888888" class=""><br class="">
-Ahmed<br class="">
</font></span><div class=""><div class=""><br class="">
<br class="">
On Tue, Apr 28, 2015 at 5:41 PM, Ahmed Bougacha<br class="">
<<a href="mailto:ahmed.bougacha@gmail.com" target="_blank" class="">ahmed.bougacha@gmail.com</a>> wrote:<br class="">
> On Mon, Apr 27, 2015 at 6:29 PM, Alexey Samsonov <<a href="mailto:vonosmas@gmail.com" target="_blank" class="">vonosmas@gmail.com</a>> wrote:<br class="">
>> Author: samsonov<br class="">
>> Date: Mon Apr 27 20:29:36 2015<br class="">
>> New Revision: 235961<br class="">
>><br class="">
>> URL: <a href="http://llvm.org/viewvc/llvm-project?rev=235961&view=rev" target="_blank" class="">http://llvm.org/viewvc/llvm-project?rev=235961&view=rev</a><br class="">
>> Log:<br class="">
>> Address old FIXMEs in UBSan test cases.<br class="">
>><br class="">
>> Modified:<br class="">
>> compiler-rt/trunk/test/ubsan/TestCases/Float/cast-overflow.cpp<br class="">
>> compiler-rt/trunk/test/ubsan/TestCases/TypeCheck/vptr.cpp<br class="">
>><br class="">
>> Modified: compiler-rt/trunk/test/ubsan/TestCases/Float/cast-overflow.cpp<br class="">
>> URL: <a href="http://llvm.org/viewvc/llvm-project/compiler-rt/trunk/test/ubsan/TestCases/Float/cast-overflow.cpp?rev=235961&r1=235960&r2=235961&view=diff" target="_blank" class="">http://llvm.org/viewvc/llvm-project/compiler-rt/trunk/test/ubsan/TestCases/Float/cast-overflow.cpp?rev=235961&r1=235960&r2=235961&view=diff</a><br class="">
>> ==============================================================================<br class="">
>> --- compiler-rt/trunk/test/ubsan/TestCases/Float/cast-overflow.cpp (original)<br class="">
>> +++ compiler-rt/trunk/test/ubsan/TestCases/Float/cast-overflow.cpp Mon Apr 27 20:29:36 2015<br class="">
>> @@ -1,4 +1,3 @@<br class="">
>> -// FIXME: run this (and other) UBSan tests in both 32- and 64-bit modes (?).<br class="">
>> // RUN: %clangxx -fsanitize=float-cast-overflow -g %s -o %t<br class="">
>> // RUN: %run %t _<br class="">
>> // RUN: env UBSAN_OPTIONS=print_summary=1 %run %t 0 2>&1 | FileCheck %s --check-prefix=CHECK-0<br class="">
>><br class="">
>> Modified: compiler-rt/trunk/test/ubsan/TestCases/TypeCheck/vptr.cpp<br class="">
>> URL: <a href="http://llvm.org/viewvc/llvm-project/compiler-rt/trunk/test/ubsan/TestCases/TypeCheck/vptr.cpp?rev=235961&r1=235960&r2=235961&view=diff" target="_blank" class="">http://llvm.org/viewvc/llvm-project/compiler-rt/trunk/test/ubsan/TestCases/TypeCheck/vptr.cpp?rev=235961&r1=235960&r2=235961&view=diff</a><br class="">
>> ==============================================================================<br class="">
>> --- compiler-rt/trunk/test/ubsan/TestCases/TypeCheck/vptr.cpp (original)<br class="">
>> +++ compiler-rt/trunk/test/ubsan/TestCases/TypeCheck/vptr.cpp Mon Apr 27 20:29:36 2015<br class="">
>> @@ -23,8 +23,6 @@<br class="">
>> // RUN: echo "vptr_check:S" > %t.loc-supp<br class="">
>> // RUN: UBSAN_OPTIONS="suppressions='%t.loc-supp':halt_on_error=1" not %run %t x- 2>&1 | FileCheck %s --check-prefix=CHECK-LOC-SUPPRESS<br class="">
>><br class="">
>> -// FIXME: This test produces linker errors on Darwin.<br class="">
>> -// XFAIL: darwin<br class="">
><br class="">
> Hi Alexey,<br class="">
><br class="">
> Seems like this test still doesn't pass on Darwin, though for reasons<br class="">
> other than "linker errors"; see e.g.:<br class="">
><br class="">
> <a href="http://lab.llvm.org:8080/green/job/clang-stage1-cmake-RA_check/3415/testReport/junit/UBSan-Standalone-x86_64/TestCases_TypeCheck/vptr_cpp/" target="_blank" class="">http://lab.llvm.org:8080/green/job/clang-stage1-cmake-RA_check/3415/testReport/junit/UBSan-Standalone-x86_64/TestCases_TypeCheck/vptr_cpp/</a><br class="">
><br class="">
> (and all following builds on that bot.) Can you have a look?<br class="">
><br class="">
> Thanks!<br class="">
> -Ahmed<br class="">
><br class="">
>> // REQUIRES: stable-runtime<br class="">
>> #include <new><br class="">
>><br class="">
>><br class="">
>><br class="">
>> _______________________________________________<br class="">
>> llvm-commits mailing list<br class="">
>> <a href="mailto:llvm-commits@cs.uiuc.edu" target="_blank" class="">llvm-commits@cs.uiuc.edu</a><br class="">
>> <a href="http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits" target="_blank" class="">http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits</a><br class="">
</div></div></blockquote></div></div></div><span class=""><font color="#888888" class=""><br class=""><br clear="all" class=""><div class=""><br class=""></div>-- <br class=""><div class=""><div dir="ltr" class="">Alexey Samsonov<br class=""><a href="mailto:vonosmas@gmail.com" target="_blank" class="">vonosmas@gmail.com</a></div></div>
</font></span></div></div>
</blockquote></div><br class=""><br clear="all" class=""><div class=""><br class=""></div></div></div><span class="HOEnZb"><font color="#888888" class="">-- <br class=""><div class=""><div dir="ltr" class="">Alexey Samsonov<br class=""><a href="mailto:vonosmas@gmail.com" target="_blank" class="">vonosmas@gmail.com</a></div></div>
</font></span></div>
</blockquote></div><br class=""><br clear="all" class=""><div class=""><br class=""></div>-- <br class=""><div class="gmail_signature"><div dir="ltr" class="">Alexey Samsonov<br class=""><a href="mailto:vonosmas@gmail.com" target="_blank" class="">vonosmas@gmail.com</a></div></div>
</div>
</div></blockquote></div><br class=""></body></html>