<div dir="ltr"><br><br><div class="gmail_quote">On Wed, Apr 29, 2015 at 1:42 PM Tom Stellard <<a href="mailto:tom@stellard.net">tom@stellard.net</a>> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">On Wed, Apr 29, 2015 at 07:15:08PM -0000, Douglas Katzman wrote:<br>
> Author: dougk<br>
> Date: Wed Apr 29 14:15:08 2015<br>
> New Revision: 236139<br>
><br>
> URL: <a href="http://llvm.org/viewvc/llvm-project?rev=236139&view=rev" target="_blank">http://llvm.org/viewvc/llvm-project?rev=236139&view=rev</a><br>
> Log:<br>
> New architecture name - 'sparcel' for Sparc little-endian.<br>
><br>
> Differential Revision: <a href="http://reviews.llvm.org/D9263" target="_blank">http://reviews.llvm.org/D9263</a><br>
><br>
> Modified:<br>
>     llvm/trunk/include/llvm/ADT/Triple.h<br>
>     llvm/trunk/lib/Support/Triple.cpp<br>
>     llvm/trunk/unittests/ADT/TripleTest.cpp<br>
><br>
> Modified: llvm/trunk/include/llvm/ADT/Triple.h<br>
> URL: <a href="http://llvm.org/viewvc/llvm-project/llvm/trunk/include/llvm/ADT/Triple.h?rev=236139&r1=236138&r2=236139&view=diff" target="_blank">http://llvm.org/viewvc/llvm-project/llvm/trunk/include/llvm/ADT/Triple.h?rev=236139&r1=236138&r2=236139&view=diff</a><br>
> ==============================================================================<br>
> --- llvm/trunk/include/llvm/ADT/Triple.h (original)<br>
> +++ llvm/trunk/include/llvm/ADT/Triple.h Wed Apr 29 14:15:08 2015<br>
> @@ -64,6 +64,7 @@ public:<br>
>      amdgcn,     // AMDGCN: AMD GCN GPUs<br>
>      sparc,      // Sparc: sparc<br>
>      sparcv9,    // Sparcv9: Sparcv9<br>
> +    sparcel,    // Sparc: (endianness = little). NB: 'Sparcle' is a CPU variant<br>
<br>
Hi,<br>
<br>
This comment is confusing to me.  What does 'NB' mean? Is it 'Sparcle' or 'Sparcel'?<br></blockquote><div><br></div><div><a href="http://en.wikipedia.org/wiki/Nota_bene">http://en.wikipedia.org/wiki/Nota_bene</a><br></div><div><br></div><div>Basically he's saying we didn't go with "Sparcle" for the little endian sparc target because it's already a processor name.</div><div><br></div><div>-eric</div><div> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<br>
-Tom<br>
<br>
>      systemz,    // SystemZ: s390x<br>
>      tce,        // TCE (<a href="http://tce.cs.tut.fi/" target="_blank">http://tce.cs.tut.fi/</a>): tce<br>
>      thumb,      // Thumb (little endian): thumb, thumbv.*<br>
><br>
> Modified: llvm/trunk/lib/Support/Triple.cpp<br>
> URL: <a href="http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Support/Triple.cpp?rev=236139&r1=236138&r2=236139&view=diff" target="_blank">http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Support/Triple.cpp?rev=236139&r1=236138&r2=236139&view=diff</a><br>
> ==============================================================================<br>
> --- llvm/trunk/lib/Support/Triple.cpp (original)<br>
> +++ llvm/trunk/lib/Support/Triple.cpp Wed Apr 29 14:15:08 2015<br>
> @@ -37,6 +37,7 @@ const char *Triple::getArchTypeName(Arch<br>
>    case amdgcn:      return "amdgcn";<br>
>    case sparc:       return "sparc";<br>
>    case sparcv9:     return "sparcv9";<br>
> +  case sparcel:     return "sparcel";<br>
>    case systemz:     return "s390x";<br>
>    case tce:         return "tce";<br>
>    case thumb:       return "thumb";<br>
> @@ -90,6 +91,7 @@ const char *Triple::getArchTypePrefix(Ar<br>
>    case bpf:         return "bpf";<br>
><br>
>    case sparcv9:<br>
> +  case sparcel:<br>
>    case sparc:       return "sparc";<br>
><br>
>    case systemz:     return "s390";<br>
> @@ -312,6 +314,7 @@ static Triple::ArchType parseArch(String<br>
>      .Case("hexagon", Triple::hexagon)<br>
>      .Case("s390x", Triple::systemz)<br>
>      .Case("sparc", Triple::sparc)<br>
> +    .Case("sparcel", Triple::sparcel)<br>
>      .Cases("sparcv9", "sparc64", Triple::sparcv9)<br>
>      .Case("tce", Triple::tce)<br>
>      .Case("xcore", Triple::xcore)<br>
> @@ -918,6 +921,7 @@ static unsigned getArchPointerBitWidth(l<br>
>    case llvm::Triple::ppc:<br>
>    case llvm::Triple::r600:<br>
>    case llvm::Triple::sparc:<br>
> +  case llvm::Triple::sparcel:<br>
>    case llvm::Triple::tce:<br>
>    case llvm::Triple::thumb:<br>
>    case llvm::Triple::thumbeb:<br>
> @@ -990,6 +994,7 @@ Triple Triple::get32BitArchVariant() con<br>
>    case Triple::ppc:<br>
>    case Triple::r600:<br>
>    case Triple::sparc:<br>
> +  case Triple::sparcel:<br>
>    case Triple::tce:<br>
>    case Triple::thumb:<br>
>    case Triple::thumbeb:<br>
> @@ -1026,6 +1031,7 @@ Triple Triple::get64BitArchVariant() con<br>
>    case Triple::thumb:<br>
>    case Triple::thumbeb:<br>
>    case Triple::xcore:<br>
> +  case Triple::sparcel:<br>
>      T.setArch(UnknownArch);<br>
>      break;<br>
><br>
><br>
> Modified: llvm/trunk/unittests/ADT/TripleTest.cpp<br>
> URL: <a href="http://llvm.org/viewvc/llvm-project/llvm/trunk/unittests/ADT/TripleTest.cpp?rev=236139&r1=236138&r2=236139&view=diff" target="_blank">http://llvm.org/viewvc/llvm-project/llvm/trunk/unittests/ADT/TripleTest.cpp?rev=236139&r1=236138&r2=236139&view=diff</a><br>
> ==============================================================================<br>
> --- llvm/trunk/unittests/ADT/TripleTest.cpp (original)<br>
> +++ llvm/trunk/unittests/ADT/TripleTest.cpp Wed Apr 29 14:15:08 2015<br>
> @@ -149,6 +149,11 @@ TEST(TripleTest, ParsedIDs) {<br>
>    EXPECT_EQ(Triple::UnknownVendor, T.getVendor());<br>
>    EXPECT_EQ(Triple::UnknownOS, T.getOS());<br>
><br>
> +  T = Triple("sparcel-unknown-unknown");<br>
> +  EXPECT_EQ(Triple::sparcel, T.getArch());<br>
> +  EXPECT_EQ(Triple::UnknownVendor, T.getVendor());<br>
> +  EXPECT_EQ(Triple::UnknownOS, T.getOS());<br>
> +<br>
>    T = Triple("spir-unknown-unknown");<br>
>    EXPECT_EQ(Triple::spir, T.getArch());<br>
>    EXPECT_EQ(Triple::UnknownVendor, T.getVendor());<br>
> @@ -407,6 +412,21 @@ TEST(TripleTest, BitWidthPredicates) {<br>
>    EXPECT_FALSE(T.isArch16Bit());<br>
>    EXPECT_FALSE(T.isArch32Bit());<br>
>    EXPECT_TRUE(T.isArch64Bit());<br>
> +<br>
> +  T.setArch(Triple::sparc);<br>
> +  EXPECT_FALSE(T.isArch16Bit());<br>
> +  EXPECT_TRUE(T.isArch32Bit());<br>
> +  EXPECT_FALSE(T.isArch64Bit());<br>
> +<br>
> +  T.setArch(Triple::sparcel);<br>
> +  EXPECT_FALSE(T.isArch16Bit());<br>
> +  EXPECT_TRUE(T.isArch32Bit());<br>
> +  EXPECT_FALSE(T.isArch64Bit());<br>
> +<br>
> +  T.setArch(Triple::sparcv9);<br>
> +  EXPECT_FALSE(T.isArch16Bit());<br>
> +  EXPECT_FALSE(T.isArch32Bit());<br>
> +  EXPECT_TRUE(T.isArch64Bit());<br>
>  }<br>
><br>
>  TEST(TripleTest, BitWidthArchVariants) {<br>
><br>
><br>
> _______________________________________________<br>
> llvm-commits mailing list<br>
> <a href="mailto:llvm-commits@cs.uiuc.edu" target="_blank">llvm-commits@cs.uiuc.edu</a><br>
> <a href="http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits" target="_blank">http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits</a><br>
_______________________________________________<br>
llvm-commits mailing list<br>
<a href="mailto:llvm-commits@cs.uiuc.edu" target="_blank">llvm-commits@cs.uiuc.edu</a><br>
<a href="http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits" target="_blank">http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits</a><br>
</blockquote></div></div>