<html><head><meta http-equiv="Content-Type" content="text/html charset=utf-8"></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space;" class="">Hi Rafael, David<div class=""><br class=""></div><div class="">In <a href="http://lists.cs.uiuc.edu/pipermail/llvm-commits/Week-of-Mon-20150420/273199.html" class="">http://lists.cs.uiuc.edu/pipermail/llvm-commits/Week-of-Mon-20150420/273199.html</a>, Rafael suggested returning a ValueMap from CloneFunction.</div><div class=""><br class=""></div><div class="">Turns out that ValueMap has a deleted copy constructor, and no move constructor all. This patch adds the move constructor (and assignment operator). The default implementations of both of these seem to be fine.</div><div class=""><br class=""></div><div class="">To test this, i managed to get the Constructible class from the SmallVector unit test to wrap a Value*, then use that to count all the times the ValueMap does any of the operators. I then went through the ValueMap and DenseMap code to verify each of the values i’m checking against. I left some printf’s in an #if 0 for future use in case we want to easily check the values coming out of this code.</div><div class=""><br class=""></div><div class="">Cheers,</div><div class="">Pete</div><div class=""><br class=""></div><div class=""></div></body></html>