<div dir="ltr"><br><div class="gmail_extra"><br><div class="gmail_quote">On Tue, Apr 21, 2015 at 1:00 PM, Daniel Berlin <span dir="ltr"><<a href="mailto:dberlin@dberlin.org" target="_blank">dberlin@dberlin.org</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Hi chandlerc,<br>
<br>
This lets us use range based for loops, and generally makes the interface much closer to<br>
normal pred iterators.<br>
<br>
<a href="http://reviews.llvm.org/D9169" target="_blank">http://reviews.llvm.org/D9169</a><br>
<br>
Files:<br>
  include/llvm/IR/PredIteratorCache.h<br>
<br>
Index: include/llvm/IR/PredIteratorCache.h<br>
===================================================================<br>
--- include/llvm/IR/PredIteratorCache.h<br>
+++ include/llvm/IR/PredIteratorCache.h<br>
@@ -14,6 +14,7 @@<br>
 #ifndef LLVM_IR_PREDITERATORCACHE_H<br>
 #define LLVM_IR_PREDITERATORCACHE_H<br>
<br>
+#include "llvm/ADT/ArrayRef.h"<br>
 #include "llvm/ADT/DenseMap.h"<br>
 #include "llvm/ADT/SmallVector.h"<br>
 #include "llvm/IR/CFG.h"<br>
@@ -32,6 +33,13 @@<br>
     /// Memory - This is the space that holds cached preds.<br>
     BumpPtrAllocator Memory;<br>
   public:<br>
+    ArrayRef<BasicBlock *>::iterator begin(BasicBlock *BB) { </blockquote><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
+      return makeArrayRef(GetPreds(BB), GetNumPreds(BB)).begin();<br>
+    }<br>
+<br>
+    ArrayRef<BasicBlock *>::iterator end(BasicBlock *BB) {<br>
+      return makeArrayRef(GetPreds(BB), GetNumPreds(BB)).end();<br>
+    }<br></blockquote><div><br>Looks like these could just be:<br><br>BasicBlock **begin(BasicBlock *BB) {<br>  return GetPreds(BB) + GetNumPreds(BB);<br>}<br> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<br>
     /// GetPreds - Get a cached list for the null-terminated predecessor list of<br>
     /// the specified block.  This can be used in a loop like this:<br>
@@ -65,6 +73,12 @@<br>
       Memory.Reset();<br>
     }<br>
   };<br>
+<br>
+  iterator_range<ArrayRef<BasicBlock *>::iterator><br>
+  cached_predecessors(PredIteratorCache &PC, BasicBlock *BB) {<br>
+    return make_range(PC.begin(BB), PC.end(BB));<br>
+  }<br></blockquote><div><br>And /this/ would be:<br><br>ArrayRef<BasicBlock*> cached_predecessors(...) {<br>  return makeArrayRef(GetPreds(BB), GetNumPreds(BB));</div><div>}<br><br>(though I guess GetPreds/GetNumPreds are private to the PredIteratorCache? So maybe just exposing the ArrayRef directly from PredIteratorCache and avoid ever exposing begin/end?)<br> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
+<br>
 } // end namespace llvm<br>
<br>
 #endif<br>
<br>
EMAIL PREFERENCES<br>
  <a href="http://reviews.llvm.org/settings/panel/emailpreferences/" target="_blank">http://reviews.llvm.org/settings/panel/emailpreferences/</a><br>
<br>_______________________________________________<br>
llvm-commits mailing list<br>
<a href="mailto:llvm-commits@cs.uiuc.edu">llvm-commits@cs.uiuc.edu</a><br>
<a href="http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits" target="_blank">http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits</a><br>
<br></blockquote></div><br></div></div>