<div dir="ltr">Actually it turns out I just misread the parentheses and what the cast applies to. Oops! Though I think getDefInit always makes a type object in the record. I'll revert until I figure it out.</div><div class="gmail_extra"><br><div class="gmail_quote">On Tue, Apr 21, 2015 at 7:40 PM, David Blaikie <span dir="ltr"><<a href="mailto:dblaikie@gmail.com" target="_blank">dblaikie@gmail.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">On Tue, Apr 21, 2015 at 7:09 PM, Craig Topper <<a href="mailto:craig.topper@gmail.com">craig.topper@gmail.com</a>> wrote:<br>
> Author: ctopper<br>
> Date: Tue Apr 21 21:09:42 2015<br>
> New Revision: 235463<br>
><br>
> URL: <a href="http://llvm.org/viewvc/llvm-project?rev=235463&view=rev" target="_blank">http://llvm.org/viewvc/llvm-project?rev=235463&view=rev</a><br>
> Log:<br>
> [TableGen] Use cast instead of dyn_cast where result isn't checked before being dereferenced.<br>
><br>
> Modified:<br>
>     llvm/trunk/lib/TableGen/Record.cpp<br>
><br>
> Modified: llvm/trunk/lib/TableGen/Record.cpp<br>
> URL: <a href="http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/TableGen/Record.cpp?rev=235463&r1=235462&r2=235463&view=diff" target="_blank">http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/TableGen/Record.cpp?rev=235463&r1=235462&r2=235463&view=diff</a><br>
> ==============================================================================<br>
> --- llvm/trunk/lib/TableGen/Record.cpp (original)<br>
> +++ llvm/trunk/lib/TableGen/Record.cpp Tue Apr 21 21:09:42 2015<br>
> @@ -345,7 +345,7 @@ Init *DagRecTy::convertValue(BinOpInit *<br>
>  }<br>
><br>
>  RecordRecTy *RecordRecTy::get(Record *R) {<br>
> -  return dyn_cast<RecordRecTy>(R->getDefInit()->getType());<br>
> +  return cast<RecordRecTy>(R->getDefInit()->getType());<br>
<br>
Is it? Callers could still check this for null? (perhaps you already<br>
checked that none of the callers check this for null/)<br>
<br>
>  }<br>
><br>
>  std::string RecordRecTy::getAsString() const {<br>
><br>
><br>
> _______________________________________________<br>
> llvm-commits mailing list<br>
> <a href="mailto:llvm-commits@cs.uiuc.edu">llvm-commits@cs.uiuc.edu</a><br>
> <a href="http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits" target="_blank">http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits</a><br>
</blockquote></div><br><br clear="all"><div><br></div>-- <br><div class="gmail_signature">~Craig</div>
</div>