<div dir="ltr">Hi Jonathan<div><div class="gmail_extra">Thanks for your comments, in the past week or so we have been cleaning up the bundle more based on some more comments, so we will have new patches for y'all to review. </div><div class="gmail_extra">However reply inline: <br><div class="gmail_quote"><br><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex">There seems to be a number of issues here. I'm trying these patches (<a href="http://reviews.llvm.org/D7637" target="_blank">http://reviews.llvm.org/D7637</a>, <a href="http://reviews.llvm.org/D7638" target="_blank">http://reviews.llvm.org/D7638</a>, <a href="http://reviews.llvm.org/D8752" target="_blank">http://reviews.llvm.org/D8752</a>, and <a href="http://reviews.llvm.org/D8751" target="_blank">http://reviews.llvm.org/D8751</a>) and here is what I have come up with:<br><br>1. This entire system doesn't seem to work if libiomp5 is a standalone product outside of an llvm project directory.<br></blockquote><div><br></div><div>This shouldn't have been the case since the testsuite does not require libiomp5 to be a standalone product. We have set environment variables in runtime/Makefile using </div><div><p> export LIBRARY_PATH=$(libiomp5_path):$(LIBRARY_PATH) ; \</p><p> export LD_LIBRARY_PATH=$(libiomp5_path):$(LD_LIBRARY_PATH) ; \</p><p> export DYLD_LIBRARY_PATH=$(libiomp5_path):$(DYLD_LIBRARY_PATH) ; \ <br></p></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex">2. Including the testsuite/Makefile in the top level Makefile seems wrong. It seems as though recursive Make should be called here. For instance if I try to run "make clean", it now gives me an error (bin/ directory doesn't exist in the runtime/ directory) which is unacceptable.<br></blockquote><div> </div><div>We (Alexey Bataev, Hal Finkel, Andrey Bokhanko ) tried several options to find out what's the best way to do this and we figured: <br></div><div><br></div><div>One would simply need to run a "make test" in runtime/ </div><div>This recursively calls "make ctest, llvm-lit .... " within /testsuite/ </div><div><br></div><div>So you wouldn't need to do "make" inside /testsuite/ </div><div>The user does not need to do anything within the /testsuite/ folder. </div><div>The "make test" within the /runtime takes care of the entire process. </div><div><br></div><div>For some reason, we did not get the error while doing a "make clean" at our end. However we have made a few modifications and removed more unwanted files, so the "make clean" should work OK now. I send to send newer patches to phabricator. </div><div> <br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex">3. I had to call Make inside the testsuite/ directory to have an LLVM-IR/ directory created inside the testsuite/ directory which isn't user friendly.<br></blockquote><div><br></div><div>Right, this is exactly what you don't have to do as I said in #2. Nothing needs to be done within /testsuite. </div><div>We will need to keep LLVM-IR directory since it has files that we need. </div><div> </div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex">Can someone explain the overall process of how this system is supposed to be called by the user and then document it in the testsuite/README?. The Phabricator review shows most of it being deleted.<br></blockquote><div><br></div><div>There is a README-LLVM-OpenMP that I have created for all the changes/additions/edits we have made so far for the testsuite to work. </div><div>I did not add this to phabricator, I didn't know if I should. I am using Phabricator for the first time, my apologies. </div><div>I am attaching the README with this mail and this will also be part of the testsuite repository once it is committed. <br></div><div><br></div><div>Hope these help and thanks once again for your feedback.</div><div>Sunita</div><div> </div></div></div></div></div><div class="gmail_extra"><br><div class="gmail_quote">On Tue, Apr 21, 2015 at 12:15 PM, Jonathan Peyton <span dir="ltr"><<a href="mailto:jonathan.l.peyton@intel.com" target="_blank">jonathan.l.peyton@intel.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">There seems to be a number of issues here. I'm trying these patches (<a href="http://reviews.llvm.org/D7637" target="_blank">http://reviews.llvm.org/D7637</a>, <a href="http://reviews.llvm.org/D7638" target="_blank">http://reviews.llvm.org/D7638</a>, <a href="http://reviews.llvm.org/D8752" target="_blank">http://reviews.llvm.org/D8752</a>, and <a href="http://reviews.llvm.org/D8751" target="_blank">http://reviews.llvm.org/D8751</a>) and here is what I have come up with:<br>
<br>
1. This entire system doesn't seem to work if libiomp5 is a standalone product outside of an llvm project directory.<br>
2. Including the testsuite/Makefile in the top level Makefile seems wrong. It seems as though recursive Make should be called here. For instance if I try to run "make clean", it now gives me an error (bin/ directory doesn't exist in the runtime/ directory) which is unacceptable.<br>
3. I had to call Make inside the testsuite/ directory to have an LLVM-IR/ directory created inside the testsuite/ directory which isn't user friendly.<br>
<br>
Can someone explain the overall process of how this system is supposed to be called by the user and then document it in the testsuite/README?. The Phabricator review shows most of it being deleted.<br>
<span class=""><br>
<br>
REPOSITORY<br>
rL LLVM<br>
<br>
<a href="http://reviews.llvm.org/D8752" target="_blank">http://reviews.llvm.org/D8752</a><br>
<br>
</span>EMAIL PREFERENCES<br>
<a href="http://reviews.llvm.org/settings/panel/emailpreferences/" target="_blank">http://reviews.llvm.org/settings/panel/emailpreferences/</a><br>
<br>
<br>
</blockquote></div><br></div>