<html><head><meta http-equiv="Content-Type" content="text/html charset=utf-8"></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space;" class="">Thanks James - r235133.<div class=""><br class=""></div><div class="">I took a look for isLIttleEndian() in fast-isel and there’s some checks on call arguments, but nothing for the return (until now). Not sure if we’re missing any other places or not, but nothing scary jumped out from the quick look.</div><div class=""><br class=""></div><div class="">Cheers,</div><div class="">Pete<br class=""><div><blockquote type="cite" class=""><div class="">On Apr 16, 2015, at 1:51 PM, James Molloy <<a href="mailto:james@jamesmolloy.co.uk" class="">james@jamesmolloy.co.uk</a>> wrote:</div><br class="Apple-interchange-newline"><div class=""><div dir="ltr" class="">Hi Pete,<br class=""><br class="">This looks fine to me. It's interesting though because I thought we did handle vector returns in fast-isel - emitting the bitcast conversion code. But it's a long time ago and my brain has become dusty.<div class=""><br class=""></div><div class="">Cheers,</div><div class=""><br class=""></div><div class="">James</div></div><br class=""><div class="gmail_quote">On Thu, 16 Apr 2015 at 21:19 Pete Cooper <<a href="mailto:peter_cooper@apple.com" class="">peter_cooper@apple.com</a>> wrote:<br class=""><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Hi James<br class="">
<br class="">
This patch makes AArch64 fast-isel bail out if it sees a call which returns a vector result.<br class="">
<br class="">
The existing test case for this was covering up the failures because some store instructions missed fast-isel and so the calls were never actually selected in fast-isel. I’ve inserted a branch in the BBs of all the tests to make the call be at the end of a BB and so always selected in fast-isel. If you run the test without my C++ code too you’ll get the failures I was seeing.<br class="">
<br class="">
I’ve left a ‘TODO’ in there because someone should probably get fast-isel to support this, but i thought it best to get correct code before aiming for more coverage.<br class="">
<br class="">
Cheers<br class="">
Pete<br class="">
<br class="">
</blockquote></div>
</div></blockquote></div><br class=""></div></body></html>