<div dir="ltr">My apologies. I didn't quite know what to do here as it's not actually the commit that's causing the failure, just that we didn't have any tests for this particular relocation previously. If we just want to make the bots green, can we xfail that test for MSVC only (also what happens if we xfail for all of windows, will the mingw bots complain because it actually passes)? Also, is there any way to run the bots on a proposed phabricator patch? That way we could have seen this issue before merging it. </div><div class="gmail_extra"><br><div class="gmail_quote">On Wed, Apr 15, 2015 at 9:59 AM, Aaron Ballman <span dir="ltr"><<a href="mailto:aaron@aaronballman.com" target="_blank">aaron@aaronballman.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">It would be good if we could revert this back to green while<br>
investigating, as we have bots that have been red for over 24 hours<br>
now:<br>
<br>
<a href="http://bb.pgr.jp/builders/msbuild-llvmclang-x64-msc18-DA/builds/152" target="_blank">http://bb.pgr.jp/builders/msbuild-llvmclang-x64-msc18-DA/builds/152</a><br>
<br>
~Aaron<br>
<br>
On Wed, Apr 15, 2015 at 5:40 AM, Keno Fischer<br>
<div class="HOEnZb"><div class="h5"><<a href="mailto:kfischer@college.harvard.edu">kfischer@college.harvard.edu</a>> wrote:<br>
> Hi Lang,<br>
><br>
> see also <a href="http://reviews.llvm.org/D9028" target="_blank">http://reviews.llvm.org/D9028</a>, which should address this issue<br>
> properly. I would suggest to implement a quick fix of not freeing the object<br>
> file early if possible (you probably have better insight into the memory<br>
> ownership issue here than I do). We can go back to the freeing the object<br>
> early once D9028 is sufficient tested and has been merged.<br>
><br>
> Keno<br>
><br>
> On Wed, Apr 15, 2015 at 2:34 AM, Keno Fischer <<a href="mailto:kfischer@college.harvard.edu">kfischer@college.harvard.edu</a>><br>
> wrote:<br>
>><br>
>> Hi Lang,<br>
>><br>
>> I have debugged this after getting MSVC setup in a virtual machine and it<br>
>> looks like the object file is getting freed before the relocations are<br>
>> applied. Unfortunately, on ELF, we still have the placeholder mechanism<br>
>> looking at the original object file, so I suspect this is a use-after-free<br>
>> even on other platforms, though we are getting lucky there. I suspect this<br>
>> was a problem even without my patch and it's just getting exposed here. How<br>
>> does the object file get freed? Is there some way to prevent this?<br>
>><br>
>> Keno<br>
>><br>
>> On Tue, Apr 14, 2015 at 1:16 PM, Lang Hames <<a href="mailto:lhames@gmail.com">lhames@gmail.com</a>> wrote:<br>
>>><br>
>>> Looks like SectionEntry was holding the section name as a StringRef.<br>
>>> That's not safe now that we can delete the ObjectFile after loading.<br>
>>><br>
>>> I've fixed this in r234910. Hopefully you can get more sane output from<br>
>>> the test-case now.<br>
>>><br>
>>> - Lang.<br>
>>><br>
>>> On Tue, Apr 14, 2015 at 8:12 AM, Keno Fischer<br>
>>> <<a href="mailto:kfischer@college.harvard.edu">kfischer@college.harvard.edu</a>> wrote:<br>
>>>><br>
>>>> This is missing the second .got section, I believe (hard to tell with<br>
>>>> the corrupted names of course). Did llvm-rtdyld get built correctly? Also CC<br>
>>>> Lang for why those would be corrupted.<br>
>>>><br>
>>>> On Tue, Apr 14, 2015 at 10:51 AM, Kuperstein, Michael M<br>
>>>> <<a href="mailto:michael.m.kuperstein@intel.com">michael.m.kuperstein@intel.com</a>> wrote:<br>
>>>>><br>
>>>>> Parse symbols:<br>
>>>>><br>
>>>>> emitSection SectionID: 0 Name: .text obj addr: 0000000000BA93C0 new<br>
>>>>> addr: 0000000000080000 DataSize: 10 StubBufSize: 6 Allocate: 16<br>
>>>>><br>
>>>>> Type: 4 Name: foo SID: 0 Offset: 0000000000000000 flags: 0<br>
>>>>><br>
>>>>> Parse relocations:<br>
>>>>><br>
>>>>> SectionID: 0<br>
>>>>><br>
>>>>> RelType: 9 Addend: -4 TargetName: G<br>
>>>>><br>
>>>>> SectionID: 0 Offset: 3<br>
>>>>><br>
>>>>> Parse symbols:<br>
>>>>><br>
>>>>> emitSection SectionID: 2 Name: .bss obj addr: 0000000000000000 new<br>
>>>>> addr: 0000000000AA0000 DataSize: 1 StubBufSize: 0 Allocate: 1<br>
>>>>><br>
>>>>> Type: 1 Name: F SID: 2 Offset: 0000000000000000 flags: 66<br>
>>>>><br>
>>>>> emitSection SectionID: 3 Name: .data.rel obj addr: 0000000000BA93D0 new<br>
>>>>> addr: 0000000000AB0000 DataSize: 8 StubBufSize: 6 Allocate: 14<br>
>>>>><br>
>>>>> Type: 1 Name: G SID: 3 Offset: 0000000000000000 flags: 66<br>
>>>>><br>
>>>>> Parse relocations:<br>
>>>>><br>
>>>>> SectionID: 3<br>
>>>>><br>
>>>>> RelType: 1 Addend: 0 TargetName: F<br>
>>>>><br>
>>>>> SectionID: 3 Offset: 0<br>
>>>>><br>
>>>>> Reassigning address for section 0 (▌▌▌▌▌): 0x0000000000080000 -><br>
>>>>> 0x0000000000001000<br>
>>>>><br>
>>>>> Reassigning address for section 1 (.got): 0x0000000000090000 -><br>
>>>>> 0x0000000000011000<br>
>>>>><br>
>>>>> Reassigning address for section 2 (▌▌▌▌): 0x0000000000aa0000 -><br>
>>>>> 0x0000000000021000<br>
>>>>><br>
>>>>> Reassigning address for section 3 (▌▌▌▌▌▌▌▌▌): 0x0000000000ab0000 -><br>
>>>>> 0x0000000000031000<br>
>>>>><br>
>>>>> Resolving relocations Name: G 0x31000<br>
>>>>><br>
>>>>> Writing 0000000000031000 at 0000000000090000<br>
>>>>><br>
>>>>> Resolving relocations Section #0 0000000000001000<br>
>>>>><br>
>>>>> ----- Contents of section ▌▌▌▌▌ before relocations -----<br>
>>>>><br>
>>>>> 0x0000000000001000: 48 8b 05 00 00 00 00 8b 00 c3<br>
>>>>><br>
>>>>> ----- Contents of section ▌▌▌▌▌ after relocations -----<br>
>>>>><br>
>>>>> 0x0000000000001000: 48 8b 05 00 00 00 00 8b 00 c3<br>
>>>>><br>
>>>>> Resolving relocations Section #1 0000000000011000<br>
>>>>><br>
>>>>> ----- Contents of section .got before relocations -----<br>
>>>>><br>
>>>>> 0x0000000000011000: 00 10 03 00 00 00 00 00<br>
>>>>><br>
>>>>> Assertion failed: RealOffset <= INT32_MAX && RealOffset >= INT32_MIN,<br>
>>>>> file ..\..\..\..\lib\ExecutionEngine\RuntimeDyld\RuntimeDyldELF.cpp, line<br>
>>>>> 259<br>
>>>>><br>
>>>>><br>
>>>>><br>
>>>>> (The section names are originally printed that way, it’s not the mail<br>
>>>>> client’s fault)<br>
>>>>><br>
>>>>><br>
>>>>><br>
>>>>> Michael<br>
>>>>><br>
>>>>><br>
>>>>><br>
>>>>> From: Keno Fischer [mailto:<a href="mailto:kfischer@college.harvard.edu">kfischer@college.harvard.edu</a>]<br>
>>>>> Sent: Tuesday, April 14, 2015 17:18<br>
>>>>> To: Kuperstein, Michael M<br>
>>>>> Cc: <a href="mailto:llvm-commits@cs.uiuc.edu">llvm-commits@cs.uiuc.edu</a><br>
>>>>> Subject: Re: [llvm] r234839 - [RuntimeDyldELF] Improve GOT support<br>
>>>>><br>
>>>>><br>
>>>>><br>
>>>>> Thanks Michael. I didn't realize that flag was being added on windows,<br>
>>>>> but I guess it makes sense, since you're using a non-standard triple for<br>
>>>>> MCJIT. I see this was reverted already.<br>
>>>>><br>
>>>>><br>
>>>>><br>
>>>>> Regarding the other failure, that's really odd, because this is<br>
>>>>> precisely the failure that this commit is supposed to solve. Can you send<br>
>>>>> the output of that invocation with `-debug-only dyld` added at the end?<br>
>>>>><br>
>>>>><br>
>>>>><br>
>>>>> On Tue, Apr 14, 2015 at 5:57 AM, Kuperstein, Michael M<br>
>>>>> <<a href="mailto:michael.m.kuperstein@intel.com">michael.m.kuperstein@intel.com</a>> wrote:<br>
>>>>><br>
>>>>> Hello Keno,<br>
>>>>><br>
>>>>> Unfortunately, cross-module-sm-pic-a.ll now breaks on windows.<br>
>>>>><br>
>>>>> It looks like %lli provides a triple, so this:<br>
>>>>> %lli -mtriple=x86_64-pc-linux -extra-module=%p/Inputs/cross-module-b.ll<br>
>>>>> -relocation-model=pic -code-model=small %s > /dev/null<br>
>>>>><br>
>>>>> Becomes:<br>
>>>>> lli.EXE -mtriple=x86_64-pc-win32-elf -mtriple=x86_64-pc-linux<br>
>>>>> -extra-module=...<br>
>>>>><br>
>>>>> Which (rightfully) gets rejected by lli.<br>
>>>>><br>
>>>>> Thanks,<br>
>>>>> Michael<br>
>>>>><br>
>>>>><br>
>>>>> -----Original Message-----<br>
>>>>> From: <a href="mailto:llvm-commits-bounces@cs.uiuc.edu">llvm-commits-bounces@cs.uiuc.edu</a><br>
>>>>> [mailto:<a href="mailto:llvm-commits-bounces@cs.uiuc.edu">llvm-commits-bounces@cs.uiuc.edu</a>] On Behalf Of Keno Fischer<br>
>>>>> Sent: Tuesday, April 14, 2015 05:11<br>
>>>>> To: <a href="mailto:llvm-commits@cs.uiuc.edu">llvm-commits@cs.uiuc.edu</a><br>
>>>>> Subject: [llvm] r234839 - [RuntimeDyldELF] Improve GOT support<br>
>>>>><br>
>>>>> Author: kfischer<br>
>>>>> Date: Mon Apr 13 21:10:35 2015<br>
>>>>> New Revision: 234839<br>
>>>>><br>
>>>>> URL: <a href="http://llvm.org/viewvc/llvm-project?rev=234839&view=rev" target="_blank">http://llvm.org/viewvc/llvm-project?rev=234839&view=rev</a><br>
>>>>> Log:<br>
>>>>> [RuntimeDyldELF] Improve GOT support<br>
>>>>><br>
>>>>> Summary:<br>
>>>>> This is the first in a series of patches to eventually add support for<br>
>>>>> TLS relocations to RuntimeDyld. This patch resolves an issue in the current<br>
>>>>> GOT handling, where GOT entries would be reused between object files, which<br>
>>>>> leads to the same situation that necessitates the GOT in the first place,<br>
>>>>> i.e. that the 32-bit offset can not cover all of the address space. Thus<br>
>>>>> this patch makes the GOT object-file-local.<br>
>>>>> Unfortunately, this still isn't quite enough, because the MemoryManager<br>
>>>>> does not yet guarantee that sections are allocated sufficiently close to<br>
>>>>> each other, even if they belong to the same object file. To address this<br>
>>>>> concern, this patch also adds a small API abstraction on top of the GOT<br>
>>>>> allocation mechanism that will allow (temporarily, until the MemoryManager<br>
>>>>> is improved) using the stub mechanism instead of allocating a different<br>
>>>>> section. The actual switch from separate section to stub mechanism will be<br>
>>>>> part of a follow-on commit, so that it can be easily reverted independently<br>
>>>>> at the appropriate time.<br>
>>>>><br>
>>>>> Test Plan: Includes a test case where the GOT of two object files is<br>
>>>>> artificially forced to be apart by several GB.<br>
>>>>><br>
>>>>> Reviewers: lhames<br>
>>>>><br>
>>>>> Reviewed By: lhames<br>
>>>>><br>
>>>>> Subscribers: llvm-commits<br>
>>>>><br>
>>>>> Differential Revision: <a href="http://reviews.llvm.org/D8813" target="_blank">http://reviews.llvm.org/D8813</a><br>
>>>>><br>
>>>>> Added:<br>
>>>>><br>
>>>>> llvm/trunk/test/ExecutionEngine/RuntimeDyld/X86/ELF_x64-64_PIC_relocations.s<br>
>>>>> llvm/trunk/test/ExecutionEngine/RuntimeDyld/X86/Inputs/<br>
>>>>><br>
>>>>> llvm/trunk/test/ExecutionEngine/RuntimeDyld/X86/Inputs/ExternalGlobal.ll<br>
>>>>> Modified:<br>
>>>>> llvm/trunk/lib/ExecutionEngine/RuntimeDyld/RuntimeDyld.cpp<br>
>>>>> llvm/trunk/lib/ExecutionEngine/RuntimeDyld/RuntimeDyldCheckerImpl.h<br>
>>>>> llvm/trunk/lib/ExecutionEngine/RuntimeDyld/RuntimeDyldELF.cpp<br>
>>>>> llvm/trunk/lib/ExecutionEngine/RuntimeDyld/RuntimeDyldELF.h<br>
>>>>> llvm/trunk/lib/ExecutionEngine/RuntimeDyld/RuntimeDyldImpl.h<br>
>>>>> llvm/trunk/test/ExecutionEngine/MCJIT/cross-module-sm-pic-a.ll<br>
>>>>><br>
>>>>> Modified: llvm/trunk/lib/ExecutionEngine/RuntimeDyld/RuntimeDyld.cpp<br>
>>>>> URL:<br>
>>>>> <a href="http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/ExecutionEngine/RuntimeDyld/RuntimeDyld.cpp?rev=234839&r1=234838&r2=234839&view=diff" target="_blank">http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/ExecutionEngine/RuntimeDyld/RuntimeDyld.cpp?rev=234839&r1=234838&r2=234839&view=diff</a><br>
>>>>><br>
>>>>> ==============================================================================<br>
>>>>> --- llvm/trunk/lib/ExecutionEngine/RuntimeDyld/RuntimeDyld.cpp<br>
>>>>> (original)<br>
>>>>> +++ llvm/trunk/lib/ExecutionEngine/RuntimeDyld/RuntimeDyld.cpp Mon Apr<br>
>>>>><br>
>>>>> +++ 13 21:10:35 2015<br>
>>>>> @@ -814,7 +814,6 @@ void RuntimeDyldImpl::resolveExternalSym<br>
>>>>> report_fatal_error("Program used external function '" + Name +<br>
>>>>> "' which could not be resolved!");<br>
>>>>><br>
>>>>> - updateGOTEntries(Name, Addr);<br>
>>>>> DEBUG(dbgs() << "Resolving relocations Name: " << Name << "\t"<br>
>>>>> << format("0x%lx", Addr) << "\n");<br>
>>>>> // This list may have been updated when we called<br>
>>>>> getSymbolAddress, so<br>
>>>>><br>
>>>>> Modified:<br>
>>>>> llvm/trunk/lib/ExecutionEngine/RuntimeDyld/RuntimeDyldCheckerImpl.h<br>
>>>>> URL:<br>
>>>>> <a href="http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/ExecutionEngine/RuntimeDyld/RuntimeDyldCheckerImpl.h?rev=234839&r1=234838&r2=234839&view=diff" target="_blank">http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/ExecutionEngine/RuntimeDyld/RuntimeDyldCheckerImpl.h?rev=234839&r1=234838&r2=234839&view=diff</a><br>
>>>>><br>
>>>>> ==============================================================================<br>
>>>>> --- llvm/trunk/lib/ExecutionEngine/RuntimeDyld/RuntimeDyldCheckerImpl.h<br>
>>>>> (original)<br>
>>>>> +++ llvm/trunk/lib/ExecutionEngine/RuntimeDyld/RuntimeDyldCheckerImpl.h<br>
>>>>> +++ Mon Apr 13 21:10:35 2015<br>
>>>>> @@ -19,6 +19,7 @@ class RuntimeDyldCheckerImpl {<br>
>>>>> friend class RuntimeDyldChecker;<br>
>>>>> friend class RuntimeDyldImpl;<br>
>>>>> friend class RuntimeDyldCheckerExprEval;<br>
>>>>> + friend class RuntimeDyldELF;<br>
>>>>><br>
>>>>> public:<br>
>>>>> RuntimeDyldCheckerImpl(RuntimeDyld &RTDyld, MCDisassembler<br>
>>>>> *Disassembler,<br>
>>>>><br>
>>>>> Modified: llvm/trunk/lib/ExecutionEngine/RuntimeDyld/RuntimeDyldELF.cpp<br>
>>>>> URL:<br>
>>>>> <a href="http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/ExecutionEngine/RuntimeDyld/RuntimeDyldELF.cpp?rev=234839&r1=234838&r2=234839&view=diff" target="_blank">http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/ExecutionEngine/RuntimeDyld/RuntimeDyldELF.cpp?rev=234839&r1=234838&r2=234839&view=diff</a><br>
>>>>><br>
>>>>> ==============================================================================<br>
>>>>> --- llvm/trunk/lib/ExecutionEngine/RuntimeDyld/RuntimeDyldELF.cpp<br>
>>>>> (original)<br>
>>>>> +++ llvm/trunk/lib/ExecutionEngine/RuntimeDyld/RuntimeDyldELF.cpp Mon<br>
>>>>> +++ Apr 13 21:10:35 2015<br>
>>>>><br>
>>>>> @@ -12,6 +12,7 @@<br>
>>>>><br>
>>>>> //===----------------------------------------------------------------------===//<br>
>>>>><br>
>>>>> #include "RuntimeDyldELF.h"<br>
>>>>> +#include "RuntimeDyldCheckerImpl.h"<br>
>>>>> #include "llvm/ADT/IntervalMap.h"<br>
>>>>> #include "llvm/ADT/STLExtras.h"<br>
>>>>> #include "llvm/ADT/StringRef.h"<br>
>>>>> @@ -185,7 +186,7 @@ namespace llvm {<br>
>>>>><br>
>>>>> RuntimeDyldELF::RuntimeDyldELF(RuntimeDyld::MemoryManager &MemMgr,<br>
>>>>> RuntimeDyld::SymbolResolver &Resolver)<br>
>>>>> - : RuntimeDyldImpl(MemMgr, Resolver) {}<br>
>>>>> + : RuntimeDyldImpl(MemMgr, Resolver), GOTSectionID(0),<br>
>>>>> + CurrentGOTIndex(0) {}<br>
>>>>> RuntimeDyldELF::~RuntimeDyldELF() {}<br>
>>>>><br>
>>>>> void RuntimeDyldELF::registerEHFrames() { @@ -245,27 +246,16 @@ void<br>
>>>>> RuntimeDyldELF::resolveX86_64Reloca<br>
>>>>> << format("%p\n", Section.Address + Offset));<br>
>>>>> break;<br>
>>>>> }<br>
>>>>> - case ELF::R_X86_64_GOTPCREL: {<br>
>>>>> - // findGOTEntry returns the 'G + GOT' part of the relocation<br>
>>>>> calculation<br>
>>>>> - // based on the load/target address of the GOT (not the<br>
>>>>> current/local addr).<br>
>>>>> - uint64_t GOTAddr = findGOTEntry(Value, SymOffset);<br>
>>>>> - uint64_t FinalAddress = Section.LoadAddress + Offset;<br>
>>>>> - // The processRelocationRef method combines the symbol offset and<br>
>>>>> the addend<br>
>>>>> - // and in most cases that's what we want. For this relocation<br>
>>>>> type, we need<br>
>>>>> - // the raw addend, so we subtract the symbol offset to get it.<br>
>>>>> - int64_t RealOffset = GOTAddr + Addend - SymOffset - FinalAddress;<br>
>>>>> - assert(RealOffset <= INT32_MAX && RealOffset >= INT32_MIN);<br>
>>>>> - int32_t TruncOffset = (RealOffset & 0xFFFFFFFF);<br>
>>>>> - support::ulittle32_t::ref(Section.Address + Offset) = TruncOffset;<br>
>>>>> - break;<br>
>>>>> - }<br>
>>>>> case ELF::R_X86_64_PC32: {<br>
>>>>> // Get the placeholder value from the generated object since<br>
>>>>> // a previous relocation attempt may have overwritten the loaded<br>
>>>>> version<br>
>>>>> support::ulittle32_t::ref Placeholder(<br>
>>>>> (void *)(Section.ObjAddress + Offset));<br>
>>>>> uint64_t FinalAddress = Section.LoadAddress + Offset;<br>
>>>>> - int64_t RealOffset = Placeholder + Value + Addend - FinalAddress;<br>
>>>>> + int64_t RealOffset = Value + Addend - FinalAddress;<br>
>>>>> + // Don't add the placeholder if this is a stub<br>
>>>>> + if (Offset < Section.Size)<br>
>>>>> + RealOffset += Placeholder;<br>
>>>>> assert(RealOffset <= INT32_MAX && RealOffset >= INT32_MIN);<br>
>>>>> int32_t TruncOffset = (RealOffset & 0xFFFFFFFF);<br>
>>>>> support::ulittle32_t::ref(Section.Address + Offset) = TruncOffset;<br>
>>>>> @@ -277,8 +267,10 @@ void RuntimeDyldELF::resolveX86_64Reloca<br>
>>>>> support::ulittle64_t::ref Placeholder(<br>
>>>>> (void *)(Section.ObjAddress + Offset));<br>
>>>>> uint64_t FinalAddress = Section.LoadAddress + Offset;<br>
>>>>> - support::ulittle64_t::ref(Section.Address + Offset) =<br>
>>>>> - Placeholder + Value + Addend - FinalAddress;<br>
>>>>> + int64_t RealOffset = Value + Addend - FinalAddress;<br>
>>>>> + if (Offset < Section.Size)<br>
>>>>> + RealOffset += Placeholder;<br>
>>>>> + support::ulittle64_t::ref(Section.Address + Offset) = RealOffset;<br>
>>>>> break;<br>
>>>>> }<br>
>>>>> }<br>
>>>>> @@ -1323,16 +1315,18 @@ relocation_iterator RuntimeDyldELF::proc<br>
>>>>> Stubs[Value] = StubOffset;<br>
>>>>> createStubFunction((uint8_t *)StubAddress);<br>
>>>>><br>
>>>>> - // Create a GOT entry for the external function.<br>
>>>>> - GOTEntries.push_back(Value);<br>
>>>>> -<br>
>>>>> - // Make our stub function a relative call to the GOT entry.<br>
>>>>> - RelocationEntry RE(SectionID, StubOffset + 2,<br>
>>>>> ELF::R_X86_64_GOTPCREL,<br>
>>>>> - -4);<br>
>>>>> - addRelocationForSymbol(RE, Value.SymbolName);<br>
>>>>> -<br>
>>>>> // Bump our stub offset counter<br>
>>>>> Section.StubOffset = StubOffset + getMaxStubSize();<br>
>>>>> +<br>
>>>>> + // Allocate a GOT Entry<br>
>>>>> + uint64_t GOTOffset = allocateGOTEntries(SectionID, 1);<br>
>>>>> +<br>
>>>>> + // The load of the GOT address has an addend of -4<br>
>>>>> + resolveGOTOffsetRelocation(SectionID, StubOffset + 2,<br>
>>>>> GOTOffset<br>
>>>>> + - 4);<br>
>>>>> +<br>
>>>>> + // Fill in the value of the symbol we're targeting into the<br>
>>>>> GOT<br>
>>>>> +<br>
>>>>> addRelocationForSymbol(computeGOTOffsetRE(SectionID,GOTOffset,0,ELF::R_X86_64_64),<br>
>>>>> + Value.SymbolName);<br>
>>>>> }<br>
>>>>><br>
>>>>> // Make the target call a call into the stub table.<br>
>>>>> @@ -1343,10 +1337,17 @@ relocation_iterator RuntimeDyldELF::proc<br>
>>>>> Value.Offset);<br>
>>>>> addRelocationForSection(RE, Value.SectionID);<br>
>>>>> }<br>
>>>>> + } else if (Arch == Triple::x86_64 && RelType ==<br>
>>>>> ELF::R_X86_64_GOTPCREL) {<br>
>>>>> + uint64_t GOTOffset = allocateGOTEntries(SectionID, 1);<br>
>>>>> + resolveGOTOffsetRelocation(SectionID, Offset, GOTOffset + Addend);<br>
>>>>> +<br>
>>>>> + // Fill in the value of the symbol we're targeting into the GOT<br>
>>>>> + RelocationEntry RE = computeGOTOffsetRE(SectionID, GOTOffset,<br>
>>>>> Value.Offset, ELF::R_X86_64_64);<br>
>>>>> + if (Value.SymbolName)<br>
>>>>> + addRelocationForSymbol(RE, Value.SymbolName);<br>
>>>>> + else<br>
>>>>> + addRelocationForSection(RE, Value.SectionID);<br>
>>>>> } else {<br>
>>>>> - if (Arch == Triple::x86_64 && RelType == ELF::R_X86_64_GOTPCREL) {<br>
>>>>> - GOTEntries.push_back(Value);<br>
>>>>> - }<br>
>>>>> RelocationEntry RE(SectionID, Offset, RelType, Value.Addend,<br>
>>>>> Value.Offset);<br>
>>>>> if (Value.SymbolName)<br>
>>>>> addRelocationForSymbol(RE, Value.SymbolName); @@ -1356,22<br>
>>>>> +1357,6 @@ relocation_iterator RuntimeDyldELF::proc<br>
>>>>> return ++RelI;<br>
>>>>> }<br>
>>>>><br>
>>>>> -void RuntimeDyldELF::updateGOTEntries(StringRef Name, uint64_t Addr) {<br>
>>>>> -<br>
>>>>> - SmallVectorImpl<std::pair<SID, GOTRelocations>>::iterator it;<br>
>>>>> - SmallVectorImpl<std::pair<SID, GOTRelocations>>::iterator end =<br>
>>>>> GOTs.end();<br>
>>>>> -<br>
>>>>> - for (it = GOTs.begin(); it != end; ++it) {<br>
>>>>> - GOTRelocations &GOTEntries = it->second;<br>
>>>>> - for (int i = 0, e = GOTEntries.size(); i != e; ++i) {<br>
>>>>> - if (GOTEntries[i].SymbolName != nullptr &&<br>
>>>>> - GOTEntries[i].SymbolName == Name) {<br>
>>>>> - GOTEntries[i].Offset = Addr;<br>
>>>>> - }<br>
>>>>> - }<br>
>>>>> - }<br>
>>>>> -}<br>
>>>>> -<br>
>>>>> size_t RuntimeDyldELF::getGOTEntrySize() {<br>
>>>>> // We don't use the GOT in all of these cases, but it's essentially<br>
>>>>> free<br>
>>>>> // to put them all here.<br>
>>>>> @@ -1398,75 +1383,50 @@ size_t RuntimeDyldELF::getGOTEntrySize()<br>
>>>>> return Result;<br>
>>>>> }<br>
>>>>><br>
>>>>> -uint64_t RuntimeDyldELF::findGOTEntry(uint64_t LoadAddress, uint64_t<br>
>>>>> Offset) {<br>
>>>>> -<br>
>>>>> - const size_t GOTEntrySize = getGOTEntrySize();<br>
>>>>> -<br>
>>>>> - SmallVectorImpl<std::pair<SID, GOTRelocations>>::const_iterator it;<br>
>>>>> - SmallVectorImpl<std::pair<SID, GOTRelocations>>::const_iterator end<br>
>>>>> =<br>
>>>>> - GOTs.end();<br>
>>>>> -<br>
>>>>> - int GOTIndex = -1;<br>
>>>>> - for (it = GOTs.begin(); it != end; ++it) {<br>
>>>>> - SID GOTSectionID = it->first;<br>
>>>>> - const GOTRelocations &GOTEntries = it->second;<br>
>>>>> -<br>
>>>>> - // Find the matching entry in our vector.<br>
>>>>> - uint64_t SymbolOffset = 0;<br>
>>>>> - for (int i = 0, e = GOTEntries.size(); i != e; ++i) {<br>
>>>>> - if (!GOTEntries[i].SymbolName) {<br>
>>>>> - if (getSectionLoadAddress(GOTEntries[i].SectionID) ==<br>
>>>>> LoadAddress &&<br>
>>>>> - GOTEntries[i].Offset == Offset) {<br>
>>>>> - GOTIndex = i;<br>
>>>>> - SymbolOffset = GOTEntries[i].Offset;<br>
>>>>> - break;<br>
>>>>> - }<br>
>>>>> - } else {<br>
>>>>> - // GOT entries for external symbols use the addend as the<br>
>>>>> address when<br>
>>>>> - // the external symbol has been resolved.<br>
>>>>> - if (GOTEntries[i].Offset == LoadAddress) {<br>
>>>>> - GOTIndex = i;<br>
>>>>> - // Don't use the Addend here. The relocation handler will<br>
>>>>> use it.<br>
>>>>> - break;<br>
>>>>> - }<br>
>>>>> - }<br>
>>>>> - }<br>
>>>>> -<br>
>>>>> - if (GOTIndex != -1) {<br>
>>>>> - if (GOTEntrySize == sizeof(uint64_t)) {<br>
>>>>> - uint64_t *LocalGOTAddr = (uint64_t<br>
>>>>> *)getSectionAddress(GOTSectionID);<br>
>>>>> - // Fill in this entry with the address of the symbol being<br>
>>>>> referenced.<br>
>>>>> - LocalGOTAddr[GOTIndex] = LoadAddress + SymbolOffset;<br>
>>>>> - } else {<br>
>>>>> - uint32_t *LocalGOTAddr = (uint32_t<br>
>>>>> *)getSectionAddress(GOTSectionID);<br>
>>>>> - // Fill in this entry with the address of the symbol being<br>
>>>>> referenced.<br>
>>>>> - LocalGOTAddr[GOTIndex] = (uint32_t)(LoadAddress +<br>
>>>>> SymbolOffset);<br>
>>>>> - }<br>
>>>>> -<br>
>>>>> - // Calculate the load address of this entry<br>
>>>>> - return getSectionLoadAddress(GOTSectionID) + (GOTIndex *<br>
>>>>> GOTEntrySize);<br>
>>>>> - }<br>
>>>>> - }<br>
>>>>> -<br>
>>>>> - assert(GOTIndex != -1 && "Unable to find requested GOT entry.");<br>
>>>>> - return 0;<br>
>>>>> +uint64_t RuntimeDyldELF::allocateGOTEntries(unsigned SectionID,<br>
>>>>><br>
>>>>> +unsigned no) {<br>
>>>>> + (void)SectionID; // The GOT Section is the same for all section in<br>
>>>>> +the object file<br>
>>>>> + if (GOTSectionID == 0) {<br>
>>>>> + GOTSectionID = Sections.size();<br>
>>>>> + // Reserve a section id. We'll allocate the section later<br>
>>>>> + // once we know the total size<br>
>>>>> + Sections.push_back(SectionEntry(".got", 0, 0, 0));<br>
>>>>> + }<br>
>>>>> + uint64_t StartOffset = CurrentGOTIndex * getGOTEntrySize();<br>
>>>>> + CurrentGOTIndex += no;<br>
>>>>> + return StartOffset;<br>
>>>>> +}<br>
>>>>> +<br>
>>>>> +void RuntimeDyldELF::resolveGOTOffsetRelocation(unsigned SectionID,<br>
>>>>> +uint64_t Offset, uint64_t GOTOffset) {<br>
>>>>> + // Fill in the relative address of the GOT Entry into the stub<br>
>>>>> + RelocationEntry GOTRE(SectionID, Offset, ELF::R_X86_64_PC32,<br>
>>>>> +GOTOffset);<br>
>>>>> + addRelocationForSection(GOTRE, GOTSectionID); }<br>
>>>>> +<br>
>>>>> +RelocationEntry RuntimeDyldELF::computeGOTOffsetRE(unsigned SectionID,<br>
>>>>> uint64_t GOTOffset, uint64_t SymbolOffset,<br>
>>>>> + uint32_t Type) {<br>
>>>>> + (void)SectionID; // The GOT Section is the same for all section in<br>
>>>>> +the object file<br>
>>>>><br>
>>>>> + return RelocationEntry(GOTSectionID, GOTOffset, Type, SymbolOffset);<br>
>>>>> }<br>
>>>>><br>
>>>>> void RuntimeDyldELF::finalizeLoad(const ObjectFile &Obj,<br>
>>>>> ObjSectionToIDMap &SectionMap) {<br>
>>>>> // If necessary, allocate the global offset table<br>
>>>>> - size_t numGOTEntries = GOTEntries.size();<br>
>>>>> - if (numGOTEntries != 0) {<br>
>>>>> + if (GOTSectionID != 0) {<br>
>>>>> // Allocate memory for the section<br>
>>>>> - unsigned SectionID = Sections.size();<br>
>>>>> - size_t TotalSize = numGOTEntries * getGOTEntrySize();<br>
>>>>> + size_t TotalSize = CurrentGOTIndex * getGOTEntrySize();<br>
>>>>> uint8_t *Addr = MemMgr.allocateDataSection(TotalSize,<br>
>>>>> getGOTEntrySize(),<br>
>>>>> - SectionID, ".got",<br>
>>>>> false);<br>
>>>>> + GOTSectionID, ".got",<br>
>>>>> + false);<br>
>>>>> if (!Addr)<br>
>>>>> report_fatal_error("Unable to allocate memory for GOT!");<br>
>>>>><br>
>>>>> - GOTs.push_back(std::make_pair(SectionID, GOTEntries));<br>
>>>>> - Sections.push_back(SectionEntry(".got", Addr, TotalSize, 0));<br>
>>>>> + Sections[GOTSectionID] = SectionEntry(".got", Addr, TotalSize, 0);<br>
>>>>> +<br>
>>>>> + if (Checker)<br>
>>>>> + Checker->registerSection(Obj.getFileName(), GOTSectionID);<br>
>>>>> +<br>
>>>>> // For now, initialize all GOT entries to zero. We'll fill them<br>
>>>>> in as<br>
>>>>> // needed when GOT-based relocations are applied.<br>
>>>>> memset(Addr, 0, TotalSize);<br>
>>>>> @@ -1483,6 +1443,9 @@ void RuntimeDyldELF::finalizeLoad(const<br>
>>>>> break;<br>
>>>>> }<br>
>>>>> }<br>
>>>>> +<br>
>>>>> + GOTSectionID = 0;<br>
>>>>> + CurrentGOTIndex = 0;<br>
>>>>> }<br>
>>>>><br>
>>>>> bool RuntimeDyldELF::isCompatibleFile(const object::ObjectFile &Obj)<br>
>>>>> const {<br>
>>>>><br>
>>>>> Modified: llvm/trunk/lib/ExecutionEngine/RuntimeDyld/RuntimeDyldELF.h<br>
>>>>> URL:<br>
>>>>> <a href="http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/ExecutionEngine/RuntimeDyld/RuntimeDyldELF.h?rev=234839&r1=234838&r2=234839&view=diff" target="_blank">http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/ExecutionEngine/RuntimeDyld/RuntimeDyldELF.h?rev=234839&r1=234838&r2=234839&view=diff</a><br>
>>>>><br>
>>>>> ==============================================================================<br>
>>>>> --- llvm/trunk/lib/ExecutionEngine/RuntimeDyld/RuntimeDyldELF.h<br>
>>>>> (original)<br>
>>>>> +++ llvm/trunk/lib/ExecutionEngine/RuntimeDyld/RuntimeDyldELF.h Mon Apr<br>
>>>>><br>
>>>>> +++ 13 21:10:35 2015<br>
>>>>> @@ -80,16 +80,32 @@ class RuntimeDyldELF : public RuntimeDyl<br>
>>>>> ObjSectionToIDMap &LocalSections,<br>
>>>>> RelocationValueRef &Rel);<br>
>>>>><br>
>>>>> - uint64_t findGOTEntry(uint64_t LoadAddr, uint64_t Offset);<br>
>>>>> size_t getGOTEntrySize();<br>
>>>>><br>
>>>>> - void updateGOTEntries(StringRef Name, uint64_t Addr) override;<br>
>>>>> + SectionEntry &getSection(unsigned SectionID) { return<br>
>>>>> + Sections[SectionID]; }<br>
>>>>><br>
>>>>> - // Relocation entries for symbols whose position-independent offset<br>
>>>>> is<br>
>>>>> - // updated in a global offset table.<br>
>>>>> - typedef SmallVector<RelocationValueRef, 2> GOTRelocations;<br>
>>>>> - GOTRelocations GOTEntries; // List of entries requiring<br>
>>>>> finalization.<br>
>>>>> - SmallVector<std::pair<SID, GOTRelocations>, 8> GOTs; // Allocated<br>
>>>>> tables.<br>
>>>>> + // Allocate no GOT entries for use in the given section.<br>
>>>>> + uint64_t allocateGOTEntries(unsigned SectionID, unsigned no);<br>
>>>>> +<br>
>>>>> + // Resolve the relvative address of GOTOffset in Section ID and<br>
>>>>> place<br>
>>>>> + // it at the given Offset void resolveGOTOffsetRelocation(unsigned<br>
>>>>> + SectionID, uint64_t Offset,<br>
>>>>> + uint64_t GOTOffset);<br>
>>>>> +<br>
>>>>> + // For a GOT entry referenced from SectionID, compute a relocation<br>
>>>>> + entry // that will place the final resolved value in the GOT slot<br>
>>>>> + RelocationEntry computeGOTOffsetRE(unsigned SectionID,<br>
>>>>> + uint64_t GOTOffset,<br>
>>>>> + uint64_t SymbolOffset,<br>
>>>>> + unsigned Type);<br>
>>>>> +<br>
>>>>> + // The tentative ID for the GOT section unsigned GOTSectionID;<br>
>>>>> +<br>
>>>>> + // Records the current number of allocated slots in the GOT //<br>
>>>>> (This<br>
>>>>> + would be equivalent to GOTEntries.size() were it not for relocations<br>
>>>>> + // that consume more than one slot) unsigned CurrentGOTIndex;<br>
>>>>><br>
>>>>> // When a module is loaded we save the SectionID of the EH frame<br>
>>>>> section<br>
>>>>> // in a table until we receive a request to register all<br>
>>>>> unregistered<br>
>>>>><br>
>>>>> Modified: llvm/trunk/lib/ExecutionEngine/RuntimeDyld/RuntimeDyldImpl.h<br>
>>>>> URL:<br>
>>>>> <a href="http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/ExecutionEngine/RuntimeDyld/RuntimeDyldImpl.h?rev=234839&r1=234838&r2=234839&view=diff" target="_blank">http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/ExecutionEngine/RuntimeDyld/RuntimeDyldImpl.h?rev=234839&r1=234838&r2=234839&view=diff</a><br>
>>>>><br>
>>>>> ==============================================================================<br>
>>>>> --- llvm/trunk/lib/ExecutionEngine/RuntimeDyld/RuntimeDyldImpl.h<br>
>>>>> (original)<br>
>>>>> +++ llvm/trunk/lib/ExecutionEngine/RuntimeDyld/RuntimeDyldImpl.h Mon<br>
>>>>> Apr<br>
>>>>> +++ 13 21:10:35 2015<br>
>>>>> @@ -361,10 +361,6 @@ protected:<br>
>>>>> /// \brief Resolve relocations to external symbols.<br>
>>>>> void resolveExternalSymbols();<br>
>>>>><br>
>>>>> - /// \brief Update GOT entries for external symbols.<br>
>>>>> - // The base class does nothing. ELF overrides this.<br>
>>>>> - virtual void updateGOTEntries(StringRef Name, uint64_t Addr) {}<br>
>>>>> -<br>
>>>>> // \brief Compute an upper bound of the memory that is required to<br>
>>>>> load all<br>
>>>>> // sections<br>
>>>>> void computeTotalAllocSize(const ObjectFile &Obj, uint64_t<br>
>>>>> &CodeSize,<br>
>>>>><br>
>>>>> Modified:<br>
>>>>> llvm/trunk/test/ExecutionEngine/MCJIT/cross-module-sm-pic-a.ll<br>
>>>>> URL:<br>
>>>>> <a href="http://llvm.org/viewvc/llvm-project/llvm/trunk/test/ExecutionEngine/MCJIT/cross-module-sm-pic-a.ll?rev=234839&r1=234838&r2=234839&view=diff" target="_blank">http://llvm.org/viewvc/llvm-project/llvm/trunk/test/ExecutionEngine/MCJIT/cross-module-sm-pic-a.ll?rev=234839&r1=234838&r2=234839&view=diff</a><br>
>>>>><br>
>>>>> ==============================================================================<br>
>>>>> --- llvm/trunk/test/ExecutionEngine/MCJIT/cross-module-sm-pic-a.ll<br>
>>>>> (original)<br>
>>>>> +++ llvm/trunk/test/ExecutionEngine/MCJIT/cross-module-sm-pic-a.ll Mon<br>
>>>>> +++ Apr 13 21:10:35 2015<br>
>>>>> @@ -1,4 +1,5 @@<br>
>>>>> ; RUN: %lli -extra-module=%p/Inputs/cross-module-b.ll<br>
>>>>> -relocation-model=pic -code-model=small %s > /dev/null<br>
>>>>> +; RUN: %lli -mtriple=x86_64-pc-linux<br>
>>>>> +-extra-module=%p/Inputs/cross-module-b.ll -relocation-model=pic<br>
>>>>> +-code-model=small %s > /dev/null<br>
>>>>> ; XFAIL: mips, i686, i386<br>
>>>>><br>
>>>>> declare i32 @FB()<br>
>>>>><br>
>>>>> Added:<br>
>>>>> llvm/trunk/test/ExecutionEngine/RuntimeDyld/X86/ELF_x64-64_PIC_relocations.s<br>
>>>>> URL:<br>
>>>>> <a href="http://llvm.org/viewvc/llvm-project/llvm/trunk/test/ExecutionEngine/RuntimeDyld/X86/ELF_x64-64_PIC_relocations.s?rev=234839&view=auto" target="_blank">http://llvm.org/viewvc/llvm-project/llvm/trunk/test/ExecutionEngine/RuntimeDyld/X86/ELF_x64-64_PIC_relocations.s?rev=234839&view=auto</a><br>
>>>>><br>
>>>>> ==============================================================================<br>
>>>>> ---<br>
>>>>> llvm/trunk/test/ExecutionEngine/RuntimeDyld/X86/ELF_x64-64_PIC_relocations.s<br>
>>>>> (added)<br>
>>>>> +++<br>
>>>>> llvm/trunk/test/ExecutionEngine/RuntimeDyld/X86/ELF_x64-64_PIC_reloc<br>
>>>>> +++ ations.s Mon Apr 13 21:10:35 2015<br>
>>>>> @@ -0,0 +1,31 @@<br>
>>>>> +# RUN: llvm-mc -triple=x86_64-pc-linux -relocation-model=pic<br>
>>>>> +-filetype=obj -o %T/test_ELF1_x86-64.o %s # RUN: llvm-mc<br>
>>>>> +-triple=x86_64-pc-linux -relocation-model=pic -filetype=obj -o<br>
>>>>> +%T/test_ELF2_x86-64.o %s # RUN: llc -mtriple=x86_64-pc-linux<br>
>>>>> +-relocation-model=pic -filetype=obj -o<br>
>>>>> +%T/test_ELF_ExternalGlobal_x86-64.o %S/Inputs/ExternalGlobal.ll # RUN:<br>
>>>>> +llvm-rtdyld -triple=x86_64-pc-linux -verify %T/test_ELF1_x86-64.o<br>
>>>>> +%T/test_ELF_ExternalGlobal_x86-64.o<br>
>>>>> +# Test that we can load this code twice at memory locations more than<br>
>>>>> +2GB apart # RUN: llvm-rtdyld -triple=x86_64-pc-linux -verify<br>
>>>>> +-map-section test_ELF1_x86-64.o,.got=0x10000 -map-section<br>
>>>>> +test_ELF2_x86-64.o,.text=0x100000000 -map-section<br>
>>>>> +test_ELF2_x86-64.o,.got=0x100010000 %T/test_ELF1_x86-64.o<br>
>>>>> +%T/test_ELF2_x86-64.o %T/test_ELF_ExternalGlobal_x86-64.o<br>
>>>>><br>
>>>>> +<br>
>>>>> +# Assembly obtained by compiling the following and adding checks:<br>
>>>>> +# @G = external global i8*<br>
>>>>> +#<br>
>>>>> +# define i8* @foo() {<br>
>>>>> +# %ret = load i8** @G<br>
>>>>> +# ret i32 %ret<br>
>>>>> +# }<br>
>>>>> +#<br>
>>>>> +<br>
>>>>> +#<br>
>>>>> + .text<br>
>>>>> + .file "ELF_x64-64_PIC_relocations.ll"<br>
>>>>> + .align 16, 0x90<br>
>>>>> + .type foo,@function<br>
>>>>> +foo: # @foo<br>
>>>>> +# BB#0:<br>
>>>>> + movq G@GOTPCREL(%rip), %rax<br>
>>>>> + movl (%rax), %eax<br>
>>>>> + retq<br>
>>>>> +.Ltmp0:<br>
>>>>> + .size foo, .Ltmp0-foo<br>
>>>>> +<br>
>>>>> +<br>
>>>>> + .section ".note.GNU-stack","",@progbits<br>
>>>>><br>
>>>>> Added:<br>
>>>>> llvm/trunk/test/ExecutionEngine/RuntimeDyld/X86/Inputs/ExternalGlobal.ll<br>
>>>>> URL:<br>
>>>>> <a href="http://llvm.org/viewvc/llvm-project/llvm/trunk/test/ExecutionEngine/RuntimeDyld/X86/Inputs/ExternalGlobal.ll?rev=234839&view=auto" target="_blank">http://llvm.org/viewvc/llvm-project/llvm/trunk/test/ExecutionEngine/RuntimeDyld/X86/Inputs/ExternalGlobal.ll?rev=234839&view=auto</a><br>
>>>>><br>
>>>>> ==============================================================================<br>
>>>>> ---<br>
>>>>> llvm/trunk/test/ExecutionEngine/RuntimeDyld/X86/Inputs/ExternalGlobal.ll<br>
>>>>> (added)<br>
>>>>> +++<br>
>>>>> llvm/trunk/test/ExecutionEngine/RuntimeDyld/X86/Inputs/ExternalGloba<br>
>>>>><br>
>>>>> +++ l.ll Mon Apr 13 21:10:35 2015<br>
>>>>> @@ -0,0 +1,2 @@<br>
>>>>> +@F = global i8 0<br>
>>>>> +@G = global i8* @F<br>
>>>>><br>
>>>>><br>
>>>>> _______________________________________________<br>
>>>>> llvm-commits mailing list<br>
>>>>> <a href="mailto:llvm-commits@cs.uiuc.edu">llvm-commits@cs.uiuc.edu</a><br>
>>>>> <a href="http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits" target="_blank">http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits</a><br>
>>>>> ---------------------------------------------------------------------<br>
>>>>> Intel Israel (74) Limited<br>
>>>>><br>
>>>>> This e-mail and any attachments may contain confidential material for<br>
>>>>> the sole use of the intended recipient(s). Any review or distribution<br>
>>>>> by others is strictly prohibited. If you are not the intended<br>
>>>>> recipient, please contact the sender and delete all copies.<br>
>>>>><br>
>>>>><br>
>>>>><br>
>>>>> ---------------------------------------------------------------------<br>
>>>>> Intel Israel (74) Limited<br>
>>>>><br>
>>>>> This e-mail and any attachments may contain confidential material for<br>
>>>>> the sole use of the intended recipient(s). Any review or distribution<br>
>>>>> by others is strictly prohibited. If you are not the intended<br>
>>>>> recipient, please contact the sender and delete all copies.<br>
>>>><br>
>>>><br>
>>><br>
>><br>
><br>
><br>
> _______________________________________________<br>
> llvm-commits mailing list<br>
> <a href="mailto:llvm-commits@cs.uiuc.edu">llvm-commits@cs.uiuc.edu</a><br>
> <a href="http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits" target="_blank">http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits</a><br>
><br>
</div></div></blockquote></div><br></div>