<div dir="ltr">I can fix it with the attached patch. What do you think?<br><br><div class="gmail_quote">On Mon, Apr 13, 2015 at 11:22 AM Zachary Turner <<a href="mailto:zturner@google.com">zturner@google.com</a>> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr">I'm building x64. Can you try that? Run "vcvarsall amd64" before building LLVM<br></div><br><div class="gmail_quote">On Mon, Apr 13, 2015 at 11:21 AM Kaylor, Andrew <<a href="mailto:andrew.kaylor@intel.com" target="_blank">andrew.kaylor@intel.com</a>> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<div lang="EN-US" link="blue" vlink="purple">
<div>
<p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1f497d">I haven’t seen that. I’m not seeing any warnings right now.<u></u><u></u></span></p>
<p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1f497d"><u></u> <u></u></span></p>
<p class="MsoNormal"><b><span style="font-size:10.0pt;font-family:"Tahoma","sans-serif"">From:</span></b><span style="font-size:10.0pt;font-family:"Tahoma","sans-serif""> Zachary Turner [mailto:<a href="mailto:zturner@google.com" target="_blank">zturner@google.com</a>]
<br>
<b>Sent:</b> Monday, April 13, 2015 11:17 AM<br>
<b>To:</b> Kaylor, Andrew; <a href="mailto:llvm-commits@cs.uiuc.edu" target="_blank">llvm-commits@cs.uiuc.edu</a><br>
<b>Subject:</b> Re: [llvm] r234343 - Enable W4 warnings by default for MSVC builds<u></u><u></u></span></p></div></div><div lang="EN-US" link="blue" vlink="purple"><div>
<p class="MsoNormal"><u></u> <u></u></p>
<div>
<p class="MsoNormal">Hi Andy, this is causing a huge slew of warning spam. Is this expected? CMake passes /W3 by default, so every single translation unit I compile gives me the following warning:<u></u><u></u></p>
<div>
<p class="MsoNormal"><u></u> <u></u></p>
<div>
<p class="MsoNormal">cl : Command line warning D9025 : overriding '/W3' with '/W4'<u></u><u></u></p>
</div>
<div>
<p class="MsoNormal"><u></u> <u></u></p>
</div>
<div>
<p class="MsoNormal">Furthermore, since this is a command line warning and not a compiler warning, it cannot be suppressed. Unless you have any better ideas on how to address this, I think this should be reverted.<u></u><u></u></p>
</div>
<div>
<p class="MsoNormal" style="margin-bottom:12.0pt"><u></u> <u></u></p>
<div>
<p class="MsoNormal">On Tue, Apr 7, 2015 at 12:07 PM Andrew Kaylor <<a href="mailto:andrew.kaylor@intel.com" target="_blank">andrew.kaylor@intel.com</a>> wrote:<u></u><u></u></p>
<p class="MsoNormal">Author: akaylor<br>
Date: Tue Apr 7 14:01:01 2015<br>
New Revision: 234343<br>
<br>
URL: <a href="http://llvm.org/viewvc/llvm-project?rev=234343&view=rev" target="_blank">
http://llvm.org/viewvc/llvm-project?rev=234343&view=rev</a><br>
Log:<br>
Enable W4 warnings by default for MSVC builds<br>
<br>
Modified:<br>
llvm/trunk/CMakeLists.txt<br>
<br>
Modified: llvm/trunk/CMakeLists.txt<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/llvm/trunk/CMakeLists.txt?rev=234343&r1=234342&r2=234343&view=diff" target="_blank">
http://llvm.org/viewvc/llvm-project/llvm/trunk/CMakeLists.txt?rev=234343&r1=234342&r2=234343&view=diff</a><br>
==============================================================================<br>
--- llvm/trunk/CMakeLists.txt (original)<br>
+++ llvm/trunk/CMakeLists.txt Tue Apr 7 14:01:01 2015<br>
@@ -233,14 +233,7 @@ list(REMOVE_DUPLICATES LLVM_TARGETS_TO_B<br>
include(AddLLVMDefinitions)<br>
<br>
option(LLVM_ENABLE_PIC "Build Position-Independent Code" ON)<br>
-<br>
-# MSVC has a gazillion warnings with this.<br>
-if( MSVC )<br>
- option(LLVM_ENABLE_WARNINGS "Enable compiler warnings." OFF)<br>
-else()<br>
- option(LLVM_ENABLE_WARNINGS "Enable compiler warnings." ON)<br>
-endif()<br>
-<br>
+option(LLVM_ENABLE_WARNINGS "Enable compiler warnings." ON)<br>
option(LLVM_ENABLE_MODULES "Compile with C++ modules enabled." OFF)<br>
option(LLVM_ENABLE_CXX1Y "Compile with C++1y enabled." OFF)<br>
option(LLVM_ENABLE_LIBCXX "Use libc++ if available." OFF)<br>
<br>
<br>
_______________________________________________<br>
llvm-commits mailing list<br>
<a href="mailto:llvm-commits@cs.uiuc.edu" target="_blank">llvm-commits@cs.uiuc.edu</a><br>
<a href="http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits" target="_blank">http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits</a><u></u><u></u></p>
</div>
</div>
</div>
</div>
</div></div></blockquote></div></blockquote></div></div>