<html xmlns:v="urn:schemas-microsoft-com:vml" xmlns:o="urn:schemas-microsoft-com:office:office" xmlns:w="urn:schemas-microsoft-com:office:word" xmlns:m="http://schemas.microsoft.com/office/2004/12/omml" xmlns="http://www.w3.org/TR/REC-html40">
<head>
<meta http-equiv="Content-Type" content="text/html; charset=utf-8">
<meta name="Generator" content="Microsoft Word 14 (filtered medium)">
<style><!--
/* Font Definitions */
@font-face
{font-family:Calibri;
panose-1:2 15 5 2 2 2 4 3 2 4;}
@font-face
{font-family:Tahoma;
panose-1:2 11 6 4 3 5 4 4 2 4;}
/* Style Definitions */
p.MsoNormal, li.MsoNormal, div.MsoNormal
{margin:0in;
margin-bottom:.0001pt;
font-size:12.0pt;
font-family:"Times New Roman","serif";}
a:link, span.MsoHyperlink
{mso-style-priority:99;
color:blue;
text-decoration:underline;}
a:visited, span.MsoHyperlinkFollowed
{mso-style-priority:99;
color:purple;
text-decoration:underline;}
span.EmailStyle17
{mso-style-type:personal-reply;
font-family:"Calibri","sans-serif";
color:#1F497D;}
.MsoChpDefault
{mso-style-type:export-only;
font-family:"Calibri","sans-serif";}
@page WordSection1
{size:8.5in 11.0in;
margin:1.0in 1.0in 1.0in 1.0in;}
div.WordSection1
{page:WordSection1;}
--></style><!--[if gte mso 9]><xml>
<o:shapedefaults v:ext="edit" spidmax="1026" />
</xml><![endif]--><!--[if gte mso 9]><xml>
<o:shapelayout v:ext="edit">
<o:idmap v:ext="edit" data="1" />
</o:shapelayout></xml><![endif]-->
</head>
<body lang="EN-US" link="blue" vlink="purple">
<div class="WordSection1">
<p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1F497D">I haven’t seen that. I’m not seeing any warnings right now.<o:p></o:p></span></p>
<p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1F497D"><o:p> </o:p></span></p>
<p class="MsoNormal"><b><span style="font-size:10.0pt;font-family:"Tahoma","sans-serif"">From:</span></b><span style="font-size:10.0pt;font-family:"Tahoma","sans-serif""> Zachary Turner [mailto:zturner@google.com]
<br>
<b>Sent:</b> Monday, April 13, 2015 11:17 AM<br>
<b>To:</b> Kaylor, Andrew; llvm-commits@cs.uiuc.edu<br>
<b>Subject:</b> Re: [llvm] r234343 - Enable W4 warnings by default for MSVC builds<o:p></o:p></span></p>
<p class="MsoNormal"><o:p> </o:p></p>
<div>
<p class="MsoNormal">Hi Andy, this is causing a huge slew of warning spam. Is this expected? CMake passes /W3 by default, so every single translation unit I compile gives me the following warning:<o:p></o:p></p>
<div>
<p class="MsoNormal"><o:p> </o:p></p>
<div>
<p class="MsoNormal">cl : Command line warning D9025 : overriding '/W3' with '/W4'<o:p></o:p></p>
</div>
<div>
<p class="MsoNormal"><o:p> </o:p></p>
</div>
<div>
<p class="MsoNormal">Furthermore, since this is a command line warning and not a compiler warning, it cannot be suppressed. Unless you have any better ideas on how to address this, I think this should be reverted.<o:p></o:p></p>
</div>
<div>
<p class="MsoNormal" style="margin-bottom:12.0pt"><o:p> </o:p></p>
<div>
<p class="MsoNormal">On Tue, Apr 7, 2015 at 12:07 PM Andrew Kaylor <<a href="mailto:andrew.kaylor@intel.com" target="_blank">andrew.kaylor@intel.com</a>> wrote:<o:p></o:p></p>
<p class="MsoNormal">Author: akaylor<br>
Date: Tue Apr 7 14:01:01 2015<br>
New Revision: 234343<br>
<br>
URL: <a href="http://llvm.org/viewvc/llvm-project?rev=234343&view=rev" target="_blank">
http://llvm.org/viewvc/llvm-project?rev=234343&view=rev</a><br>
Log:<br>
Enable W4 warnings by default for MSVC builds<br>
<br>
Modified:<br>
llvm/trunk/CMakeLists.txt<br>
<br>
Modified: llvm/trunk/CMakeLists.txt<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/llvm/trunk/CMakeLists.txt?rev=234343&r1=234342&r2=234343&view=diff" target="_blank">
http://llvm.org/viewvc/llvm-project/llvm/trunk/CMakeLists.txt?rev=234343&r1=234342&r2=234343&view=diff</a><br>
==============================================================================<br>
--- llvm/trunk/CMakeLists.txt (original)<br>
+++ llvm/trunk/CMakeLists.txt Tue Apr 7 14:01:01 2015<br>
@@ -233,14 +233,7 @@ list(REMOVE_DUPLICATES LLVM_TARGETS_TO_B<br>
include(AddLLVMDefinitions)<br>
<br>
option(LLVM_ENABLE_PIC "Build Position-Independent Code" ON)<br>
-<br>
-# MSVC has a gazillion warnings with this.<br>
-if( MSVC )<br>
- option(LLVM_ENABLE_WARNINGS "Enable compiler warnings." OFF)<br>
-else()<br>
- option(LLVM_ENABLE_WARNINGS "Enable compiler warnings." ON)<br>
-endif()<br>
-<br>
+option(LLVM_ENABLE_WARNINGS "Enable compiler warnings." ON)<br>
option(LLVM_ENABLE_MODULES "Compile with C++ modules enabled." OFF)<br>
option(LLVM_ENABLE_CXX1Y "Compile with C++1y enabled." OFF)<br>
option(LLVM_ENABLE_LIBCXX "Use libc++ if available." OFF)<br>
<br>
<br>
_______________________________________________<br>
llvm-commits mailing list<br>
<a href="mailto:llvm-commits@cs.uiuc.edu" target="_blank">llvm-commits@cs.uiuc.edu</a><br>
<a href="http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits" target="_blank">http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits</a><o:p></o:p></p>
</div>
</div>
</div>
</div>
</div>
</body>
</html>