<div dir="ltr"><div class="gmail_extra"><br><div class="gmail_quote">On Fri, Apr 10, 2015 at 2:45 AM, Dmitry Vyukov <span dir="ltr"><<a href="mailto:dvyukov@google.com" target="_blank">dvyukov@google.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Author: dvyukov<br>
Date: Fri Apr 10 04:45:22 2015<br>
New Revision: 234579<br>
<br>
URL: <a href="http://llvm.org/viewvc/llvm-project?rev=234579&view=rev" target="_blank">http://llvm.org/viewvc/llvm-project?rev=234579&view=rev</a><br>
Log:<br>
[sanitizer][MIPS] Fix warnings on MIPS<br>
Fixed:<br>
- stack frame size warning.<br>
- msse3 flag unused warning.<br>
- GoTsanRuntimeCheck dependency warning reported by cmake.<br>
<br>
Change by Sagar Thakur<br>
Reviewed in <a href="http://reviews.llvm.org/D8963" target="_blank">http://reviews.llvm.org/D8963</a><br>
<br>
<br>
Modified:<br>
compiler-rt/trunk/CMakeLists.txt<br>
compiler-rt/trunk/cmake/config-ix.cmake<br>
compiler-rt/trunk/test/tsan/CMakeLists.txt<br>
<br>
Modified: compiler-rt/trunk/CMakeLists.txt<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/compiler-rt/trunk/CMakeLists.txt?rev=234579&r1=234578&r2=234579&view=diff" target="_blank">http://llvm.org/viewvc/llvm-project/compiler-rt/trunk/CMakeLists.txt?rev=234579&r1=234578&r2=234579&view=diff</a><br>
==============================================================================<br>
--- compiler-rt/trunk/CMakeLists.txt (original)<br>
+++ compiler-rt/trunk/CMakeLists.txt Fri Apr 10 04:45:22 2015<br>
@@ -238,12 +238,13 @@ if(NOT COMPILER_RT_DEBUG AND NOT MSVC)<br>
endif()<br>
<br>
# Determine if we should restrict stack frame sizes.<br>
-# Stack frames on PowerPC and in debug biuld can be much larger than<br>
+# Stack frames on PowerPC and Mips and in debug biuld can be much larger than<br>
# anticipated.<br>
# FIXME: Fix all sanitizers and add -Wframe-larger-than to<br>
# SANITIZER_COMMON_FLAGS<br>
if(COMPILER_RT_HAS_WFRAME_LARGER_THAN_FLAG AND NOT COMPILER_RT_DEBUG<br>
- AND NOT ${LLVM_NATIVE_ARCH} STREQUAL "PowerPC")<br>
+ AND NOT ${LLVM_NATIVE_ARCH} STREQUAL "PowerPC"<br>
+ AND NOT ${LLVM_NATIVE_ARCH} STREQUAL "Mips")<br>
set(SANITIZER_LIMIT_FRAME_SIZE TRUE)<br>
else()<br>
set(SANITIZER_LIMIT_FRAME_SIZE FALSE)<br>
<br>
Modified: compiler-rt/trunk/cmake/config-ix.cmake<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/compiler-rt/trunk/cmake/config-ix.cmake?rev=234579&r1=234578&r2=234579&view=diff" target="_blank">http://llvm.org/viewvc/llvm-project/compiler-rt/trunk/cmake/config-ix.cmake?rev=234579&r1=234578&r2=234579&view=diff</a><br>
==============================================================================<br>
--- compiler-rt/trunk/cmake/config-ix.cmake (original)<br>
+++ compiler-rt/trunk/cmake/config-ix.cmake Fri Apr 10 04:45:22 2015<br>
@@ -308,3 +308,10 @@ else()<br>
set(COMPILER_RT_HAS_UBSAN FALSE)<br>
endif()<br>
<br>
+# -msse3 flag is not valid for Mips therefore clang gives a warning<br>
+# message with -msse3. But check_c_compiler_flags() checks only for<br>
+# compiler error messages. Therefore COMPILER_RT_HAS_MSSE3_FLAG turns out to be<br>
+# true on Mips. So we make it false here.<br>
+if("${LLVM_NATIVE_ARCH}" STREQUAL "Mips")<br>
+ set(COMPILER_RT_HAS_MSSE3_FLAG FALSE)<br>
+endif()<br></blockquote><div><br></div><div>^^</div><div>This is incorrect. Consider passing "-Werror -msse3" to check_cxx_compiler_flag() invocation.</div><div>We already do that for some warnings flags.</div><div> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<br>
Modified: compiler-rt/trunk/test/tsan/CMakeLists.txt<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/compiler-rt/trunk/test/tsan/CMakeLists.txt?rev=234579&r1=234578&r2=234579&view=diff" target="_blank">http://llvm.org/viewvc/llvm-project/compiler-rt/trunk/test/tsan/CMakeLists.txt?rev=234579&r1=234578&r2=234579&view=diff</a><br>
==============================================================================<br>
--- compiler-rt/trunk/test/tsan/CMakeLists.txt (original)<br>
+++ compiler-rt/trunk/test/tsan/CMakeLists.txt Fri Apr 10 04:45:22 2015<br>
@@ -1,5 +1,7 @@<br>
set(TSAN_TEST_DEPS ${SANITIZER_COMMON_LIT_TEST_DEPS})<br>
-list(APPEND TSAN_TEST_DEPS GotsanRuntimeCheck)<br>
+if(NOT ${LLVM_NATIVE_ARCH} STREQUAL "Mips")<br>
+ list(APPEND TSAN_TEST_DEPS GotsanRuntimeCheck)<br>
+endif()<br>
if(NOT COMPILER_RT_STANDALONE_BUILD)<br>
list(APPEND TSAN_TEST_DEPS tsan)<br>
endif()<br>
<br>
<br>
_______________________________________________<br>
llvm-commits mailing list<br>
<a href="mailto:llvm-commits@cs.uiuc.edu">llvm-commits@cs.uiuc.edu</a><br>
<a href="http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits" target="_blank">http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits</a><br>
</blockquote></div><br><br clear="all"><div><br></div>-- <br><div class="gmail_signature"><div dir="ltr">Alexey Samsonov<br><a href="mailto:vonosmas@gmail.com" target="_blank">vonosmas@gmail.com</a></div></div>
</div></div>