<html><head><meta http-equiv="Content-Type" content="text/html charset=windows-1252"></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space;" class="">Hi François,<div class=""><br class=""></div><div class="">I haven’t looked at the patch yet, but first high level comment.</div><div class="">Please integrate the test case with your patch and use RUN and CHECK lines.</div><div class=""><br class=""></div><div class="">Then, would it be possible to have the new patch uploaded to <a href="http://reviews.llvm.org" class="">reviews.llvm.org</a> with the full context?</div><div class=""><br class=""></div><div class="">Thanks,</div><div class="">-Quentin<br class=""><div><blockquote type="cite" class=""><div class="">On Apr 3, 2015, at 6:13 AM, Francois de Ferriere <<a href="mailto:francois.de-ferriere@st.com" class="">francois.de-ferriere@st.com</a>> wrote:</div><br class="Apple-interchange-newline"><div class="">Hi,<br class=""><br class=""> I post a patch for a missed optimization in the DAGCombiner.cpp LLVM file for the selection of Post Indexed Load and Store operations.<br class=""><br class=""> The code in the function CombineToPostIndexedLoadStore that checks the uses of an ADD/SUB operation does not correctly check the real uses.<br class=""><br class=""> Also, in the function canFoldInAddressingMode, VT is computed as the type of the destination/source of a LOAD/STORE operations, instead of the memory type of the operation. On targets which have a scaling factor on the offset of the LOAD/STORE operations, the function may return false for actually valid cases.<br class=""><br class=""> I could reproduce this problem on the ARM target, a test case that exposes this problem is attached to this mail.<br class=""><br class=""> Thanks to review it and commit it when it is OK.<br class=""><br class=""> Regards,<br class=""><br class=""> - François.<br class=""><span id="cid:720A333A-21B0-4BF3-9A42-C474417F5ADD"><automod_patch.txt></span><span id="cid:A78D689C-A53B-4F36-9975-BC6476C67355"><automod_test.ll></span>_______________________________________________<br class="">llvm-commits mailing list<br class=""><a href="mailto:llvm-commits@cs.uiuc.edu" class="">llvm-commits@cs.uiuc.edu</a><br class="">http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits<br class=""></div></blockquote></div><br class=""></div></body></html>