<div dir="ltr">For the record, this is awesome and we should totally do this.<div><br></div><div>-eric<br><br><div class="gmail_quote">On Thu, Apr 9, 2015 at 10:29 AM Alexander Kornienko <<a href="mailto:alexfh@google.com">alexfh@google.com</a>> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Hi dblaikie,<br>
<br>
The patch is generated using clang-tidy misc-use-override check.<br>
<br>
This command was used:<br>
<br>
tools/clang/tools/extra/clang-<u></u>tidy/tool/run-clang-tidy.py -checks='-*,misc-use-override' -header-filter='llvm|clang' -j=32 -fix<br>
<br>
REPOSITORY<br>
rL LLVM<br>
<br>
<a href="http://reviews.llvm.org/D8925" target="_blank">http://reviews.llvm.org/D8925</a><br>
<br>
Files:<br>
examples/ExceptionDemo/<u></u>ExceptionDemo.cpp<br>
examples/Kaleidoscope/<u></u>Chapter3/toy.cpp<br>
examples/Kaleidoscope/<u></u>Chapter4/toy.cpp<br>
examples/Kaleidoscope/<u></u>Chapter5/toy.cpp<br>
examples/Kaleidoscope/<u></u>Chapter6/toy.cpp<br>
examples/Kaleidoscope/<u></u>Chapter7/toy.cpp<br>
examples/Kaleidoscope/<u></u>Chapter8/toy.cpp<br>
include/llvm/Analysis/<u></u>AssumptionCache.h<br>
include/llvm/Analysis/<u></u>BlockFrequencyInfo.h<br>
include/llvm/Analysis/<u></u>CallGraph.h<br>
include/llvm/Analysis/<u></u>DependenceAnalysis.h<br>
include/llvm/Analysis/<u></u>InlineCost.h<br>
include/llvm/Analysis/<u></u>JumpInstrTableInfo.h<br>
include/llvm/Analysis/<u></u>LazyValueInfo.h<br>
include/llvm/Analysis/<u></u>LibCallAliasAnalysis.h<br>
include/llvm/Analysis/<u></u>MemoryDependenceAnalysis.h<br>
include/llvm/Analysis/<u></u>PostDominators.h<br>
include/llvm/Analysis/<u></u>RegionInfo.h<br>
include/llvm/CodeGen/<u></u>AsmPrinter.h<br>
include/llvm/CodeGen/<u></u>LiveIntervalAnalysis.h<br>
include/llvm/CodeGen/<u></u>LiveRangeEdit.h<br>
include/llvm/CodeGen/<u></u>MachineBlockFrequencyInfo.h<br>
include/llvm/CodeGen/<u></u>MachineDominators.h<br>
include/llvm/CodeGen/<u></u>MachineFunctionAnalysis.h<br>
include/llvm/CodeGen/<u></u>MachineModuleInfo.h<br>
include/llvm/CodeGen/<u></u>MachinePassRegistry.h<br>
include/llvm/CodeGen/<u></u>MachinePostDominators.h<br>
include/llvm/CodeGen/<u></u>MachineRegionInfo.h<br>
include/llvm/CodeGen/<u></u>MachineScheduler.h<br>
include/llvm/CodeGen/Passes.h<br>
include/llvm/CodeGen/<u></u>ScheduleDAGInstrs.h<br>
include/llvm/CodeGen/<u></u>SelectionDAGISel.h<br>
include/llvm/CodeGen/<u></u>TargetLoweringObjectFileImpl.h<br>
include/llvm/DebugInfo/PDB/<u></u>ConcreteSymbolEnumerator.h<br>
include/llvm/ExecutionEngine/<u></u>RTDyldMemoryManager.h<br>
include/llvm/ExecutionEngine/<u></u>SectionMemoryManager.h<br>
include/llvm/IR/BasicBlock.h<br>
include/llvm/IR/Constants.h<br>
include/llvm/IR/Function.h<br>
include/llvm/IR/GlobalValue.h<br>
include/llvm/IR/<u></u>GlobalVariable.h<br>
include/llvm/IR/InlineAsm.h<br>
include/llvm/IR/InstrTypes.h<br>
include/llvm/IR/Instruction.h<br>
include/llvm/IR/Instructions.h<br>
include/llvm/IR/<u></u>LegacyPassManager.h<br>
include/llvm/IR/<u></u>LegacyPassNameParser.h<br>
include/llvm/IR/Metadata.h<br>
include/llvm/IR/Operator.h<br>
include/llvm/IR/User.h<br>
include/llvm/LineEditor/<u></u>LineEditor.h<br>
include/llvm/MC/MCAsmInfoELF.h<br>
include/llvm/MC/MCAssembler.h<br>
include/llvm/MC/MCELFStreamer.<u></u>h<br>
include/llvm/MC/MCInstrInfo.h<br>
include/llvm/MC/<u></u>MCLinkerOptimizationHint.h<br>
include/llvm/MC/<u></u>MCObjectStreamer.h<br>
include/llvm/MC/MCParser/<u></u>AsmLexer.h<br>
include/llvm/MC/MCSectionCOFF.<u></u>h<br>
include/llvm/MC/MCSectionELF.h<br>
include/llvm/MC/MCStreamer.h<br>
include/llvm/MC/<u></u>MCTargetAsmParser.h<br>
include/llvm/Object/<u></u>IRObjectFile.h<br>
include/llvm/Object/<u></u>SymbolicFile.h<br>
include/llvm/Option/ArgList.h<br>
include/llvm/Pass.h<br>
include/llvm/Support/<u></u>FormattedStream.h<br>
include/llvm/Support/<u></u>YAMLTraits.h<br>
include/llvm/Support/circular_<u></u>raw_ostream.h<br>
include/llvm/Support/raw_os_<u></u>ostream.h<br>
include/llvm/Support/raw_<u></u>ostream.h<br>
lib/Analysis/<u></u>AliasAnalysisCounter.cpp<br>
lib/Analysis/CFLAliasAnalysis.<u></u>cpp<br>
lib/Bitcode/Reader/<u></u>BitcodeReader.cpp<br>
lib/CodeGen/<u></u>AggressiveAntiDepBreaker.h<br>
lib/CodeGen/AsmPrinter/<u></u>DwarfException.h<br>
lib/CodeGen/AsmPrinter/<u></u>EHStreamer.h<br>
lib/CodeGen/AsmPrinter/<u></u>Win64Exception.h<br>
lib/CodeGen/AsmPrinter/<u></u>WinCodeViewLineTables.h<br>
lib/CodeGen/CodeGenPrepare.cpp<br>
lib/CodeGen/<u></u>CriticalAntiDepBreaker.h<br>
lib/CodeGen/InlineSpiller.cpp<br>
lib/CodeGen/<u></u>LiveDebugVariables.h<br>
lib/CodeGen/<u></u>PostRASchedulerList.cpp<br>
lib/CodeGen/SelectionDAG/<u></u>ScheduleDAGRRList.cpp<br>
lib/CodeGen/SelectionDAG/<u></u>ScheduleDAGSDNodes.h<br>
lib/CodeGen/SelectionDAG/<u></u>ScheduleDAGVLIW.cpp<br>
lib/CodeGen/SelectionDAG/<u></u>SelectionDAGISel.cpp<br>
lib/CodeGen/SpillPlacement.h<br>
lib/CodeGen/WinEHPrepare.cpp<br>
lib/DebugInfo/DWARF/<u></u>DWARFDebugFrame.cpp<br>
lib/DebugInfo/PDB/<u></u>PDBSymbolFunc.cpp<br>
lib/DebugInfo/PDB/<u></u>PDBSymbolTypeFunctionSig.cpp<br>
lib/ExecutionEngine/<u></u>ExecutionEngineBindings.cpp<br>
lib/ExecutionEngine/<u></u>GDBRegistrationListener.cpp<br>
lib/ExecutionEngine/<u></u>Interpreter/Interpreter.h<br>
lib/ExecutionEngine/MCJIT/<u></u>MCJIT.h<br>
lib/ExecutionEngine/Orc/<u></u>OrcMCJITReplacement.h<br>
lib/ExecutionEngine/<u></u>RuntimeDyld/RuntimeDyldELF.h<br>
lib/IR/LegacyPassManager.cpp<br>
lib/MC/ELFObjectWriter.cpp<br>
lib/MC/MCParser/AsmParser.cpp<br>
lib/Support/CommandLine.cpp<br>
lib/Support/DataStream.cpp<br>
lib/Target/AArch64/<u></u>MCTargetDesc/<u></u>AArch64ELFObjectWriter.cpp<br>
lib/Target/AArch64/<u></u>MCTargetDesc/<u></u>AArch64ELFStreamer.cpp<br>
lib/Target/AArch64/<u></u>MCTargetDesc/<u></u>AArch64MCCodeEmitter.cpp<br>
lib/Target/ARM/<u></u>ARMConstantPoolValue.h<br>
lib/Target/ARM/Disassembler/<u></u>ARMDisassembler.cpp<br>
lib/Target/ARM/MCTargetDesc/<u></u>ARMELFObjectWriter.cpp<br>
lib/Target/ARM/MCTargetDesc/<u></u>ARMMCCodeEmitter.cpp<br>
lib/Target/ARM/MCTargetDesc/<u></u>ARMWinCOFFObjectWriter.cpp<br>
lib/Target/Hexagon/<u></u>MCTargetDesc/<u></u>HexagonELFObjectWriter.cpp<br>
lib/Target/Mips/MCTargetDesc/<u></u>MipsELFObjectWriter.cpp<br>
lib/Target/Mips/MCTargetDesc/<u></u>MipsMCCodeEmitter.h<br>
lib/Target/Mips/MCTargetDesc/<u></u>MipsNaClELFStreamer.cpp<br>
lib/Target/Mips/<u></u>MipsOptionRecord.h<br>
lib/Target/PowerPC/<u></u>Disassembler/PPCDisassembler.<u></u>cpp<br>
lib/Target/PowerPC/<u></u>MCTargetDesc/PPCMCCodeEmitter.<u></u>cpp<br>
lib/Target/PowerPC/<u></u>PPCTargetStreamer.h<br>
lib/Target/R600/MCTargetDesc/<u></u>SIMCCodeEmitter.cpp<br>
lib/Target/Sparc/MCTargetDesc/<u></u>SparcELFObjectWriter.cpp<br>
lib/Target/Sparc/MCTargetDesc/<u></u>SparcMCCodeEmitter.cpp<br>
lib/Target/Sparc/<u></u>SparcSelectionDAGInfo.h<br>
lib/Target/SystemZ/<u></u>Disassembler/<u></u>SystemZDisassembler.cpp<br>
lib/Target/SystemZ/<u></u>MCTargetDesc/<u></u>SystemZMCCodeEmitter.cpp<br>
lib/Target/SystemZ/<u></u>MCTargetDesc/<u></u>SystemZMCObjectWriter.cpp<br>
lib/Target/X86/MCTargetDesc/<u></u>X86ELFObjectWriter.cpp<br>
lib/Target/X86/MCTargetDesc/<u></u>X86MCCodeEmitter.cpp<br>
lib/Target/X86/MCTargetDesc/<u></u>X86WinCOFFObjectWriter.cpp<br>
lib/Target/XCore/<u></u>XCoreTargetStreamer.h<br>
lib/Transforms/Scalar/<u></u>AlignmentFromAssumptions.cpp<br>
tools/bugpoint/ToolRunner.h<br>
tools/lli/RemoteMemoryManager.<u></u>h<br>
tools/lli/<u></u>RemoteTargetExternal.h<br>
tools/lli/lli.cpp<br>
unittests/ADT/<u></u>DAGDeltaAlgorithmTest.cpp<br>
unittests/ADT/<u></u>DeltaAlgorithmTest.cpp<br>
unittests/ADT/SmallVectorTest.<u></u>cpp<br>
unittests/Analysis/CFGTest.cpp<br>
unittests/Analysis/<u></u>ScalarEvolutionTest.cpp<br>
unittests/ExecutionEngine/<u></u>ExecutionEngineTest.cpp<br>
unittests/ExecutionEngine/<u></u>MCJIT/MCJITCAPITest.cpp<br>
unittests/ExecutionEngine/<u></u>MCJIT/MCJITObjectCacheTest.cpp<br>
unittests/ExecutionEngine/<u></u>MCJIT/MCJITTest.cpp<br>
unittests/IR/<u></u>DominatorTreeTest.cpp<br>
unittests/IR/IRBuilderTest.cpp<br>
unittests/IR/ValueHandleTest.<u></u>cpp<br>
unittests/LineEditor/<u></u>LineEditor.cpp<br>
unittests/Linker/<u></u>LinkModulesTest.cpp<br>
unittests/Support/AlignOfTest.<u></u>cpp<br>
unittests/Support/<u></u>CommandLineTest.cpp<br>
unittests/Support/<u></u>MemoryBufferTest.cpp<br>
unittests/Support/Path.cpp<br>
unittests/Transforms/Utils/<u></u>Cloning.cpp<br>
utils/TableGen/DAGISelMatcher.<u></u>h<br>
utils/unittest/googletest/<u></u>include/gtest/gtest-spi.h<br>
utils/unittest/googletest/<u></u>include/gtest/gtest-test-part.<u></u>h<br>
utils/unittest/googletest/<u></u>include/gtest/gtest.h<br>
utils/unittest/googletest/<u></u>include/gtest/internal/gtest-<u></u>death-test-internal.h<br>
utils/unittest/googletest/<u></u>include/gtest/internal/gtest-<u></u>internal.h<br>
utils/unittest/googletest/<u></u>include/gtest/internal/gtest-<u></u>param-util.h<br>
utils/unittest/googletest/<u></u>include/gtest/internal/gtest-<u></u>port.h<br>
utils/unittest/googletest/src/<u></u>gtest-death-test.cc<br>
utils/unittest/googletest/src/<u></u>gtest-internal-inl.h<br>
utils/unittest/googletest/src/<u></u>gtest.cc<br>
<br>
EMAIL PREFERENCES<br>
<a href="http://reviews.llvm.org/settings/panel/emailpreferences/" target="_blank">http://reviews.llvm.org/<u></u>settings/panel/<u></u>emailpreferences/</a><br>
______________________________<u></u>_________________<br>
llvm-commits mailing list<br>
<a href="mailto:llvm-commits@cs.uiuc.edu" target="_blank">llvm-commits@cs.uiuc.edu</a><br>
<a href="http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits" target="_blank">http://lists.cs.uiuc.edu/<u></u>mailman/listinfo/llvm-commits</a><br>
</blockquote></div></div></div>