<div dir="ltr">A lot of these seem to be destructors. Do we really want override on destructors? It's sort of implicit when the class isn't a base class.</div><div class="gmail_extra"><br><div class="gmail_quote">On Thu, Apr 9, 2015 at 10:26 AM, Alexander Kornienko <span dir="ltr"><<a href="mailto:alexfh@google.com" target="_blank">alexfh@google.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Hi dblaikie,<br>
<br>
The patch is generated using clang-tidy misc-use-override check.<br>
<br>
This command was used:<br>
<br>
tools/clang/tools/extra/clang-tidy/tool/run-clang-tidy.py -checks='-*,misc-use-override' -header-filter='llvm|clang' -j=32 -fix<br>
<br>
REPOSITORY<br>
rL LLVM<br>
<br>
<a href="http://reviews.llvm.org/D8925" target="_blank">http://reviews.llvm.org/D8925</a><br>
<br>
Files:<br>
examples/ExceptionDemo/ExceptionDemo.cpp<br>
examples/Kaleidoscope/Chapter3/toy.cpp<br>
examples/Kaleidoscope/Chapter4/toy.cpp<br>
examples/Kaleidoscope/Chapter5/toy.cpp<br>
examples/Kaleidoscope/Chapter6/toy.cpp<br>
examples/Kaleidoscope/Chapter7/toy.cpp<br>
examples/Kaleidoscope/Chapter8/toy.cpp<br>
include/llvm/Analysis/AssumptionCache.h<br>
include/llvm/Analysis/BlockFrequencyInfo.h<br>
include/llvm/Analysis/CallGraph.h<br>
include/llvm/Analysis/DependenceAnalysis.h<br>
include/llvm/Analysis/InlineCost.h<br>
include/llvm/Analysis/JumpInstrTableInfo.h<br>
include/llvm/Analysis/LazyValueInfo.h<br>
include/llvm/Analysis/LibCallAliasAnalysis.h<br>
include/llvm/Analysis/MemoryDependenceAnalysis.h<br>
include/llvm/Analysis/PostDominators.h<br>
include/llvm/Analysis/RegionInfo.h<br>
include/llvm/CodeGen/AsmPrinter.h<br>
include/llvm/CodeGen/LiveIntervalAnalysis.h<br>
include/llvm/CodeGen/LiveRangeEdit.h<br>
include/llvm/CodeGen/MachineBlockFrequencyInfo.h<br>
include/llvm/CodeGen/MachineDominators.h<br>
include/llvm/CodeGen/MachineFunctionAnalysis.h<br>
include/llvm/CodeGen/MachineModuleInfo.h<br>
include/llvm/CodeGen/MachinePassRegistry.h<br>
include/llvm/CodeGen/MachinePostDominators.h<br>
include/llvm/CodeGen/MachineRegionInfo.h<br>
include/llvm/CodeGen/MachineScheduler.h<br>
include/llvm/CodeGen/Passes.h<br>
include/llvm/CodeGen/ScheduleDAGInstrs.h<br>
include/llvm/CodeGen/SelectionDAGISel.h<br>
include/llvm/CodeGen/TargetLoweringObjectFileImpl.h<br>
include/llvm/DebugInfo/PDB/ConcreteSymbolEnumerator.h<br>
include/llvm/ExecutionEngine/RTDyldMemoryManager.h<br>
include/llvm/ExecutionEngine/SectionMemoryManager.h<br>
include/llvm/IR/BasicBlock.h<br>
include/llvm/IR/Constants.h<br>
include/llvm/IR/Function.h<br>
include/llvm/IR/GlobalValue.h<br>
include/llvm/IR/GlobalVariable.h<br>
include/llvm/IR/InlineAsm.h<br>
include/llvm/IR/InstrTypes.h<br>
include/llvm/IR/Instruction.h<br>
include/llvm/IR/Instructions.h<br>
include/llvm/IR/LegacyPassManager.h<br>
include/llvm/IR/LegacyPassNameParser.h<br>
include/llvm/IR/Metadata.h<br>
include/llvm/IR/Operator.h<br>
include/llvm/IR/User.h<br>
include/llvm/LineEditor/LineEditor.h<br>
include/llvm/MC/MCAsmInfoELF.h<br>
include/llvm/MC/MCAssembler.h<br>
include/llvm/MC/MCELFStreamer.h<br>
include/llvm/MC/MCInstrInfo.h<br>
include/llvm/MC/MCLinkerOptimizationHint.h<br>
include/llvm/MC/MCObjectStreamer.h<br>
include/llvm/MC/MCParser/AsmLexer.h<br>
include/llvm/MC/MCSectionCOFF.h<br>
include/llvm/MC/MCSectionELF.h<br>
include/llvm/MC/MCStreamer.h<br>
include/llvm/MC/MCTargetAsmParser.h<br>
include/llvm/Object/IRObjectFile.h<br>
include/llvm/Object/SymbolicFile.h<br>
include/llvm/Option/ArgList.h<br>
include/llvm/Pass.h<br>
include/llvm/Support/FormattedStream.h<br>
include/llvm/Support/YAMLTraits.h<br>
include/llvm/Support/circular_raw_ostream.h<br>
include/llvm/Support/raw_os_ostream.h<br>
include/llvm/Support/raw_ostream.h<br>
lib/Analysis/AliasAnalysisCounter.cpp<br>
lib/Analysis/CFLAliasAnalysis.cpp<br>
lib/Bitcode/Reader/BitcodeReader.cpp<br>
lib/CodeGen/AggressiveAntiDepBreaker.h<br>
lib/CodeGen/AsmPrinter/DwarfException.h<br>
lib/CodeGen/AsmPrinter/EHStreamer.h<br>
lib/CodeGen/AsmPrinter/Win64Exception.h<br>
lib/CodeGen/AsmPrinter/WinCodeViewLineTables.h<br>
lib/CodeGen/CodeGenPrepare.cpp<br>
lib/CodeGen/CriticalAntiDepBreaker.h<br>
lib/CodeGen/InlineSpiller.cpp<br>
lib/CodeGen/LiveDebugVariables.h<br>
lib/CodeGen/PostRASchedulerList.cpp<br>
lib/CodeGen/SelectionDAG/ScheduleDAGRRList.cpp<br>
lib/CodeGen/SelectionDAG/ScheduleDAGSDNodes.h<br>
lib/CodeGen/SelectionDAG/ScheduleDAGVLIW.cpp<br>
lib/CodeGen/SelectionDAG/SelectionDAGISel.cpp<br>
lib/CodeGen/SpillPlacement.h<br>
lib/CodeGen/WinEHPrepare.cpp<br>
lib/DebugInfo/DWARF/DWARFDebugFrame.cpp<br>
lib/DebugInfo/PDB/PDBSymbolFunc.cpp<br>
lib/DebugInfo/PDB/PDBSymbolTypeFunctionSig.cpp<br>
lib/ExecutionEngine/ExecutionEngineBindings.cpp<br>
lib/ExecutionEngine/GDBRegistrationListener.cpp<br>
lib/ExecutionEngine/Interpreter/Interpreter.h<br>
lib/ExecutionEngine/MCJIT/MCJIT.h<br>
lib/ExecutionEngine/Orc/OrcMCJITReplacement.h<br>
lib/ExecutionEngine/RuntimeDyld/RuntimeDyldELF.h<br>
lib/IR/LegacyPassManager.cpp<br>
lib/MC/ELFObjectWriter.cpp<br>
lib/MC/MCParser/AsmParser.cpp<br>
lib/Support/CommandLine.cpp<br>
lib/Support/DataStream.cpp<br>
lib/Target/AArch64/MCTargetDesc/AArch64ELFObjectWriter.cpp<br>
lib/Target/AArch64/MCTargetDesc/AArch64ELFStreamer.cpp<br>
lib/Target/AArch64/MCTargetDesc/AArch64MCCodeEmitter.cpp<br>
lib/Target/ARM/ARMConstantPoolValue.h<br>
lib/Target/ARM/Disassembler/ARMDisassembler.cpp<br>
lib/Target/ARM/MCTargetDesc/ARMELFObjectWriter.cpp<br>
lib/Target/ARM/MCTargetDesc/ARMMCCodeEmitter.cpp<br>
lib/Target/ARM/MCTargetDesc/ARMWinCOFFObjectWriter.cpp<br>
lib/Target/Hexagon/MCTargetDesc/HexagonELFObjectWriter.cpp<br>
lib/Target/Mips/MCTargetDesc/MipsELFObjectWriter.cpp<br>
lib/Target/Mips/MCTargetDesc/MipsMCCodeEmitter.h<br>
lib/Target/Mips/MCTargetDesc/MipsNaClELFStreamer.cpp<br>
lib/Target/Mips/MipsOptionRecord.h<br>
lib/Target/PowerPC/Disassembler/PPCDisassembler.cpp<br>
lib/Target/PowerPC/MCTargetDesc/PPCMCCodeEmitter.cpp<br>
lib/Target/PowerPC/PPCTargetStreamer.h<br>
lib/Target/R600/MCTargetDesc/SIMCCodeEmitter.cpp<br>
lib/Target/Sparc/MCTargetDesc/SparcELFObjectWriter.cpp<br>
lib/Target/Sparc/MCTargetDesc/SparcMCCodeEmitter.cpp<br>
lib/Target/Sparc/SparcSelectionDAGInfo.h<br>
lib/Target/SystemZ/Disassembler/SystemZDisassembler.cpp<br>
lib/Target/SystemZ/MCTargetDesc/SystemZMCCodeEmitter.cpp<br>
lib/Target/SystemZ/MCTargetDesc/SystemZMCObjectWriter.cpp<br>
lib/Target/X86/MCTargetDesc/X86ELFObjectWriter.cpp<br>
lib/Target/X86/MCTargetDesc/X86MCCodeEmitter.cpp<br>
lib/Target/X86/MCTargetDesc/X86WinCOFFObjectWriter.cpp<br>
lib/Target/XCore/XCoreTargetStreamer.h<br>
lib/Transforms/Scalar/AlignmentFromAssumptions.cpp<br>
tools/bugpoint/ToolRunner.h<br>
tools/lli/RemoteMemoryManager.h<br>
tools/lli/RemoteTargetExternal.h<br>
tools/lli/lli.cpp<br>
unittests/ADT/DAGDeltaAlgorithmTest.cpp<br>
unittests/ADT/DeltaAlgorithmTest.cpp<br>
unittests/ADT/SmallVectorTest.cpp<br>
unittests/Analysis/CFGTest.cpp<br>
unittests/Analysis/ScalarEvolutionTest.cpp<br>
unittests/ExecutionEngine/ExecutionEngineTest.cpp<br>
unittests/ExecutionEngine/MCJIT/MCJITCAPITest.cpp<br>
unittests/ExecutionEngine/MCJIT/MCJITObjectCacheTest.cpp<br>
unittests/ExecutionEngine/MCJIT/MCJITTest.cpp<br>
unittests/IR/DominatorTreeTest.cpp<br>
unittests/IR/IRBuilderTest.cpp<br>
unittests/IR/ValueHandleTest.cpp<br>
unittests/LineEditor/LineEditor.cpp<br>
unittests/Linker/LinkModulesTest.cpp<br>
unittests/Support/AlignOfTest.cpp<br>
unittests/Support/CommandLineTest.cpp<br>
unittests/Support/MemoryBufferTest.cpp<br>
unittests/Support/Path.cpp<br>
unittests/Transforms/Utils/Cloning.cpp<br>
utils/TableGen/DAGISelMatcher.h<br>
utils/unittest/googletest/include/gtest/gtest-spi.h<br>
utils/unittest/googletest/include/gtest/gtest-test-part.h<br>
utils/unittest/googletest/include/gtest/gtest.h<br>
utils/unittest/googletest/include/gtest/internal/gtest-death-test-internal.h<br>
utils/unittest/googletest/include/gtest/internal/gtest-internal.h<br>
utils/unittest/googletest/include/gtest/internal/gtest-param-util.h<br>
utils/unittest/googletest/include/gtest/internal/gtest-port.h<br>
utils/unittest/googletest/src/gtest-death-test.cc<br>
utils/unittest/googletest/src/gtest-internal-inl.h<br>
utils/unittest/googletest/src/gtest.cc<br>
<br>
EMAIL PREFERENCES<br>
<a href="http://reviews.llvm.org/settings/panel/emailpreferences/" target="_blank">http://reviews.llvm.org/settings/panel/emailpreferences/</a><br>
<br>_______________________________________________<br>
llvm-commits mailing list<br>
<a href="mailto:llvm-commits@cs.uiuc.edu">llvm-commits@cs.uiuc.edu</a><br>
<a href="http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits" target="_blank">http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits</a><br>
<br></blockquote></div><br><br clear="all"><div><br></div>-- <br><div class="gmail_signature">~Craig</div>
</div>