<div dir="ltr">Cool! Thanks Benjamin.<div><br></div><div>- Lang.</div></div><div class="gmail_extra"><br><div class="gmail_quote">On Wed, Apr 8, 2015 at 6:17 AM, Benjamin Kramer <span dir="ltr"><<a href="mailto:benny.kra@googlemail.com" target="_blank">benny.kra@googlemail.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Author: d0k<br>
Date: Wed Apr  8 08:17:48 2015<br>
New Revision: 234404<br>
<br>
URL: <a href="http://llvm.org/viewvc/llvm-project?rev=234404&view=rev" target="_blank">http://llvm.org/viewvc/llvm-project?rev=234404&view=rev</a><br>
Log:<br>
[jitlistener] Remove unused code<br>
<br>
Removed:<br>
    llvm/trunk/lib/ExecutionEngine/EventListenerCommon.h<br>
Modified:<br>
    llvm/trunk/lib/ExecutionEngine/IntelJITEvents/IntelJITEventListener.cpp<br>
    llvm/trunk/lib/ExecutionEngine/OProfileJIT/OProfileJITEventListener.cpp<br>
<br>
Removed: llvm/trunk/lib/ExecutionEngine/EventListenerCommon.h<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/ExecutionEngine/EventListenerCommon.h?rev=234403&view=auto" target="_blank">http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/ExecutionEngine/EventListenerCommon.h?rev=234403&view=auto</a><br>
==============================================================================<br>
--- llvm/trunk/lib/ExecutionEngine/EventListenerCommon.h (original)<br>
+++ llvm/trunk/lib/ExecutionEngine/EventListenerCommon.h (removed)<br>
@@ -1,68 +0,0 @@<br>
-//===-- JIT.h - Abstract Execution Engine Interface -------------*- C++ -*-===//<br>
-//<br>
-//                     The LLVM Compiler Infrastructure<br>
-//<br>
-// This file is distributed under the University of Illinois Open Source<br>
-// License. See LICENSE.TXT for details.<br>
-//<br>
-//===----------------------------------------------------------------------===//<br>
-//<br>
-// Common functionality for JITEventListener implementations<br>
-//<br>
-//===----------------------------------------------------------------------===//<br>
-<br>
-#ifndef EVENT_LISTENER_COMMON_H<br>
-#define EVENT_LISTENER_COMMON_H<br>
-<br>
-#include "llvm/ADT/DenseMap.h"<br>
-#include "llvm/IR/DebugInfo.h"<br>
-#include "llvm/IR/Metadata.h"<br>
-#include "llvm/IR/ValueHandle.h"<br>
-#include "llvm/Support/Path.h"<br>
-<br>
-namespace llvm {<br>
-<br>
-namespace jitprofiling {<br>
-<br>
-class FilenameCache {<br>
-  // Holds the filename of each Scope, so that we can pass a null-terminated<br>
-  // string into oprofile.<br>
-  DenseMap<const MDNode *, std::string> Filenames;<br>
-  DenseMap<const MDNode *, std::string> Paths;<br>
-<br>
- public:<br>
-  const char *getFilename(MDNode *Scope) {<br>
-    assert(Scope->isResolved() && "Expected Scope to be resolved");<br>
-    std::string &Filename = Filenames[Scope];<br>
-    if (Filename.empty()) {<br>
-      DIScope DIScope(Scope);<br>
-      Filename = DIScope.getFilename();<br>
-    }<br>
-    return Filename.c_str();<br>
-  }<br>
-<br>
-  const char *getFullPath(MDNode *Scope) {<br>
-    assert(Scope->isResolved() && "Expected Scope to be resolved");<br>
-    std::string &P = Paths[Scope];<br>
-    if (P.empty()) {<br>
-      DIScope DIScope(Scope);<br>
-      StringRef DirName = DIScope.getDirectory();<br>
-      StringRef FileName = DIScope.getFilename();<br>
-      SmallString<256> FullPath;<br>
-      if (DirName != "." && DirName != "") {<br>
-        FullPath = DirName;<br>
-      }<br>
-      if (FileName != "") {<br>
-        sys::path::append(FullPath, FileName);<br>
-      }<br>
-      P = FullPath.str();<br>
-    }<br>
-    return P.c_str();<br>
-  }<br>
-};<br>
-<br>
-} // namespace jitprofiling<br>
-<br>
-} // namespace llvm<br>
-<br>
-#endif //EVENT_LISTENER_COMMON_H<br>
<br>
Modified: llvm/trunk/lib/ExecutionEngine/IntelJITEvents/IntelJITEventListener.cpp<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/ExecutionEngine/IntelJITEvents/IntelJITEventListener.cpp?rev=234404&r1=234403&r2=234404&view=diff" target="_blank">http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/ExecutionEngine/IntelJITEvents/IntelJITEventListener.cpp?rev=234404&r1=234403&r2=234404&view=diff</a><br>
==============================================================================<br>
--- llvm/trunk/lib/ExecutionEngine/IntelJITEvents/IntelJITEventListener.cpp (original)<br>
+++ llvm/trunk/lib/ExecutionEngine/IntelJITEvents/IntelJITEventListener.cpp Wed Apr  8 08:17:48 2015<br>
@@ -13,7 +13,6 @@<br>
 //===----------------------------------------------------------------------===//<br>
<br>
 #include "llvm/Config/config.h"<br>
-#include "EventListenerCommon.h"<br>
 #include "IntelJITEventsWrapper.h"<br>
 #include "llvm/ADT/DenseMap.h"<br>
 #include "llvm/CodeGen/MachineFunction.h"<br>
@@ -29,7 +28,6 @@<br>
 #include "llvm/Support/raw_ostream.h"<br>
<br>
 using namespace llvm;<br>
-using namespace llvm::jitprofiling;<br>
 using namespace llvm::object;<br>
<br>
 #define DEBUG_TYPE "amplifier-jit-event-listener"<br>
@@ -41,7 +39,6 @@ class IntelJITEventListener : public JIT<br>
<br>
   std::unique_ptr<IntelJITEventsWrapper> Wrapper;<br>
   MethodIDMap MethodIDs;<br>
-  FilenameCache Filenames;<br>
<br>
   typedef SmallVector<const void *, 64> MethodAddressVector;<br>
   typedef DenseMap<const void *, MethodAddressVector>  ObjectMap;<br>
<br>
Modified: llvm/trunk/lib/ExecutionEngine/OProfileJIT/OProfileJITEventListener.cpp<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/ExecutionEngine/OProfileJIT/OProfileJITEventListener.cpp?rev=234404&r1=234403&r2=234404&view=diff" target="_blank">http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/ExecutionEngine/OProfileJIT/OProfileJITEventListener.cpp?rev=234404&r1=234403&r2=234404&view=diff</a><br>
==============================================================================<br>
--- llvm/trunk/lib/ExecutionEngine/OProfileJIT/OProfileJITEventListener.cpp (original)<br>
+++ llvm/trunk/lib/ExecutionEngine/OProfileJIT/OProfileJITEventListener.cpp Wed Apr  8 08:17:48 2015<br>
@@ -13,7 +13,6 @@<br>
 //===----------------------------------------------------------------------===//<br>
<br>
 #include "llvm/Config/config.h"<br>
-#include "EventListenerCommon.h"<br>
 #include "llvm/CodeGen/MachineFunction.h"<br>
 #include "llvm/ExecutionEngine/JITEventListener.h"<br>
 #include "llvm/ExecutionEngine/OProfileWrapper.h"<br>
@@ -28,7 +27,6 @@<br>
 #include <fcntl.h><br>
<br>
 using namespace llvm;<br>
-using namespace llvm::jitprofiling;<br>
 using namespace llvm::object;<br>
<br>
 #define DEBUG_TYPE "oprofile-jit-event-listener"<br>
<br>
<br>
_______________________________________________<br>
llvm-commits mailing list<br>
<a href="mailto:llvm-commits@cs.uiuc.edu">llvm-commits@cs.uiuc.edu</a><br>
<a href="http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits" target="_blank">http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits</a><br>
</blockquote></div><br></div>