<html><head><meta http-equiv="Content-Type" content="text/html charset=utf-8"></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space;" class=""><br class=""><div><blockquote type="cite" class=""><div class="">On Apr 7, 2015, at 1:38 PM, Reid Kleckner <<a href="mailto:rnk@google.com" class="">rnk@google.com</a>> wrote:</div><br class="Apple-interchange-newline"><div class=""><div dir="ltr" style="font-family: Helvetica; font-size: 12px; font-style: normal; font-variant: normal; font-weight: normal; letter-spacing: normal; line-height: 14px; orphans: auto; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; widows: auto; word-spacing: 0px; -webkit-text-stroke-width: 0px;" class=""><div class="gmail_extra"><div class="gmail_quote">On Tue, Apr 7, 2015 at 1:17 PM, Pete Cooper<span class="Apple-converted-space"> </span><span dir="ltr" class=""><<a href="mailto:peter_cooper@apple.com" target="_blank" class="">peter_cooper@apple.com</a>></span><span class="Apple-converted-space"> </span>wrote:<br class=""><blockquote class="gmail_quote" style="margin: 0px 0px 0px 0.8ex; border-left-width: 1px; border-left-color: rgb(204, 204, 204); border-left-style: solid; padding-left: 1ex;"><div style="word-wrap: break-word;" class=""><br class=""><div class=""><span class=""><blockquote type="cite" class=""><div class="">On Apr 7, 2015, at 12:39 PM, Reid Kleckner <<a href="mailto:rnk@google.com" target="_blank" class="">rnk@google.com</a>> wrote:</div><br class=""><div class=""><div dir="ltr" style="font-family: Helvetica; font-size: 12px; font-style: normal; font-variant: normal; font-weight: normal; letter-spacing: normal; line-height: 14px; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; word-spacing: 0px;" class=""><div class="gmail_extra"><div class="gmail_quote">On Tue, Apr 7, 2015 at 12:24 PM, Pete Cooper<span class=""> </span><span dir="ltr" class=""><<a href="mailto:peter_cooper@apple.com" target="_blank" class="">peter_cooper@apple.com</a>></span><span class=""> </span>wrote:<br class=""><blockquote class="gmail_quote" style="margin: 0px 0px 0px 0.8ex; border-left-width: 1px; border-left-color: rgb(204, 204, 204); border-left-style: solid; padding-left: 1ex;"><span class=""><br class="">> On Apr 7, 2015, at 11:46 AM, Justin Bogner <<a href="mailto:mail@justinbogner.com" target="_blank" class="">mail@justinbogner.com</a>> wrote:<br class="">><br class="">> Reid Kleckner <<a href="mailto:rnk@google.com" target="_blank" class="">rnk@google.com</a>> writes:<br class="">>> We already do this in llvm::sys::PrintStackTraceOnErrorSignal. You could<br class="">>> setenv("LLVM_DISABLE_CRASH_REPORT", "1") to get this behavior.<br class="">>><br class="">>> Either way is probably fine.<br class="">><br class="">> Sure, but it makes sense to do this unconditionally in the unit tests.<br class="">> Crash reports for unit tests (especially death tests) are never useful.<br class=""></span>How about this as an alternative? It adds a boolean to force crash reporting to be disabled.<br class=""><br class="">Note, I do think all the WIN32 stuff in utils/unittest/UnitTestMain/TestMain.cpp should be moved to PrintStackTraceOnErrorSignal or DisableSystemDialogsOnCrash in Signals.inc, but i don’t have a Windows machine to test that change. If anyone wants to do that in a follow up based on the boolean I’ve added here then that would be great.<br class=""></blockquote><div class=""><br class=""></div><div class="">I think on Windows we don't actually want the boolean, we always want to suppress blocking modal dialogs, no questions asked.<span class="Apple-converted-space"> </span></div></div></div></div></div></blockquote></span>Sounds good. The bool is in a shared header so has to be there on Windows but just unused. You ok with the patch as is?</div></div></blockquote><div class=""><br class=""></div><div class="">Yep, lgtm</div></div></div></div></div></blockquote>Thanks! I appreciate the review. r234353</div><br class=""></body></html>