<p dir="ltr">Thanks Quentin!</p>
<br><div class="gmail_quote">On Thu, Apr 2, 2015, 11:59 AM Quentin Colombet <<a href="mailto:qcolombet@apple.com">qcolombet@apple.com</a>> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Author: qcolombet<br>
Date: Thu Apr  2 13:54:23 2015<br>
New Revision: 233936<br>
<br>
URL: <a href="http://llvm.org/viewvc/llvm-project?rev=233936&view=rev" target="_blank">http://llvm.org/viewvc/llvm-<u></u>project?rev=233936&view=rev</a><br>
Log:<br>
[AArch64] Add a comment to make it explicit why we increased the complexity.<br>
Follow-up of r233653.<br>
<br>
Modified:<br>
    llvm/trunk/lib/Target/AArch64/<u></u>AArch64InstrFormats.td<br>
<br>
Modified: llvm/trunk/lib/Target/AArch64/<u></u>AArch64InstrFormats.td<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Target/AArch64/AArch64InstrFormats.td?rev=233936&r1=233935&r2=233936&view=diff" target="_blank">http://llvm.org/viewvc/llvm-<u></u>project/llvm/trunk/lib/Target/<u></u>AArch64/AArch64InstrFormats.<u></u>td?rev=233936&r1=233935&r2=<u></u>233936&view=diff</a><br>
==============================<u></u>==============================<u></u>==================<br>
--- llvm/trunk/lib/Target/AArch64/<u></u>AArch64InstrFormats.td (original)<br>
+++ llvm/trunk/lib/Target/AArch64/<u></u>AArch64InstrFormats.td Thu Apr  2 13:54:23 2015<br>
@@ -1637,6 +1637,10 @@ multiclass AddSub<bit isSub, string mnem<br>
                   SDPatternOperator OpNode = null_frag> {<br>
   let hasSideEffects = 0, isReMaterializable = 1, isAsCheapAsAMove = 1 in {<br>
   // Add/Subtract immediate<br>
+  // Increase the weight of the immediate variant to try to match it before<br>
+  // the extended register variant.<br>
+  // We used to match the register variant before the immediate when the<br>
+  // register argument could be implicitly zero-extended.<br>
   let AddedComplexity = 6 in<br>
   def Wri  : BaseAddSubImm<isSub, 0, GPR32sp, GPR32sp, addsub_shifted_imm32,<br>
                            mnemonic, OpNode> {<br>
<br>
<br>
______________________________<u></u>_________________<br>
llvm-commits mailing list<br>
<a href="mailto:llvm-commits@cs.uiuc.edu" target="_blank">llvm-commits@cs.uiuc.edu</a><br>
<a href="http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits" target="_blank">http://lists.cs.uiuc.edu/<u></u>mailman/listinfo/llvm-commits</a><br>
</blockquote></div>