<html><head><meta http-equiv="Content-Type" content="text/html charset=utf-8"></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space;" class=""><br class=""><div><blockquote type="cite" class=""><div class="">On Apr 2, 2015, at 11:05 AM, David Blaikie <<a href="mailto:dblaikie@gmail.com" class="">dblaikie@gmail.com</a>> wrote:</div><br class="Apple-interchange-newline"><div class=""><div dir="ltr" class="">Test case? Or is this just a perf improvement?</div></div></blockquote><div><br class=""></div><div>No it’s a bug fix because without this check we will use the null MemoryRuntimeCheck later. </div><div><br class=""></div><div>There should be a way to come up with a testcase even without Loop Distribution but it should be much easier with Loop Distribution. Let me add a testcase for this as part of the LDist patch. OK?</div><div><br class=""></div><div>Adam</div><br class=""><blockquote type="cite" class=""><div class=""><div class="gmail_extra"><div class="gmail_quote">On Thu, Apr 2, 2015 at 10:51 AM, Adam Nemet <span dir="ltr" class=""><<a href="mailto:anemet@apple.com" target="_blank" class="">anemet@apple.com</a>></span> wrote:<br class=""><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Author: anemet<br class="">
Date: Thu Apr 2 12:51:57 2015<br class="">
New Revision: 233930<br class="">
<br class="">
URL: <a href="http://llvm.org/viewvc/llvm-project?rev=233930&view=rev" target="_blank" class="">http://llvm.org/viewvc/llvm-project?rev=233930&view=rev</a><br class="">
Log:<br class="">
[LoopAccesses] Handle case when no memchecks are needed after partitioning<br class="">
<br class="">
Modified:<br class="">
llvm/trunk/lib/Analysis/LoopAccessAnalysis.cpp<br class="">
<br class="">
Modified: llvm/trunk/lib/Analysis/LoopAccessAnalysis.cpp<br class="">
URL: <a href="http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Analysis/LoopAccessAnalysis.cpp?rev=233930&r1=233929&r2=233930&view=diff" target="_blank" class="">http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Analysis/LoopAccessAnalysis.cpp?rev=233930&r1=233929&r2=233930&view=diff</a><br class="">
==============================================================================<br class="">
--- llvm/trunk/lib/Analysis/LoopAccessAnalysis.cpp (original)<br class="">
+++ llvm/trunk/lib/Analysis/LoopAccessAnalysis.cpp Thu Apr 2 12:51:57 2015<br class="">
@@ -1211,9 +1211,8 @@ static Instruction *getFirstInst(Instruc<br class="">
<br class="">
std::pair<Instruction *, Instruction *> LoopAccessInfo::addRuntimeCheck(<br class="">
Instruction *Loc, const SmallVectorImpl<int> *PtrPartition) const {<br class="">
- Instruction *tnullptr = nullptr;<br class="">
if (!PtrRtCheck.Need)<br class="">
- return std::pair<Instruction *, Instruction *>(tnullptr, tnullptr);<br class="">
+ return std::make_pair(nullptr, nullptr);<br class="">
<br class="">
unsigned NumPointers = PtrRtCheck.Pointers.size();<br class="">
SmallVector<TrackingVH<Value> , 2> Starts;<br class="">
@@ -1284,6 +1283,9 @@ std::pair<Instruction *, Instruction *><br class="">
}<br class="">
}<br class="">
<br class="">
+ if (!MemoryRuntimeCheck)<br class="">
+ return std::make_pair(nullptr, nullptr);<br class="">
+<br class="">
// We have to do this trickery because the IRBuilder might fold the check to a<br class="">
// constant expression in which case there is no Instruction anchored in a<br class="">
// the block.<br class="">
<br class="">
<br class="">
_______________________________________________<br class="">
llvm-commits mailing list<br class="">
<a href="mailto:llvm-commits@cs.uiuc.edu" class="">llvm-commits@cs.uiuc.edu</a><br class="">
<a href="http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits" target="_blank" class="">http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits</a><br class="">
</blockquote></div><br class=""></div>
</div></blockquote></div><br class=""></body></html>