<div dir="ltr"><br><div class="gmail_extra"><br><div class="gmail_quote">On Mon, Mar 30, 2015 at 10:04 AM, Duncan P. N. Exon Smith <span dir="ltr"><<a href="mailto:dexonsmith@apple.com" target="_blank">dexonsmith@apple.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Author: dexonsmith<br>
Date: Mon Mar 30 12:04:06 2015<br>
New Revision: 233562<br>
<br>
URL: <a href="http://llvm.org/viewvc/llvm-project?rev=233562&view=rev" target="_blank">http://llvm.org/viewvc/llvm-project?rev=233562&view=rev</a><br>
Log:<br>
Verifier: Loosen r233559 check for 'function:' field in MDSubprogram<br>
<br>
Stop worrying about what the `function:` field is in `MDSubprogram`,<br>
since it could be a bitcast [1].  Just check its type and leave it at<br>
that.<br>
<br>
[1]: <a href="http://lab.llvm.org:8080/green/job/clang-stage2-configure-Rlto_build/3540/" target="_blank">http://lab.llvm.org:8080/green/job/clang-stage2-configure-Rlto_build/3540/</a></blockquote><div><br>Is this an acceptable thing? How does this arise? Could we have a small test case demonstrating it? (and/or demonstrating how it comes about?)<br> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><br>
<br>
Modified:<br>
    llvm/trunk/lib/IR/Verifier.cpp<br>
<br>
Modified: llvm/trunk/lib/IR/Verifier.cpp<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/IR/Verifier.cpp?rev=233562&r1=233561&r2=233562&view=diff" target="_blank">http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/IR/Verifier.cpp?rev=233562&r1=233561&r2=233562&view=diff</a><br>
==============================================================================<br>
--- llvm/trunk/lib/IR/Verifier.cpp (original)<br>
+++ llvm/trunk/lib/IR/Verifier.cpp Mon Mar 30 12:04:06 2015<br>
@@ -846,9 +846,8 @@ void Verifier::visitMDSubprogram(const M<br>
     auto *FMD = dyn_cast<ConstantAsMetadata>(RawF);<br>
     auto *F = FMD ? FMD->getValue() : nullptr;<br>
     auto *FT = F ? dyn_cast<PointerType>(F->getType()) : nullptr;<br>
-    Assert(F && (isa<Function>(F) || isa<ConstantPointerNull>(F)) && FT &&<br>
-               isa<FunctionType>(FT->getElementType()),<br>
-           "invalid function", &N, F);<br>
+    Assert(F && FT && isa<FunctionType>(FT->getElementType()),<br>
+           "invalid function", &N, F, FT);<br>
   }<br>
   if (N.getRawTemplateParams()) {<br>
     auto *Params = dyn_cast<MDTuple>(N.getRawTemplateParams());<br>
<br>
<br>
_______________________________________________<br>
llvm-commits mailing list<br>
<a href="mailto:llvm-commits@cs.uiuc.edu">llvm-commits@cs.uiuc.edu</a><br>
<a href="http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits" target="_blank">http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits</a><br>
</blockquote></div><br></div></div>