<div dir="ltr"><div class="gmail_extra"><div class="gmail_quote">On Fri, Mar 27, 2015 at 6:06 PM, Sean Silva <span dir="ltr"><<a href="mailto:chisophugis@gmail.com" target="_blank">chisophugis@gmail.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr"><br><div class="gmail_extra"><br><div class="gmail_quote"><span class="">On Fri, Mar 27, 2015 at 12:33 PM, Rui Ueyama <span dir="ltr"><<a href="mailto:ruiu@google.com" target="_blank">ruiu@google.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Author: ruiu<br>
Date: Fri Mar 27 14:33:05 2015<br>
New Revision: 233401<br>
<br>
URL: <a href="http://llvm.org/viewvc/llvm-project?rev=233401&view=rev" target="_blank">http://llvm.org/viewvc/llvm-project?rev=233401&view=rev</a><br>
Log:<br>
Rename all caps class names.<br>
<br>
We have GOTAtom and PLTAtom classes because GOT or PLT are acronyms.<br>
"Dynamic offset table" or "dynamic" are not acronyms.<br></blockquote><div><br></div></span><div>They are the names of the symbols though, right? E.g. DYNAMICAtom is not just a "dynamic atom" it is the atom for _DYNAMIC.</div></div></div></div></blockquote><div><br></div><div>Yes they are. You prefer DYNAMICAtom over DynamicAtom?</div><div> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr"><div class="gmail_extra"><div class="gmail_quote"><span class="HOEnZb"><font color="#888888"><div><br></div><div>-- Sean Silva</div></font></span><div><div class="h5"><div> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<br>
Modified:<br>
    lld/trunk/lib/ReaderWriter/ELF/AArch64/AArch64DynamicLibraryWriter.h<br>
    lld/trunk/lib/ReaderWriter/ELF/AArch64/AArch64ExecutableWriter.h<br>
    lld/trunk/lib/ReaderWriter/ELF/Atoms.h<br>
    lld/trunk/lib/ReaderWriter/ELF/X86/X86DynamicLibraryWriter.h<br>
    lld/trunk/lib/ReaderWriter/ELF/X86_64/X86_64DynamicLibraryWriter.h<br>
    lld/trunk/lib/ReaderWriter/ELF/X86_64/X86_64ExecutableWriter.h<br>
<br>
Modified: lld/trunk/lib/ReaderWriter/ELF/AArch64/AArch64DynamicLibraryWriter.h<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/lld/trunk/lib/ReaderWriter/ELF/AArch64/AArch64DynamicLibraryWriter.h?rev=233401&r1=233400&r2=233401&view=diff" target="_blank">http://llvm.org/viewvc/llvm-project/lld/trunk/lib/ReaderWriter/ELF/AArch64/AArch64DynamicLibraryWriter.h?rev=233401&r1=233400&r2=233401&view=diff</a><br>
==============================================================================<br>
--- lld/trunk/lib/ReaderWriter/ELF/AArch64/AArch64DynamicLibraryWriter.h (original)<br>
+++ lld/trunk/lib/ReaderWriter/ELF/AArch64/AArch64DynamicLibraryWriter.h Fri Mar 27 14:33:05 2015<br>
@@ -56,8 +56,8 @@ template <class ELFT><br>
 bool AArch64DynamicLibraryWriter<ELFT>::createImplicitFiles(<br>
     std::vector<std::unique_ptr<File>> &result) {<br>
   DynamicLibraryWriter<ELFT>::createImplicitFiles(result);<br>
-  _gotFile->addAtom(*new (_gotFile->_alloc) GLOBAL_OFFSET_TABLEAtom(*_gotFile));<br>
-  _gotFile->addAtom(*new (_gotFile->_alloc) DYNAMICAtom(*_gotFile));<br>
+  _gotFile->addAtom(*new (_gotFile->_alloc) GlobalOffsetTableAtom(*_gotFile));<br>
+  _gotFile->addAtom(*new (_gotFile->_alloc) DynamicAtom(*_gotFile));<br>
   result.push_back(std::move(_gotFile));<br>
   return true;<br>
 }<br>
<br>
Modified: lld/trunk/lib/ReaderWriter/ELF/AArch64/AArch64ExecutableWriter.h<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/lld/trunk/lib/ReaderWriter/ELF/AArch64/AArch64ExecutableWriter.h?rev=233401&r1=233400&r2=233401&view=diff" target="_blank">http://llvm.org/viewvc/llvm-project/lld/trunk/lib/ReaderWriter/ELF/AArch64/AArch64ExecutableWriter.h?rev=233401&r1=233400&r2=233401&view=diff</a><br>
==============================================================================<br>
--- lld/trunk/lib/ReaderWriter/ELF/AArch64/AArch64ExecutableWriter.h (original)<br>
+++ lld/trunk/lib/ReaderWriter/ELF/AArch64/AArch64ExecutableWriter.h Fri Mar 27 14:33:05 2015<br>
@@ -55,9 +55,9 @@ template <class ELFT><br>
 bool AArch64ExecutableWriter<ELFT>::createImplicitFiles(<br>
     std::vector<std::unique_ptr<File>> &result) {<br>
   ExecutableWriter<ELFT>::createImplicitFiles(result);<br>
-  _gotFile->addAtom(*new (_gotFile->_alloc) GLOBAL_OFFSET_TABLEAtom(*_gotFile));<br>
+  _gotFile->addAtom(*new (_gotFile->_alloc) GlobalOffsetTableAtom(*_gotFile));<br>
   if (_ctx.isDynamic())<br>
-    _gotFile->addAtom(*new (_gotFile->_alloc) DYNAMICAtom(*_gotFile));<br>
+    _gotFile->addAtom(*new (_gotFile->_alloc) DynamicAtom(*_gotFile));<br>
   result.push_back(std::move(_gotFile));<br>
   return true;<br>
 }<br>
<br>
Modified: lld/trunk/lib/ReaderWriter/ELF/Atoms.h<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/lld/trunk/lib/ReaderWriter/ELF/Atoms.h?rev=233401&r1=233400&r2=233401&view=diff" target="_blank">http://llvm.org/viewvc/llvm-project/lld/trunk/lib/ReaderWriter/ELF/Atoms.h?rev=233401&r1=233400&r2=233401&view=diff</a><br>
==============================================================================<br>
--- lld/trunk/lib/ReaderWriter/ELF/Atoms.h (original)<br>
+++ lld/trunk/lib/ReaderWriter/ELF/Atoms.h Fri Mar 27 14:33:05 2015<br>
@@ -781,9 +781,9 @@ public:<br>
   }<br>
 };<br>
<br>
-class GLOBAL_OFFSET_TABLEAtom : public SimpleELFDefinedAtom {<br>
+class GlobalOffsetTableAtom : public SimpleELFDefinedAtom {<br>
 public:<br>
-  GLOBAL_OFFSET_TABLEAtom(const File &f) : SimpleELFDefinedAtom(f) {}<br>
+  GlobalOffsetTableAtom(const File &f) : SimpleELFDefinedAtom(f) {}<br>
<br>
   StringRef name() const override { return "_GLOBAL_OFFSET_TABLE_"; }<br>
<br>
@@ -804,9 +804,9 @@ public:<br>
   ArrayRef<uint8_t> rawContent() const override { return ArrayRef<uint8_t>(); }<br>
 };<br>
<br>
-class DYNAMICAtom : public SimpleELFDefinedAtom {<br>
+class DynamicAtom : public SimpleELFDefinedAtom {<br>
 public:<br>
-  DYNAMICAtom(const File &f) : SimpleELFDefinedAtom(f) {}<br>
+  DynamicAtom(const File &f) : SimpleELFDefinedAtom(f) {}<br>
<br>
   StringRef name() const override { return "_DYNAMIC"; }<br>
<br>
<br>
Modified: lld/trunk/lib/ReaderWriter/ELF/X86/X86DynamicLibraryWriter.h<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/lld/trunk/lib/ReaderWriter/ELF/X86/X86DynamicLibraryWriter.h?rev=233401&r1=233400&r2=233401&view=diff" target="_blank">http://llvm.org/viewvc/llvm-project/lld/trunk/lib/ReaderWriter/ELF/X86/X86DynamicLibraryWriter.h?rev=233401&r1=233400&r2=233401&view=diff</a><br>
==============================================================================<br>
--- lld/trunk/lib/ReaderWriter/ELF/X86/X86DynamicLibraryWriter.h (original)<br>
+++ lld/trunk/lib/ReaderWriter/ELF/X86/X86DynamicLibraryWriter.h Fri Mar 27 14:33:05 2015<br>
@@ -55,8 +55,8 @@ template <class ELFT><br>
 bool X86DynamicLibraryWriter<ELFT>::createImplicitFiles(<br>
     std::vector<std::unique_ptr<File>> &result) {<br>
   DynamicLibraryWriter<ELFT>::createImplicitFiles(result);<br>
-  _gotFile->addAtom(*new (_gotFile->_alloc) GLOBAL_OFFSET_TABLEAtom(*_gotFile));<br>
-  _gotFile->addAtom(*new (_gotFile->_alloc) DYNAMICAtom(*_gotFile));<br>
+  _gotFile->addAtom(*new (_gotFile->_alloc) GlobalOffsetTableAtom(*_gotFile));<br>
+  _gotFile->addAtom(*new (_gotFile->_alloc) DynamicAtom(*_gotFile));<br>
   result.push_back(std::move(_gotFile));<br>
   return true;<br>
 }<br>
<br>
Modified: lld/trunk/lib/ReaderWriter/ELF/X86_64/X86_64DynamicLibraryWriter.h<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/lld/trunk/lib/ReaderWriter/ELF/X86_64/X86_64DynamicLibraryWriter.h?rev=233401&r1=233400&r2=233401&view=diff" target="_blank">http://llvm.org/viewvc/llvm-project/lld/trunk/lib/ReaderWriter/ELF/X86_64/X86_64DynamicLibraryWriter.h?rev=233401&r1=233400&r2=233401&view=diff</a><br>
==============================================================================<br>
--- lld/trunk/lib/ReaderWriter/ELF/X86_64/X86_64DynamicLibraryWriter.h (original)<br>
+++ lld/trunk/lib/ReaderWriter/ELF/X86_64/X86_64DynamicLibraryWriter.h Fri Mar 27 14:33:05 2015<br>
@@ -51,8 +51,8 @@ X86_64DynamicLibraryWriter::X86_64Dynami<br>
 bool X86_64DynamicLibraryWriter::createImplicitFiles(<br>
     std::vector<std::unique_ptr<File>> &result) {<br>
   DynamicLibraryWriter::createImplicitFiles(result);<br>
-  _gotFile->addAtom(*new (_gotFile->_alloc) GLOBAL_OFFSET_TABLEAtom(*_gotFile));<br>
-  _gotFile->addAtom(*new (_gotFile->_alloc) DYNAMICAtom(*_gotFile));<br>
+  _gotFile->addAtom(*new (_gotFile->_alloc) GlobalOffsetTableAtom(*_gotFile));<br>
+  _gotFile->addAtom(*new (_gotFile->_alloc) DynamicAtom(*_gotFile));<br>
   result.push_back(std::move(_gotFile));<br>
   return true;<br>
 }<br>
<br>
Modified: lld/trunk/lib/ReaderWriter/ELF/X86_64/X86_64ExecutableWriter.h<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/lld/trunk/lib/ReaderWriter/ELF/X86_64/X86_64ExecutableWriter.h?rev=233401&r1=233400&r2=233401&view=diff" target="_blank">http://llvm.org/viewvc/llvm-project/lld/trunk/lib/ReaderWriter/ELF/X86_64/X86_64ExecutableWriter.h?rev=233401&r1=233400&r2=233401&view=diff</a><br>
==============================================================================<br>
--- lld/trunk/lib/ReaderWriter/ELF/X86_64/X86_64ExecutableWriter.h (original)<br>
+++ lld/trunk/lib/ReaderWriter/ELF/X86_64/X86_64ExecutableWriter.h Fri Mar 27 14:33:05 2015<br>
@@ -27,9 +27,9 @@ protected:<br>
   createImplicitFiles(std::vector<std::unique_ptr<File>> &result) {<br>
     ExecutableWriter::createImplicitFiles(result);<br>
     _gotFile->addAtom(*new (_gotFile->_alloc)<br>
-                      GLOBAL_OFFSET_TABLEAtom(*_gotFile));<br>
+                      GlobalOffsetTableAtom(*_gotFile));<br>
     if (_ctx.isDynamic())<br>
-      _gotFile->addAtom(*new (_gotFile->_alloc) DYNAMICAtom(*_gotFile));<br>
+      _gotFile->addAtom(*new (_gotFile->_alloc) DynamicAtom(*_gotFile));<br>
     result.push_back(std::move(_gotFile));<br>
     return true;<br>
   }<br>
<br>
<br>
_______________________________________________<br>
llvm-commits mailing list<br>
<a href="mailto:llvm-commits@cs.uiuc.edu" target="_blank">llvm-commits@cs.uiuc.edu</a><br>
<a href="http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits" target="_blank">http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits</a><br>
</blockquote></div></div></div><br></div></div>
</blockquote></div><br></div></div>