<div dir="ltr">Makes sense to me.</div><div class="gmail_extra"><br><div class="gmail_quote">On Wed, Mar 25, 2015 at 3:55 PM, Yung, Douglas <span dir="ltr"><<a href="mailto:douglas_yung@playstation.sony.com" target="_blank">douglas_yung@playstation.sony.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">





<div lang="EN-US" link="blue" vlink="purple">
<div>
<p class="MsoNormal"><span style="color:#1f497d">Hi, I just wanted to resend this and was hoping to get someone to review my small change. Thanks!<u></u><u></u></span></p>
<p class="MsoNormal"><span style="color:#1f497d"><u></u> <u></u></span></p>
<p class="MsoNormal"><span style="color:#1f497d">Douglas Yung<u></u><u></u></span></p>
<p class="MsoNormal"><span style="color:#1f497d"><u></u> <u></u></span></p>
<div>
<div style="border:none;border-top:solid #b5c4df 1.0pt;padding:3.0pt 0in 0in 0in">
<p class="MsoNormal"><b><span style="font-size:10.0pt;font-family:"Tahoma","sans-serif"">From:</span></b><span style="font-size:10.0pt;font-family:"Tahoma","sans-serif""> Yung, Douglas
<br>
<b>Sent:</b> Thursday, March 19, 2015 1:20<br>
<b>To:</b> <a href="mailto:llvm-commits@cs.uiuc.edu" target="_blank">llvm-commits@cs.uiuc.edu</a><br>
<b>Subject:</b> [PATCH] Allow compile_commands.json files in subdirectories<u></u><u></u></span></p>
</div>
</div><div><div class="h5">
<p class="MsoNormal"><u></u> <u></u></p>
<p class="MsoNormal"><span style="font-size:10.0pt">Hi,</span> <br>
<span style="font-size:10.0pt"> </span> <br>
<span style="font-size:10.0pt">In the top-level .gitignore file of the llvm project, there is an entry in the .gitignore file to ignore the file compile_commands.json. This was added by David Blaikie in 162305 to ignore the compile_commands.json that may be
 present at the root of the LLVM source tree. The problem with how it was done though is that it is excluding compile_commands.json files anywhere in the LLVM source tree. In our case, we included the clang extra user tools in our repository under tools/clang/tools/extra,
 which contains 3 instances of the file compile_commands.json under tools/clang/tools/extra which were being ignored causing tests to fail due to this missing file. The proposed fix as seen below is to simply restrict the ignoring of compile_commands.json to
 an instance at the root of the LLVM source tree.<u></u><u></u></span></p>
<p class="MsoNormal"><span style="font-size:10.0pt"><u></u> <u></u></span></p>
<p class="MsoNormal" style="margin-bottom:12.0pt"><span style="font-size:10.0pt">Douglas Yung</span><br>
<br>
<span style="font-size:10.0pt;font-family:Consolas">Files:</span> <br>
<span style="font-size:10.0pt;font-family:Consolas">  .gitignore</span> <br>
<span style="font-size:10.0pt;font-family:Consolas"> </span> <br>
<span style="font-size:10.0pt;font-family:Consolas">Index: .gitignore</span> <br>
<span style="font-size:10.0pt;font-family:Consolas">===================================================================</span>
<br>
<span style="font-size:10.0pt;font-family:Consolas">--- .gitignore    (revision 232698)</span>
<br>
<span style="font-size:10.0pt;font-family:Consolas">+++ .gitignore    (working copy)</span>
<br>
<span style="font-size:10.0pt;font-family:Consolas">@@ -37,7 +37,7 @@</span> <br>
<span style="font-size:10.0pt;font-family:Consolas">cscope.out</span> <br>
<span style="font-size:10.0pt;font-family:Consolas">autoconf/aclocal.m4</span> <br>
<span style="font-size:10.0pt;font-family:Consolas">autoconf/autom4te.cache</span>
<br>
<span style="font-size:10.0pt;font-family:Consolas">-compile_commands.json</span>
<br>
<span style="font-size:10.0pt;font-family:Consolas">+/compile_commands.json</span>
<br>
<span style="font-size:10.0pt;font-family:Consolas"> </span> <br>
<span style="font-size:10.0pt;font-family:Consolas"> #==============================================================================#</span>
<br>
<span style="font-size:10.0pt;font-family:Consolas"># Directories to ignore (do not add trailing '/'s, they skip symlinks).</span>
<u></u><u></u></p>
</div></div></div>
</div>

<br>_______________________________________________<br>
llvm-commits mailing list<br>
<a href="mailto:llvm-commits@cs.uiuc.edu">llvm-commits@cs.uiuc.edu</a><br>
<a href="http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits" target="_blank">http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits</a><br>
<br></blockquote></div><br></div>