<div dir="ltr"><br><br><div class="gmail_quote">On Wed, Mar 25, 2015 at 1:14 PM Krzysztof Parzyszek <<a href="mailto:kparzysz@codeaurora.org">kparzysz@codeaurora.org</a>> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">We use it in many places in our local code (the one that is not yet<br>
upstreamed).  We regularly integrate the changes from <a href="http://llvm.org" target="_blank">llvm.org</a> and<br>
removing the bare subtarget function would make this integration very<br>
painful. I added it back for now until we get the migration done. We do<br>
plan to upstream our code, but the efforts are only now getting more<br>
traction.<br>
<br></blockquote><div><br></div><div>You should just keep it internal as a separate patch then for now. It's only a couple of lines and there's no reason for it to be in ToT as it's dead code (and causes problems in patches you're trying to upstream, see my response on your other code review).</div><div><br></div><div>Thanks.</div><div><br></div><div>-eric</div><div> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
-Krzysztof<br>
<br>
<br>
On 3/25/2015 2:59 PM, Eric Christopher wrote:<br>
> Why? You don't use it.<br>
><br>
> -eric<br>
><br>
> On Wed, Mar 25, 2015 at 12:56 PM Krzysztof Parzyszek<br>
> <<a href="mailto:kparzysz@codeaurora.org" target="_blank">kparzysz@codeaurora.org</a> <mailto:<a href="mailto:kparzysz@codeaurora.org" target="_blank">kparzysz@codeaurora.<u></u>org</a>>> wrote:<br>
><br>
>     Author: kparzysz<br>
>     Date: Wed Mar 25 14:51:52 2015<br>
>     New Revision: 233206<br>
><br>
>     URL: <a href="http://llvm.org/viewvc/llvm-__project?rev=233206&view=rev" target="_blank">http://llvm.org/viewvc/llvm-__<u></u>project?rev=233206&view=rev</a><br>
>     <<a href="http://llvm.org/viewvc/llvm-project?rev=233206&view=rev" target="_blank">http://llvm.org/viewvc/llvm-<u></u>project?rev=233206&view=rev</a>><br>
>     Log:<br>
>     [Hexagon] Keep the bare getSubtargetImpl for now<br>
><br>
>     Modified:<br>
>          llvm/trunk/lib/Target/Hexagon/<u></u>__HexagonTargetMachine.h<br>
><br>
>     Modified: llvm/trunk/lib/Target/Hexagon/<u></u>__HexagonTargetMachine.h<br>
>     URL:<br>
>     <a href="http://llvm.org/viewvc/llvm-__project/llvm/trunk/lib/Target/__Hexagon/HexagonTargetMachine.__h?rev=233206&r1=233205&r2=__233206&view=diff" target="_blank">http://llvm.org/viewvc/llvm-__<u></u>project/llvm/trunk/lib/Target/<u></u>__Hexagon/<u></u>HexagonTargetMachine.__h?rev=<u></u>233206&r1=233205&r2=__233206&<u></u>view=diff</a><br>
>     <<a href="http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Target/Hexagon/HexagonTargetMachine.h?rev=233206&r1=233205&r2=233206&view=diff" target="_blank">http://llvm.org/viewvc/llvm-<u></u>project/llvm/trunk/lib/Target/<u></u>Hexagon/HexagonTargetMachine.<u></u>h?rev=233206&r1=233205&r2=<u></u>233206&view=diff</a>><br>
>     ==============================<u></u>__============================<u></u>==__==================<br>
>     --- llvm/trunk/lib/Target/Hexagon/<u></u>__HexagonTargetMachine.h (original)<br>
>     +++ llvm/trunk/lib/Target/Hexagon/<u></u>__HexagonTargetMachine.h Wed Mar<br>
>     25 14:51:52 2015<br>
>     @@ -32,6 +32,9 @@ public:<br>
>                              Reloc::Model RM, CodeModel::Model CM,<br>
>                              CodeGenOpt::Level OL);<br>
>         ~HexagonTargetMachine() override;<br>
>     +  const HexagonSubtarget *getSubtargetImpl() const {<br>
>     +    return &Subtarget;<br>
>     +  }<br>
>         const HexagonSubtarget *getSubtargetImpl(const Function &) const<br>
>     override {<br>
>           return &Subtarget;<br>
>         }<br>
><br>
><br>
>     ______________________________<u></u>___________________<br>
>     llvm-commits mailing list<br>
>     <a href="mailto:llvm-commits@cs.uiuc.edu" target="_blank">llvm-commits@cs.uiuc.edu</a> <mailto:<a href="mailto:llvm-commits@cs.uiuc.edu" target="_blank">llvm-commits@cs.uiuc.<u></u>edu</a>><br>
>     <a href="http://lists.cs.uiuc.edu/__mailman/listinfo/llvm-commits" target="_blank">http://lists.cs.uiuc.edu/__<u></u>mailman/listinfo/llvm-commits</a><br>
>     <<a href="http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits" target="_blank">http://lists.cs.uiuc.edu/<u></u>mailman/listinfo/llvm-commits</a>><br>
><br>
<br>
<br>
--<br>
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,<br>
hosted by The Linux Foundation<br>
</blockquote></div></div>