<div dir="ltr">Some IR test cases might be nice to have here, to avoid regressing this functionality.</div><div class="gmail_extra"><br><div class="gmail_quote">On Tue, Mar 24, 2015 at 1:42 PM, Peter Collingbourne <span dir="ltr"><<a href="mailto:peter@pcc.me.uk" target="_blank">peter@pcc.me.uk</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Hi dexonsmith,<br>
<br>
Some languages, such as Go, have pre-defined structure types (e.g. "string"<br>
is essentially a pointer/length pair) or pre-defined "typedef" types<br>
(e.g. "error" is essentially a typedef for a specific interface type).<br>
Such types do not have associated source location, so a Go frontend would<br>
be correct not to associate a file name with such types.<br>
<br>
This change relaxes the DIType verifier to permit unlocated types with<br>
these tags.<br>
<br>
<a href="http://reviews.llvm.org/D8588" target="_blank">http://reviews.llvm.org/D8588</a><br>
<br>
Files:<br>
  lib/IR/DebugInfo.cpp<br>
<br>
Index: lib/IR/DebugInfo.cpp<br>
===================================================================<br>
--- lib/IR/DebugInfo.cpp<br>
+++ lib/IR/DebugInfo.cpp<br>
@@ -283,7 +283,9 @@<br>
         Tag != dwarf::DW_TAG_restrict_type && Tag != dwarf::DW_TAG_array_type &&<br>
         Tag != dwarf::DW_TAG_enumeration_type &&<br>
         Tag != dwarf::DW_TAG_subroutine_type &&<br>
-        Tag != dwarf::DW_TAG_inheritance && Tag != dwarf::DW_TAG_friend)<br>
+        Tag != dwarf::DW_TAG_inheritance && Tag != dwarf::DW_TAG_friend &&<br>
+        Tag != dwarf::DW_TAG_structure_type && Tag != dwarf::DW_TAG_member &&<br>
+        Tag != dwarf::DW_TAG_typedef)<br>
       return false;<br>
   }<br>
<br>
EMAIL PREFERENCES<br>
  <a href="http://reviews.llvm.org/settings/panel/emailpreferences/" target="_blank">http://reviews.llvm.org/settings/panel/emailpreferences/</a><br>
<br>_______________________________________________<br>
llvm-commits mailing list<br>
<a href="mailto:llvm-commits@cs.uiuc.edu">llvm-commits@cs.uiuc.edu</a><br>
<a href="http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits" target="_blank">http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits</a><br>
<br></blockquote></div><br></div>