<div dir="ltr">Looks good - committed in r233005</div><div class="gmail_extra"><br><div class="gmail_quote">On Sun, Mar 22, 2015 at 1:08 PM, Richard <span dir="ltr"><<a href="mailto:legalize@xmission.com" target="_blank">legalize@xmission.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Hi alexfh, dexonsmith, void, rafael, dblaikie, chandlerc,<br>
<br>
Simplify boolean expressions using `true` and `false` with `clang-tidy`<br>
<br>
<a href="http://reviews.llvm.org/D8527" target="_blank">http://reviews.llvm.org/D8527</a><br>
<br>
Files:<br>
  lib/IR/Instructions.cpp<br>
<br>
Index: lib/IR/Instructions.cpp<br>
===================================================================<br>
--- lib/IR/Instructions.cpp<br>
+++ lib/IR/Instructions.cpp<br>
@@ -2553,11 +2553,8 @@<br>
   } else if (DestTy->isPointerTy()) {        // Casting to pointer<br>
     if (SrcTy->isPointerTy()) {                // Casting from pointer<br>
       return true;<br>
-    } else if (SrcTy->isIntegerTy()) {         // Casting from integral<br>
-      return true;<br>
-    } else {                                   // Casting from something else<br>
-      return false;<br>
-    }<br>
+    } else<br>
+      return SrcTy->isIntegerTy();             // Casting from integral<br>
   } else if (DestTy->isX86_MMXTy()) {<br>
     if (SrcTy->isVectorTy()) {<br>
       return DestBits == SrcBits;       // 64-bit vector to MMX<br>
<br>
EMAIL PREFERENCES<br>
  <a href="http://reviews.llvm.org/settings/panel/emailpreferences/" target="_blank">http://reviews.llvm.org/settings/panel/emailpreferences/</a><br>
</blockquote></div><br></div>