<div dir="ltr">Looks good. Thanks Ahmed!<br><br><div>-eric</div></div><br><div class="gmail_quote">On Mon, Mar 23, 2015 at 2:25 PM Ahmed Bougacha <<a href="mailto:ahmed.bougacha@gmail.com">ahmed.bougacha@gmail.com</a>> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Author: ab<br>
Date: Mon Mar 23 16:17:36 2015<br>
New Revision: 233024<br>
<br>
URL: <a href="http://llvm.org/viewvc/llvm-project?rev=233024&view=rev" target="_blank">http://llvm.org/viewvc/llvm-<u></u>project?rev=233024&view=rev</a><br>
Log:<br>
[AArch64, ARM] Enable GlobalMerge with -O3 rather than -O1.<br>
<br>
The pass used to be enabled by default with CodeGenOpt::Less (-O1).<br>
This is too aggressive, considering the pass indiscriminately merges<br>
all globals together.<br>
<br>
Currently, performance doesn't always improve, and, on code that uses<br>
few globals (e.g., the odd file- or function- static), more often than<br>
not is degraded by the optimization. Lengthy discussion can be found<br>
on llvmdev (AArch64-focused; ARM has similar problems):<br>
<a href="http://lists.cs.uiuc.edu/pipermail/llvmdev/2015-February/082800.html" target="_blank">http://lists.cs.uiuc.edu/<u></u>pipermail/llvmdev/2015-<u></u>February/082800.html</a><br>
Also, it makes tooling and debuggers less useful when dealing with<br>
globals and data sections.<br>
<br>
GlobalMerge needs to better identify those cases that benefit, and this<br>
will be done separately. In the meantime, move the pass to run with<br>
-O3 rather than -O1, on both ARM and AArch64.<br>
<br>
Modified:<br>
llvm/trunk/lib/Target/AArch64/<u></u>AArch64TargetMachine.cpp<br>
llvm/trunk/lib/Target/ARM/<u></u>ARMTargetMachine.cpp<br>
llvm/trunk/test/CodeGen/<u></u>AArch64/global-merge-1.ll<br>
llvm/trunk/test/CodeGen/<u></u>AArch64/global-merge-2.ll<br>
llvm/trunk/test/CodeGen/<u></u>AArch64/global-merge-3.ll<br>
llvm/trunk/test/CodeGen/<u></u>AArch64/global-merge-4.ll<br>
llvm/trunk/test/CodeGen/ARM/<u></u>2010-12-15-elf-lcomm.ll<br>
llvm/trunk/test/CodeGen/ARM/<u></u>2011-01-19-MergedGlobalDbg.ll<br>
llvm/trunk/test/CodeGen/ARM/<u></u>2011-06-29-MergeGlobalsAlign.<u></u>ll<br>
llvm/trunk/test/CodeGen/ARM/<u></u>2011-08-02-MergedGlobalDbg.ll<br>
llvm/trunk/test/CodeGen/ARM/<u></u>global-merge-1.ll<br>
llvm/trunk/test/CodeGen/ARM/<u></u>global-merge-addrspace.ll<br>
llvm/trunk/test/CodeGen/ARM/<u></u>global-merge.ll<br>
<br>
Modified: llvm/trunk/lib/Target/AArch64/<u></u>AArch64TargetMachine.cpp<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Target/AArch64/AArch64TargetMachine.cpp?rev=233024&r1=233023&r2=233024&view=diff" target="_blank">http://llvm.org/viewvc/llvm-<u></u>project/llvm/trunk/lib/Target/<u></u>AArch64/AArch64TargetMachine.<u></u>cpp?rev=233024&r1=233023&r2=<u></u>233024&view=diff</a><br>
==============================<u></u>==============================<u></u>==================<br>
--- llvm/trunk/lib/Target/AArch64/<u></u>AArch64TargetMachine.cpp (original)<br>
+++ llvm/trunk/lib/Target/AArch64/<u></u>AArch64TargetMachine.cpp Mon Mar 23 16:17:36 2015<br>
@@ -245,7 +245,7 @@ bool AArch64PassConfig::addPreISel(<u></u>) {<br>
// FIXME: On AArch64, this depends on the type.<br>
// Basically, the addressable offsets are up to 4095 * Ty.getSizeInBytes().<br>
// and the offset has to be a multiple of the related size in bytes.<br>
- if (TM->getOptLevel() != CodeGenOpt::None)<br>
+ if (TM->getOptLevel() == CodeGenOpt::Aggressive)<br>
addPass(createGlobalMergePass(<u></u>TM, 4095));<br>
if (TM->getOptLevel() != CodeGenOpt::None)<br>
addPass(<u></u>createAArch64AddressTypePromot<u></u>ionPass());<br>
<br>
Modified: llvm/trunk/lib/Target/ARM/<u></u>ARMTargetMachine.cpp<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Target/ARM/ARMTargetMachine.cpp?rev=233024&r1=233023&r2=233024&view=diff" target="_blank">http://llvm.org/viewvc/llvm-<u></u>project/llvm/trunk/lib/Target/<u></u>ARM/ARMTargetMachine.cpp?rev=<u></u>233024&r1=233023&r2=233024&<u></u>view=diff</a><br>
==============================<u></u>==============================<u></u>==================<br>
--- llvm/trunk/lib/Target/ARM/<u></u>ARMTargetMachine.cpp (original)<br>
+++ llvm/trunk/lib/Target/ARM/<u></u>ARMTargetMachine.cpp Mon Mar 23 16:17:36 2015<br>
@@ -327,7 +327,7 @@ void ARMPassConfig::addIRPasses() {<br>
}<br>
<br>
bool ARMPassConfig::addPreISel() {<br>
- if (TM->getOptLevel() != CodeGenOpt::None)<br>
+ if (TM->getOptLevel() == CodeGenOpt::Aggressive)<br>
// FIXME: This is using the thumb1 only constant value for<br>
// maximal global offset for merging globals. We may want<br>
// to look into using the old value for non-thumb1 code of<br>
<br>
Modified: llvm/trunk/test/CodeGen/<u></u>AArch64/global-merge-1.ll<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/llvm/trunk/test/CodeGen/AArch64/global-merge-1.ll?rev=233024&r1=233023&r2=233024&view=diff" target="_blank">http://llvm.org/viewvc/llvm-<u></u>project/llvm/trunk/test/<u></u>CodeGen/AArch64/global-merge-<u></u>1.ll?rev=233024&r1=233023&r2=<u></u>233024&view=diff</a><br>
==============================<u></u>==============================<u></u>==================<br>
--- llvm/trunk/test/CodeGen/<u></u>AArch64/global-merge-1.ll (original)<br>
+++ llvm/trunk/test/CodeGen/<u></u>AArch64/global-merge-1.ll Mon Mar 23 16:17:36 2015<br>
@@ -1,11 +1,11 @@<br>
-; RUN: llc %s -mtriple=aarch64-none-linux-<u></u>gnu -enable-global-merge -o - | FileCheck %s<br>
-; RUN: llc %s -mtriple=aarch64-none-linux-<u></u>gnu -enable-global-merge -global-merge-on-external -o - | FileCheck %s<br>
+; RUN: llc %s -mtriple=aarch64-none-linux-<u></u>gnu -O3 -enable-global-merge -o - | FileCheck %s<br>
+; RUN: llc %s -mtriple=aarch64-none-linux-<u></u>gnu -O3 -enable-global-merge -global-merge-on-external -o - | FileCheck %s<br>
<br>
-; RUN: llc %s -mtriple=aarch64-linux-gnuabi -enable-global-merge -o - | FileCheck %s<br>
-; RUN: llc %s -mtriple=aarch64-linux-gnuabi -enable-global-merge -global-merge-on-external -o - | FileCheck %s<br>
+; RUN: llc %s -mtriple=aarch64-linux-gnuabi -O3 -enable-global-merge -o - | FileCheck %s<br>
+; RUN: llc %s -mtriple=aarch64-linux-gnuabi -O3 -enable-global-merge -global-merge-on-external -o - | FileCheck %s<br>
<br>
-; RUN: llc %s -mtriple=aarch64-apple-ios -enable-global-merge -o - | FileCheck %s --check-prefix=CHECK-APPLE-IOS<br>
-; RUN: llc %s -mtriple=aarch64-apple-ios -enable-global-merge -global-merge-on-external -o - | FileCheck %s --check-prefix=CHECK-APPLE-IOS<br>
+; RUN: llc %s -mtriple=aarch64-apple-ios -O3 -enable-global-merge -o - | FileCheck %s --check-prefix=CHECK-APPLE-IOS<br>
+; RUN: llc %s -mtriple=aarch64-apple-ios -O3 -enable-global-merge -global-merge-on-external -o - | FileCheck %s --check-prefix=CHECK-APPLE-IOS<br>
<br>
@m = internal global i32 0, align 4<br>
@n = internal global i32 0, align 4<br>
<br>
Modified: llvm/trunk/test/CodeGen/<u></u>AArch64/global-merge-2.ll<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/llvm/trunk/test/CodeGen/AArch64/global-merge-2.ll?rev=233024&r1=233023&r2=233024&view=diff" target="_blank">http://llvm.org/viewvc/llvm-<u></u>project/llvm/trunk/test/<u></u>CodeGen/AArch64/global-merge-<u></u>2.ll?rev=233024&r1=233023&r2=<u></u>233024&view=diff</a><br>
==============================<u></u>==============================<u></u>==================<br>
--- llvm/trunk/test/CodeGen/<u></u>AArch64/global-merge-2.ll (original)<br>
+++ llvm/trunk/test/CodeGen/<u></u>AArch64/global-merge-2.ll Mon Mar 23 16:17:36 2015<br>
@@ -1,6 +1,6 @@<br>
-; RUN: llc %s -mtriple=aarch64-none-linux-<u></u>gnu -enable-global-merge -global-merge-on-external -o - | FileCheck %s<br>
-; RUN: llc %s -mtriple=aarch64-linux-gnuabi -enable-global-merge -global-merge-on-external -o - | FileCheck %s<br>
-; RUN: llc %s -mtriple=aarch64-apple-ios -enable-global-merge -global-merge-on-external -o - | FileCheck %s --check-prefix=CHECK-APPLE-IOS<br>
+; RUN: llc %s -mtriple=aarch64-none-linux-<u></u>gnu -O3 -enable-global-merge -global-merge-on-external -o - | FileCheck %s<br>
+; RUN: llc %s -mtriple=aarch64-linux-gnuabi -O3 -enable-global-merge -global-merge-on-external -o - | FileCheck %s<br>
+; RUN: llc %s -mtriple=aarch64-apple-ios -O3 -enable-global-merge -global-merge-on-external -o - | FileCheck %s --check-prefix=CHECK-APPLE-IOS<br>
<br>
@x = global i32 0, align 4<br>
@y = global i32 0, align 4<br>
<br>
Modified: llvm/trunk/test/CodeGen/<u></u>AArch64/global-merge-3.ll<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/llvm/trunk/test/CodeGen/AArch64/global-merge-3.ll?rev=233024&r1=233023&r2=233024&view=diff" target="_blank">http://llvm.org/viewvc/llvm-<u></u>project/llvm/trunk/test/<u></u>CodeGen/AArch64/global-merge-<u></u>3.ll?rev=233024&r1=233023&r2=<u></u>233024&view=diff</a><br>
==============================<u></u>==============================<u></u>==================<br>
--- llvm/trunk/test/CodeGen/<u></u>AArch64/global-merge-3.ll (original)<br>
+++ llvm/trunk/test/CodeGen/<u></u>AArch64/global-merge-3.ll Mon Mar 23 16:17:36 2015<br>
@@ -1,6 +1,6 @@<br>
-; RUN: llc %s -mtriple=aarch64-none-linux-<u></u>gnu -enable-global-merge -global-merge-on-external -o - | FileCheck %s<br>
-; RUN: llc %s -mtriple=aarch64-linux-gnuabi -enable-global-merge -global-merge-on-external -o - | FileCheck %s<br>
-; RUN: llc %s -mtriple=aarch64-apple-ios -enable-global-merge -global-merge-on-external -o - | FileCheck %s --check-prefix=CHECK-APPLE-IOS<br>
+; RUN: llc %s -mtriple=aarch64-none-linux-<u></u>gnu -O3 -enable-global-merge -global-merge-on-external -o - | FileCheck %s<br>
+; RUN: llc %s -mtriple=aarch64-linux-gnuabi -O3 -enable-global-merge -global-merge-on-external -o - | FileCheck %s<br>
+; RUN: llc %s -mtriple=aarch64-apple-ios -O3 -enable-global-merge -global-merge-on-external -o - | FileCheck %s --check-prefix=CHECK-APPLE-IOS<br>
<br>
@x = global [1000 x i32] zeroinitializer, align 1<br>
@y = global [1000 x i32] zeroinitializer, align 1<br>
<br>
Modified: llvm/trunk/test/CodeGen/<u></u>AArch64/global-merge-4.ll<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/llvm/trunk/test/CodeGen/AArch64/global-merge-4.ll?rev=233024&r1=233023&r2=233024&view=diff" target="_blank">http://llvm.org/viewvc/llvm-<u></u>project/llvm/trunk/test/<u></u>CodeGen/AArch64/global-merge-<u></u>4.ll?rev=233024&r1=233023&r2=<u></u>233024&view=diff</a><br>
==============================<u></u>==============================<u></u>==================<br>
--- llvm/trunk/test/CodeGen/<u></u>AArch64/global-merge-4.ll (original)<br>
+++ llvm/trunk/test/CodeGen/<u></u>AArch64/global-merge-4.ll Mon Mar 23 16:17:36 2015<br>
@@ -1,4 +1,4 @@<br>
-; RUN: llc %s -mtriple=aarch64-linux-gnuabi -enable-global-merge -o - | FileCheck %s<br>
+; RUN: llc %s -mtriple=aarch64-linux-gnuabi -O3 -enable-global-merge -o - | FileCheck %s<br>
<br>
target datalayout = "e-p:64:64:64-i1:8:8-i8:8:8-<u></u>i16:16:16-i32:32:32-i64:64:64-<u></u>f32:32:32-f64:64:64-v64:64:64-<u></u>v128:128:128-a0:0:64-n32:64-<u></u>S128"<br>
target triple = "arm64-apple-ios7.0.0"<br>
<br>
Modified: llvm/trunk/test/CodeGen/ARM/<u></u>2010-12-15-elf-lcomm.ll<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/llvm/trunk/test/CodeGen/ARM/2010-12-15-elf-lcomm.ll?rev=233024&r1=233023&r2=233024&view=diff" target="_blank">http://llvm.org/viewvc/llvm-<u></u>project/llvm/trunk/test/<u></u>CodeGen/ARM/2010-12-15-elf-<u></u>lcomm.ll?rev=233024&r1=233023&<u></u>r2=233024&view=diff</a><br>
==============================<u></u>==============================<u></u>==================<br>
--- llvm/trunk/test/CodeGen/ARM/<u></u>2010-12-15-elf-lcomm.ll (original)<br>
+++ llvm/trunk/test/CodeGen/ARM/<u></u>2010-12-15-elf-lcomm.ll Mon Mar 23 16:17:36 2015<br>
@@ -1,6 +1,6 @@<br>
-; RUN: llc %s -mtriple=armv7-linux-gnueabi -filetype=obj -o - | \<br>
+; RUN: llc %s -mtriple=armv7-linux-gnueabi -O3 -filetype=obj -o - | \<br>
; RUN: llvm-readobj -s -t | FileCheck -check-prefix=OBJ %s<br>
-; RUN: llc %s -mtriple=armv7-linux-gnueabi -o - | \<br>
+; RUN: llc %s -mtriple=armv7-linux-gnueabi -O3 -o - | \<br>
; RUN: FileCheck -check-prefix=ASM %s<br>
<br>
<br>
<br>
Modified: llvm/trunk/test/CodeGen/ARM/<u></u>2011-01-19-MergedGlobalDbg.ll<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/llvm/trunk/test/CodeGen/ARM/2011-01-19-MergedGlobalDbg.ll?rev=233024&r1=233023&r2=233024&view=diff" target="_blank">http://llvm.org/viewvc/llvm-<u></u>project/llvm/trunk/test/<u></u>CodeGen/ARM/2011-01-19-<u></u>MergedGlobalDbg.ll?rev=233024&<u></u>r1=233023&r2=233024&view=diff</a><br>
==============================<u></u>==============================<u></u>==================<br>
--- llvm/trunk/test/CodeGen/ARM/<u></u>2011-01-19-MergedGlobalDbg.ll (original)<br>
+++ llvm/trunk/test/CodeGen/ARM/<u></u>2011-01-19-MergedGlobalDbg.ll Mon Mar 23 16:17:36 2015<br>
@@ -1,4 +1,4 @@<br>
-; RUN: llc -filetype=obj < %s | llvm-dwarfdump -debug-dump=info - | FileCheck %s<br>
+; RUN: llc -O3 -filetype=obj < %s | llvm-dwarfdump -debug-dump=info - | FileCheck %s<br>
<br>
target datalayout = "e-p:32:32:32-i1:8:32-i8:8:32-<u></u>i16:16:32-i32:32:32-i64:32:64-<u></u>f32:32:32-f64:32:64-v64:32:64-<u></u>v128:32:128-a0:0:32-n32"<br>
target triple = "thumbv7-apple-darwin10"<br>
<br>
Modified: llvm/trunk/test/CodeGen/ARM/<u></u>2011-06-29-MergeGlobalsAlign.<u></u>ll<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/llvm/trunk/test/CodeGen/ARM/2011-06-29-MergeGlobalsAlign.ll?rev=233024&r1=233023&r2=233024&view=diff" target="_blank">http://llvm.org/viewvc/llvm-<u></u>project/llvm/trunk/test/<u></u>CodeGen/ARM/2011-06-29-<u></u>MergeGlobalsAlign.ll?rev=<u></u>233024&r1=233023&r2=233024&<u></u>view=diff</a><br>
==============================<u></u>==============================<u></u>==================<br>
--- llvm/trunk/test/CodeGen/ARM/<u></u>2011-06-29-MergeGlobalsAlign.<u></u>ll (original)<br>
+++ llvm/trunk/test/CodeGen/ARM/<u></u>2011-06-29-MergeGlobalsAlign.<u></u>ll Mon Mar 23 16:17:36 2015<br>
@@ -1,4 +1,4 @@<br>
-; RUN: llc < %s -mtriple=thumbv7-apple-<u></u>darwin10 | FileCheck %s<br>
+; RUN: llc < %s -mtriple=thumbv7-apple-<u></u>darwin10 -O3 | FileCheck %s<br>
; CHECK: .zerofill __DATA,__bss,__MergedGlobals,<u></u>16,2<br>
<br>
@prev = external global [0 x i16]<br>
<br>
Modified: llvm/trunk/test/CodeGen/ARM/<u></u>2011-08-02-MergedGlobalDbg.ll<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/llvm/trunk/test/CodeGen/ARM/2011-08-02-MergedGlobalDbg.ll?rev=233024&r1=233023&r2=233024&view=diff" target="_blank">http://llvm.org/viewvc/llvm-<u></u>project/llvm/trunk/test/<u></u>CodeGen/ARM/2011-08-02-<u></u>MergedGlobalDbg.ll?rev=233024&<u></u>r1=233023&r2=233024&view=diff</a><br>
==============================<u></u>==============================<u></u>==================<br>
--- llvm/trunk/test/CodeGen/ARM/<u></u>2011-08-02-MergedGlobalDbg.ll (original)<br>
+++ llvm/trunk/test/CodeGen/ARM/<u></u>2011-08-02-MergedGlobalDbg.ll Mon Mar 23 16:17:36 2015<br>
@@ -1,4 +1,4 @@<br>
-; RUN: llc -filetype=obj < %s | llvm-dwarfdump -debug-dump=info - | FileCheck %s<br>
+; RUN: llc -O3 -filetype=obj < %s | llvm-dwarfdump -debug-dump=info - | FileCheck %s<br>
<br>
; Check debug info output for merged global.<br>
; DW_AT_location<br>
<br>
Modified: llvm/trunk/test/CodeGen/ARM/<u></u>global-merge-1.ll<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/llvm/trunk/test/CodeGen/ARM/global-merge-1.ll?rev=233024&r1=233023&r2=233024&view=diff" target="_blank">http://llvm.org/viewvc/llvm-<u></u>project/llvm/trunk/test/<u></u>CodeGen/ARM/global-merge-1.ll?<u></u>rev=233024&r1=233023&r2=<u></u>233024&view=diff</a><br>
==============================<u></u>==============================<u></u>==================<br>
--- llvm/trunk/test/CodeGen/ARM/<u></u>global-merge-1.ll (original)<br>
+++ llvm/trunk/test/CodeGen/ARM/<u></u>global-merge-1.ll Mon Mar 23 16:17:36 2015<br>
@@ -1,9 +1,10 @@<br>
; RUN: llc %s -O0 -o - | FileCheck -check-prefix=NO-MERGE %s<br>
-; RUN: llc %s -O0 -o - -enable-global-merge=false | FileCheck -check-prefix=NO-MERGE %s<br>
-; RUN: llc %s -O0 -o - -enable-global-merge=true | FileCheck -check-prefix=NO-MERGE %s<br>
-; RUN: llc %s -O1 -o - | FileCheck -check-prefix=MERGE %s<br>
+; RUN: llc %s -O1 -o - | FileCheck -check-prefix=NO-MERGE %s<br>
; RUN: llc %s -O1 -o - -enable-global-merge=false | FileCheck -check-prefix=NO-MERGE %s<br>
-; RUN: llc %s -O1 -o - -enable-global-merge=true | FileCheck -check-prefix=MERGE %s<br>
+; RUN: llc %s -O1 -o - -enable-global-merge=true | FileCheck -check-prefix=NO-MERGE %s<br>
+; RUN: llc %s -O3 -o - | FileCheck -check-prefix=MERGE %s<br>
+; RUN: llc %s -O3 -o - -enable-global-merge=false | FileCheck -check-prefix=NO-MERGE %s<br>
+; RUN: llc %s -O3 -o - -enable-global-merge=true | FileCheck -check-prefix=MERGE %s<br>
<br>
; MERGE-NOT: .zerofill __DATA,__bss,_bar,20,2<br>
; MERGE-NOT: .zerofill __DATA,__bss,_baz,20,2<br>
<br>
Modified: llvm/trunk/test/CodeGen/ARM/<u></u>global-merge-addrspace.ll<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/llvm/trunk/test/CodeGen/ARM/global-merge-addrspace.ll?rev=233024&r1=233023&r2=233024&view=diff" target="_blank">http://llvm.org/viewvc/llvm-<u></u>project/llvm/trunk/test/<u></u>CodeGen/ARM/global-merge-<u></u>addrspace.ll?rev=233024&r1=<u></u>233023&r2=233024&view=diff</a><br>
==============================<u></u>==============================<u></u>==================<br>
--- llvm/trunk/test/CodeGen/ARM/<u></u>global-merge-addrspace.ll (original)<br>
+++ llvm/trunk/test/CodeGen/ARM/<u></u>global-merge-addrspace.ll Mon Mar 23 16:17:36 2015<br>
@@ -1,4 +1,4 @@<br>
-; RUN: llc < %s -mtriple=thumb-apple-darwin | FileCheck %s<br>
+; RUN: llc < %s -mtriple=thumb-apple-darwin -O3 | FileCheck %s<br>
; Test the GlobalMerge pass. Check that the pass does not crash when using<br>
; multiple address spaces.<br>
<br>
<br>
Modified: llvm/trunk/test/CodeGen/ARM/<u></u>global-merge.ll<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/llvm/trunk/test/CodeGen/ARM/global-merge.ll?rev=233024&r1=233023&r2=233024&view=diff" target="_blank">http://llvm.org/viewvc/llvm-<u></u>project/llvm/trunk/test/<u></u>CodeGen/ARM/global-merge.ll?<u></u>rev=233024&r1=233023&r2=<u></u>233024&view=diff</a><br>
==============================<u></u>==============================<u></u>==================<br>
--- llvm/trunk/test/CodeGen/ARM/<u></u>global-merge.ll (original)<br>
+++ llvm/trunk/test/CodeGen/ARM/<u></u>global-merge.ll Mon Mar 23 16:17:36 2015<br>
@@ -1,4 +1,4 @@<br>
-; RUN: llc < %s -mtriple=thumb-apple-darwin -global-merge-on-const=true | FileCheck %s<br>
+; RUN: llc < %s -mtriple=thumb-apple-darwin -O3 -global-merge-on-const=true | FileCheck %s<br>
; Test the ARMGlobalMerge pass. Use -march=thumb because it has a small<br>
; value for the maximum offset (127).<br>
<br>
<br>
<br>
______________________________<u></u>_________________<br>
llvm-commits mailing list<br>
<a href="mailto:llvm-commits@cs.uiuc.edu" target="_blank">llvm-commits@cs.uiuc.edu</a><br>
<a href="http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits" target="_blank">http://lists.cs.uiuc.edu/<u></u>mailman/listinfo/llvm-commits</a><br>
</blockquote></div>