<div dir="ltr"><br><div class="gmail_extra"><br><div class="gmail_quote">On Mon, Mar 23, 2015 at 1:48 PM, Richard <span dir="ltr"><<a href="mailto:legalize@xmission.com" target="_blank">legalize@xmission.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex"><br>
In article <<a href="mailto:CAENS6EtScu6-nzsJk5V%2BO8J1LbgBpYtQeu9NtYrMJ-UQ0Kkw1g@mail.gmail.com">CAENS6EtScu6-nzsJk5V+O8J1LbgBpYtQeu9NtYrMJ-UQ0Kkw1g@mail.gmail.com</a>>,<br>
<span class="">    David Blaikie <<a href="mailto:dblaikie@gmail.com">dblaikie@gmail.com</a>> writes:<br>
<br>
> If we changed the code to:<br>
><br>
> if (x)<br>
>   return true;<br>
> return false;<br>
><br>
> would it still trigger the cleanup check you're using?<br>
<br>
</span>Nope.<br>
<br>
The tool explicitly looks for 'if (e) return true; else return false;'<br>
and replaces that with 'return e;'<br></blockquote><div><br>Cool - yeah, any time that part of the check fires we should at least be fixing it by removing the else - but sometimes it does make sense to just roll the whole conditional expression into the return statement.<br><br>Committed the else-after-return cleanups & some other stuff I saw in r233025<br> </div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex">
<span class=""><font color="#888888">--<br>
"The Direct3D Graphics Pipeline" free book <<a href="http://tinyurl.com/d3d-pipeline" target="_blank">http://tinyurl.com/d3d-pipeline</a>><br>
     The Computer Graphics Museum <<a href="http://ComputerGraphicsMuseum.org" target="_blank">http://ComputerGraphicsMuseum.org</a>><br>
         The Terminals Wiki <<a href="http://terminals.classiccmp.org" target="_blank">http://terminals.classiccmp.org</a>><br>
  Legalize Adulthood! (my blog) <<a href="http://LegalizeAdulthood.wordpress.com" target="_blank">http://LegalizeAdulthood.wordpress.com</a>><br>
</font></span></blockquote></div><br></div></div>