<html><head><meta http-equiv="Content-Type" content="text/html charset=utf-8"></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space;" class=""><div class="">Hm, <a href="http://reviews.llvm.org" class="">reviews.llvm.org</a> doesn’t let me update someone else’s patch… Here’s the link flags change I was thinking about (it however links libc++abi into ASan as well, not sure if that can be a problem or not):</div><div class=""><br class=""></div><blockquote style="margin: 0 0 0 40px; border: none; padding: 0px;" class=""><div class=""><div style="margin: 0px; font-size: 11px; font-family: Menlo;" class="">Index: CMakeLists.txt</div><div style="margin: 0px; font-size: 11px; font-family: Menlo;" class="">===================================================================</div><div style="margin: 0px; font-size: 11px; font-family: Menlo;" class="">--- CMakeLists.txt<span class="Apple-tab-span" style="white-space:pre"> </span>(revision 232919)</div><div style="margin: 0px; font-size: 11px; font-family: Menlo;" class="">+++ CMakeLists.txt<span class="Apple-tab-span" style="white-space:pre"> </span>(working copy)</div><div style="margin: 0px; font-size: 11px; font-family: Menlo;" class="">@@ -304,7 +304,7 @@</div><div style="margin: 0px; font-size: 11px; font-family: Menlo;" class=""> set(DARWIN_iossim_CFLAGS</div><div style="margin: 0px; font-size: 11px; font-family: Menlo;" class=""> -mios-simulator-version-min=7.0 -isysroot ${IOSSIM_SDK_DIR})</div><div style="margin: 0px; font-size: 11px; font-family: Menlo;" class=""> set(DARWIN_osx_LINKFLAGS -mmacosx-version-min=${SANITIZER_MIN_OSX_VERSION}</div><div style="margin: 0px; font-size: 11px; font-family: Menlo;" class="">- -stdlib=libc++)</div><div style="margin: 0px; font-size: 11px; font-family: Menlo;" class="">+ -stdlib=libc++ -lc++abi)</div><div style="margin: 0px; font-size: 11px; font-family: Menlo;" class=""> set(DARWIN_iossim_LINKFLAGS</div><div style="margin: 0px; font-size: 11px; font-family: Menlo;" class=""> -Wl,-ios_simulator_version_min,7.0.0</div><div style="margin: 0px; font-size: 11px; font-family: Menlo;" class=""> -mios-simulator-version-min=7.0</div></div></blockquote><div class=""><br class=""></div><div class="">You can then also remove the “XFAIL: darwin” from test/ubsan/TestCases/TypeCheck/vptr-virtual-base.cpp, because it no longer fails:</div><div class=""><br class=""></div><blockquote style="margin: 0 0 0 40px; border: none; padding: 0px;" class=""><div class=""><div style="margin: 0px; font-size: 11px; font-family: Menlo;" class="">Index: test/ubsan/TestCases/TypeCheck/vptr-virtual-base.cpp</div><div style="margin: 0px; font-size: 11px; font-family: Menlo;" class="">===================================================================</div><div style="margin: 0px; font-size: 11px; font-family: Menlo;" class="">--- test/ubsan/TestCases/TypeCheck/vptr-virtual-base.cpp<span class="Apple-tab-span" style="white-space:pre"> </span>(revision 232919)</div><div style="margin: 0px; font-size: 11px; font-family: Menlo;" class="">+++ test/ubsan/TestCases/TypeCheck/vptr-virtual-base.cpp<span class="Apple-tab-span" style="white-space:pre"> </span>(working copy)</div><div style="margin: 0px; font-size: 11px; font-family: Menlo;" class="">@@ -1,9 +1,6 @@</div><div style="margin: 0px; font-size: 11px; font-family: Menlo;" class=""> // RUN: %clangxx -frtti -fsanitize=vptr -fno-sanitize-recover=vptr -g %s -O3 -o %t</div><div style="margin: 0px; font-size: 11px; font-family: Menlo;" class=""> // RUN: not %run %t 2>&1 | FileCheck %s</div><p style="margin: 0px; font-size: 11px; font-family: Menlo; min-height: 13px;" class=""> <br class="webkit-block-placeholder"></p><div style="margin: 0px; font-size: 11px; font-family: Menlo;" class="">-// FIXME: This test produces linker errors on Darwin.</div><div style="margin: 0px; font-size: 11px; font-family: Menlo;" class="">-// XFAIL: darwin</div><div style="margin: 0px; font-size: 11px; font-family: Menlo;" class="">-</div><div style="margin: 0px; font-size: 11px; font-family: Menlo;" class=""> struct S { virtual int f() { return 0; } };</div><div style="margin: 0px; font-size: 11px; font-family: Menlo;" class=""> struct T : virtual S {};</div></div><div class=""><br class=""></div></blockquote><div class="">After that, build and “make check-ubsan” passes.</div><div class=""><br class=""></div><div class="">Kuba</div><br class=""><div><blockquote type="cite" class=""><div class="">On Mar 22, 2015, at 7:04 PM, Alexey Samsonov <<a href="mailto:vonosmas@gmail.com" class="">vonosmas@gmail.com</a>> wrote:</div><div class=""><div dir="ltr" class=""><div class="gmail_extra"><div class="gmail_quote"><div class="">Hm, could I ask you to update the patch? :)</div></div></div></div></div></blockquote></div><br class=""></body></html>