<div dir="ltr"><br><div class="gmail_extra"><br><div class="gmail_quote">On Thu, Mar 19, 2015 at 4:30 AM, Nick Lewycky <span dir="ltr"><<a href="mailto:nicholas@mxc.ca" target="_blank" class="cremed">nicholas@mxc.ca</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div class="HOEnZb"><div class="h5">Daniel Jasper wrote:<br>
<br>
> Ping?<br>
<br>
<br>
<br>
<br>
  if (!Op2 || Op1->getNumOperands() != Op2->getNumOperands())<br>
    return nullptr;<br>
<br>
​<br>
+   // As for Op1 above, don't try to fold a GEP into itself.<br>
+   if (Op2 == &GEP)<br>
+     return nullptr;<br>
<br>
Consider folding that into the check above.<br></div></div></blockquote><div><br></div><div>I have (and actually had that in the first snapshot). However, IMO separating it out makes the comment clearer and it should not have any performance penalties. </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div class="HOEnZb"><div class="h5">
<br>
LGTM<br>
<br>
> <a href="http://reviews.llvm.org/D8245" target="_blank" class="cremed">http://reviews.llvm.org/D8245</a><br>
<br>
><br>
<br>
> EMAIL PREFERENCES<br>
<br>
><br>
<br>
>   <a href="http://reviews.llvm.org/settings/panel/emailpreferences/" target="_blank" class="cremed">http://reviews.llvm.org/settings/panel/emailpreferences/</a><br>
<br>
><br>
<br>
> _______________________________________________<br>
<br>
>  llvm-commits mailing list<br>
<br>
>  <a href="mailto:llvm-commits@cs.uiuc.edu" class="cremed">llvm-commits@cs.uiuc.edu</a><br>
<br>
>  <a href="http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits" target="_blank" class="cremed">http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits</a><br>
<br>
<br>
<br>
<a href="http://reviews.llvm.org/D8245" target="_blank" class="cremed">http://reviews.llvm.org/D8245</a><br>
<br>
EMAIL PREFERENCES<br>
  <a href="http://reviews.llvm.org/settings/panel/emailpreferences/" target="_blank" class="cremed">http://reviews.llvm.org/settings/panel/emailpreferences/</a><br>
<br>
<br>
<br>
_______________________________________________<br>
llvm-commits mailing list<br>
<a href="mailto:llvm-commits@cs.uiuc.edu" class="cremed">llvm-commits@cs.uiuc.edu</a><br>
<a href="http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits" target="_blank" class="cremed">http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits</a><br>
</div></div></blockquote></div><br></div></div>