<div dir="ltr"><br><div class="gmail_extra"><br><div class="gmail_quote">On Tue, Mar 17, 2015 at 7:22 AM, Rafael Espindola <span dir="ltr"><<a href="mailto:rafael.espindola@gmail.com" target="_blank">rafael.espindola@gmail.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Author: rafael<br>
Date: Tue Mar 17 09:22:31 2015<br>
New Revision: 232478<br>
<br>
URL: <a href="http://llvm.org/viewvc/llvm-project?rev=232478&view=rev" target="_blank">http://llvm.org/viewvc/llvm-project?rev=232478&view=rev</a><br>
Log:<br>
Convert the easy cases of GetTempSymbol to createTempSymbol.<br>
<br>
In these cases no code was depending on GetTempSymbol finding an existing<br>
symbol.<br></blockquote><div><br>Is it possible/are you planning to remove GetTempSymbol entirely? I had some aspirations of doing that at one point - to avoid spooky-action-at-a-distance stuff where one bit of code would create a label and some otherwise unrelated bit of code would use/rely on that label - seemed like bad design whenever that cropped up (sort of like using global hashmaps rather than actually passing the required data from source to destination)<br> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<br>
Modified:<br>
llvm/trunk/lib/CodeGen/AsmPrinter/AsmPrinter.cpp<br>
llvm/trunk/lib/CodeGen/AsmPrinter/DwarfAccelTable.cpp<br>
llvm/trunk/lib/CodeGen/AsmPrinter/DwarfCompileUnit.cpp<br>
llvm/trunk/lib/CodeGen/AsmPrinter/DwarfDebug.cpp<br>
llvm/trunk/lib/CodeGen/AsmPrinter/DwarfStringPool.cpp<br>
llvm/trunk/lib/Target/AArch64/AArch64AsmPrinter.cpp<br>
<br>
Modified: llvm/trunk/lib/CodeGen/AsmPrinter/AsmPrinter.cpp<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/CodeGen/AsmPrinter/AsmPrinter.cpp?rev=232478&r1=232477&r2=232478&view=diff" target="_blank">http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/CodeGen/AsmPrinter/AsmPrinter.cpp?rev=232478&r1=232477&r2=232478&view=diff</a><br>
==============================================================================<br>
--- llvm/trunk/lib/CodeGen/AsmPrinter/AsmPrinter.cpp (original)<br>
+++ llvm/trunk/lib/CodeGen/AsmPrinter/AsmPrinter.cpp Tue Mar 17 09:22:31 2015<br>
@@ -1575,7 +1575,7 @@ void AsmPrinter::EmitLabelDifference(con<br>
}<br>
<br>
// Otherwise, emit with .set (aka assignment).<br>
- MCSymbol *SetLabel = GetTempSymbol("set", SetCounter++);<br>
+ MCSymbol *SetLabel = createTempSymbol("set", SetCounter++);<br>
OutStreamer.EmitAssignment(SetLabel, Diff);<br>
OutStreamer.EmitSymbolValue(SetLabel, Size);<br>
}<br>
<br>
Modified: llvm/trunk/lib/CodeGen/AsmPrinter/DwarfAccelTable.cpp<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/CodeGen/AsmPrinter/DwarfAccelTable.cpp?rev=232478&r1=232477&r2=232478&view=diff" target="_blank">http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/CodeGen/AsmPrinter/DwarfAccelTable.cpp?rev=232478&r1=232477&r2=232478&view=diff</a><br>
==============================================================================<br>
--- llvm/trunk/lib/CodeGen/AsmPrinter/DwarfAccelTable.cpp (original)<br>
+++ llvm/trunk/lib/CodeGen/AsmPrinter/DwarfAccelTable.cpp Tue Mar 17 09:22:31 2015<br>
@@ -96,7 +96,7 @@ void DwarfAccelTable::FinalizeTable(AsmP<br>
for (size_t i = 0, e = Data.size(); i < e; ++i) {<br>
uint32_t bucket = Data[i]->HashValue % Header.bucket_count;<br>
Buckets[bucket].push_back(Data[i]);<br>
- Data[i]->Sym = Asm->GetTempSymbol(Prefix, i);<br>
+ Data[i]->Sym = Asm->createTempSymbol(Prefix, i);<br>
}<br>
<br>
// Sort the contents of the buckets by hash value so that hash<br>
<br>
Modified: llvm/trunk/lib/CodeGen/AsmPrinter/DwarfCompileUnit.cpp<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/CodeGen/AsmPrinter/DwarfCompileUnit.cpp?rev=232478&r1=232477&r2=232478&view=diff" target="_blank">http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/CodeGen/AsmPrinter/DwarfCompileUnit.cpp?rev=232478&r1=232477&r2=232478&view=diff</a><br>
==============================================================================<br>
--- llvm/trunk/lib/CodeGen/AsmPrinter/DwarfCompileUnit.cpp (original)<br>
+++ llvm/trunk/lib/CodeGen/AsmPrinter/DwarfCompileUnit.cpp Tue Mar 17 09:22:31 2015<br>
@@ -380,7 +380,7 @@ void DwarfCompileUnit::addScopeRangeList<br>
TLOF.getDwarfRangesSection()->getBeginSymbol();<br>
<br>
RangeSpanList List(<br>
- Asm->GetTempSymbol("debug_ranges", DD->getNextRangeNumber()),<br>
+ Asm->createTempSymbol("debug_ranges", DD->getNextRangeNumber()),<br>
std::move(Range));<br>
<br>
// Under fission, ranges are specified by constant offsets relative to the<br>
<br>
Modified: llvm/trunk/lib/CodeGen/AsmPrinter/DwarfDebug.cpp<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/CodeGen/AsmPrinter/DwarfDebug.cpp?rev=232478&r1=232477&r2=232478&view=diff" target="_blank">http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/CodeGen/AsmPrinter/DwarfDebug.cpp?rev=232478&r1=232477&r2=232478&view=diff</a><br>
==============================================================================<br>
--- llvm/trunk/lib/CodeGen/AsmPrinter/DwarfDebug.cpp (original)<br>
+++ llvm/trunk/lib/CodeGen/AsmPrinter/DwarfDebug.cpp Tue Mar 17 09:22:31 2015<br>
@@ -927,7 +927,7 @@ DwarfDebug::collectVariableInfo(DwarfCom<br>
DebugLocList &LocList = DotDebugLocEntries.back();<br>
LocList.CU = &TheCU;<br>
LocList.Label =<br>
- Asm->GetTempSymbol("debug_loc", DotDebugLocEntries.size() - 1);<br>
+ Asm->createTempSymbol("debug_loc", DotDebugLocEntries.size() - 1);<br>
<br>
// Build the location list for this variable.<br>
buildLocationList(LocList.List, Ranges);<br>
@@ -1669,7 +1669,7 @@ void DwarfDebug::emitDebugARanges() {<br>
// if we know the section name up-front. For user-created sections, the<br>
// resulting label may not be valid to use as a label. (section names can<br>
// use a greater set of characters on some systems)<br>
- Sym = Asm->GetTempSymbol("debug_end", ID);<br>
+ Sym = Asm->createTempSymbol("debug_end", ID);<br>
Asm->OutStreamer.SwitchSection(Section);<br>
Asm->OutStreamer.EmitLabel(Sym);<br>
}<br>
<br>
Modified: llvm/trunk/lib/CodeGen/AsmPrinter/DwarfStringPool.cpp<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/CodeGen/AsmPrinter/DwarfStringPool.cpp?rev=232478&r1=232477&r2=232478&view=diff" target="_blank">http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/CodeGen/AsmPrinter/DwarfStringPool.cpp?rev=232478&r1=232477&r2=232478&view=diff</a><br>
==============================================================================<br>
--- llvm/trunk/lib/CodeGen/AsmPrinter/DwarfStringPool.cpp (original)<br>
+++ llvm/trunk/lib/CodeGen/AsmPrinter/DwarfStringPool.cpp Tue Mar 17 09:22:31 2015<br>
@@ -19,7 +19,7 @@ getEntry(AsmPrinter &Asm,<br>
std::pair<MCSymbol *, unsigned> &Entry = Pool[Str];<br>
if (!Entry.first) {<br>
Entry.second = Pool.size() - 1;<br>
- Entry.first = Asm.GetTempSymbol(Prefix, Entry.second);<br>
+ Entry.first = Asm.createTempSymbol(Prefix, Entry.second);<br>
}<br>
return Entry;<br>
}<br>
<br>
Modified: llvm/trunk/lib/Target/AArch64/AArch64AsmPrinter.cpp<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Target/AArch64/AArch64AsmPrinter.cpp?rev=232478&r1=232477&r2=232478&view=diff" target="_blank">http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Target/AArch64/AArch64AsmPrinter.cpp?rev=232478&r1=232477&r2=232478&view=diff</a><br>
==============================================================================<br>
--- llvm/trunk/lib/Target/AArch64/AArch64AsmPrinter.cpp (original)<br>
+++ llvm/trunk/lib/Target/AArch64/AArch64AsmPrinter.cpp Tue Mar 17 09:22:31 2015<br>
@@ -464,7 +464,7 @@ void AArch64AsmPrinter::EmitInstruction(<br>
<br>
if (AArch64FI->getLOHRelated().count(MI)) {<br>
// Generate a label for LOH related instruction<br>
- MCSymbol *LOHLabel = GetTempSymbol("loh", LOHLabelCounter++);<br>
+ MCSymbol *LOHLabel = createTempSymbol("loh", LOHLabelCounter++);<br>
// Associate the instruction with the label<br>
LOHInstToLabel[MI] = LOHLabel;<br>
OutStreamer.EmitLabel(LOHLabel);<br>
<br>
<br>
_______________________________________________<br>
llvm-commits mailing list<br>
<a href="mailto:llvm-commits@cs.uiuc.edu">llvm-commits@cs.uiuc.edu</a><br>
<a href="http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits" target="_blank">http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits</a><br>
</blockquote></div><br></div></div>