<div dir="ltr">No, please follow the LLVM coding style when you write code for LLD (except the naming convention which was discussed before).</div><div class="gmail_extra"><br><div class="gmail_quote">On Tue, Mar 17, 2015 at 12:04 PM, Shankar Easwaran <span dir="ltr"><<a href="mailto:shankare@codeaurora.org" target="_blank">shankare@codeaurora.org</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">It looks like lld doesnot follow that pattern and chooses to use anonymous namespace for variables as well.<br>
<br>
I felt anonymous namespaces are much nicer though.<br>
<br>
Shankar Easwaran<div class="HOEnZb"><div class="h5"><br>
<br>
On 3/17/2015 1:58 PM, Rui Ueyama wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
Yup. It's also documented in the coding style (<br>
<a href="http://llvm.org/docs/CodingStandards.html#anonymous-namespaces" target="_blank">http://llvm.org/docs/<u></u>CodingStandards.html#<u></u>anonymous-namespaces</a>).<br>
<br>
On Tue, Mar 17, 2015 at 9:53 AM, Rafael Espíndola <<br>
<a href="mailto:rafael.espindola@gmail.com" target="_blank">rafael.espindola@gmail.com</a>> wrote:<br>
<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
Better.<br>
<br>
Just a note of style: we normally use static instead of anonymous<br>
namespaces when they do the same thing. Probably the best in here<br>
would be<br>
<br>
static const char gotSymbol[] = "_GLOBAL_OFFSET_TABLE_";<br>
<br>
<br>
On 17 March 2015 at 12:40, Shankar Easwaran <<a href="mailto:shankare@codeaurora.org" target="_blank">shankare@codeaurora.org</a>><br>
wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
Author: shankare<br>
Date: Tue Mar 17 11:40:14 2015<br>
New Revision: 232497<br>
<br>
URL: <a href="http://llvm.org/viewvc/llvm-project?rev=232497&view=rev" target="_blank">http://llvm.org/viewvc/llvm-<u></u>project?rev=232497&view=rev</a><br>
Log:<br>
[ELF][ARM] Place gotSymbol in an anonymous namespace<br>
<br>
Address comments from Espindola.<br>
<br>
Modified:<br>
lld/trunk/lib/ReaderWriter/<u></u>ELF/ARM/ARMExecutableWriter.h<br>
<br>
Modified: lld/trunk/lib/ReaderWriter/<u></u>ELF/ARM/ARMExecutableWriter.h<br>
URL:<br>
</blockquote>
<a href="http://llvm.org/viewvc/llvm-project/lld/trunk/lib/ReaderWriter/ELF/ARM/ARMExecutableWriter.h?rev=232497&r1=232496&r2=232497&view=diff" target="_blank">http://llvm.org/viewvc/llvm-<u></u>project/lld/trunk/lib/<u></u>ReaderWriter/ELF/ARM/<u></u>ARMExecutableWriter.h?rev=<u></u>232497&r1=232496&r2=232497&<u></u>view=diff</a><br>
==============================<u></u>==============================<u></u>==================<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
--- lld/trunk/lib/ReaderWriter/<u></u>ELF/ARM/ARMExecutableWriter.h (original)<br>
+++ lld/trunk/lib/ReaderWriter/<u></u>ELF/ARM/ARMExecutableWriter.h Tue Mar 17<br>
</blockquote>
11:40:14 2015<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
@@ -14,6 +14,10 @@<br>
#include "ARMTargetHandler.h"<br>
#include "ARMSymbolTable.h"<br>
<br>
+namespace {<br>
+const char *gotSymbol = "_GLOBAL_OFFSET_TABLE_";<br>
+}<br>
+<br>
namespace lld {<br>
namespace elf {<br>
<br>
@@ -41,14 +45,13 @@ protected:<br>
private:<br>
ARMLinkingContext &_context;<br>
ARMTargetLayout<ELFT> &_armLayout;<br>
- StringRef _gotSymbol;<br>
};<br>
<br>
template <class ELFT><br>
ARMExecutableWriter<ELFT>::<u></u>ARMExecutableWriter(<u></u>ARMLinkingContext<br>
</blockquote>
&context,<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
ARMTargetLayout<ELFT><br>
</blockquote>
&layout)<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
: ExecutableWriter<ELFT>(<u></u>context, layout), _context(context),<br>
- _armLayout(layout), _gotSymbol("_GLOBAL_OFFSET_<u></u>TABLE_") {}<br>
+ _armLayout(layout) {}<br>
<br>
template <class ELFT><br>
bool ARMExecutableWriter<ELFT>::<u></u>createImplicitFiles(<br>
@@ -61,7 +64,7 @@ template <class ELFT><br>
void ARMExecutableWriter<ELFT>::<u></u>finalizeDefaultAtomValues() {<br>
// Finalize the atom values that are part of the parent.<br>
ExecutableWriter<ELFT>::<u></u>finalizeDefaultAtomValues();<br>
- auto gotAtomIter = _armLayout.findAbsoluteAtom(_<u></u>gotSymbol);<br>
+ auto gotAtomIter = _armLayout.findAbsoluteAtom(<u></u>gotSymbol);<br>
if (gotAtomIter != _armLayout.absoluteAtoms().<u></u>end()) {<br>
auto *gotAtom = *gotAtomIter;<br>
if (auto gotpltSection = _armLayout.findOutputSection("<u></u>.got.plt"))<br>
@@ -84,8 +87,8 @@ unique_bump_ptr<SymbolTable<<u></u>ELFT>><br>
template <class ELFT><br>
void ARMExecutableWriter<ELFT>::<u></u>processUndefinedSymbol(<br>
StringRef symName, RuntimeFile<ELFT> &file) const {<br>
- if (symName == _gotSymbol) {<br>
- file.addAbsoluteAtom(_<u></u>gotSymbol);<br>
+ if (symName == gotSymbol) {<br>
+ file.addAbsoluteAtom(<u></u>gotSymbol);<br>
} else if (symName.startswith("__exidx")<u></u>) {<br>
file.addAbsoluteAtom("__exidx_<u></u>start");<br>
file.addAbsoluteAtom("__exidx_<u></u>end");<br>
<br>
<br>
______________________________<u></u>_________________<br>
llvm-commits mailing list<br>
<a href="mailto:llvm-commits@cs.uiuc.edu" target="_blank">llvm-commits@cs.uiuc.edu</a><br>
<a href="http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits" target="_blank">http://lists.cs.uiuc.edu/<u></u>mailman/listinfo/llvm-commits</a><br>
</blockquote>
______________________________<u></u>_________________<br>
llvm-commits mailing list<br>
<a href="mailto:llvm-commits@cs.uiuc.edu" target="_blank">llvm-commits@cs.uiuc.edu</a><br>
<a href="http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits" target="_blank">http://lists.cs.uiuc.edu/<u></u>mailman/listinfo/llvm-commits</a><br>
<br>
</blockquote></blockquote>
<br>
<br></div></div><span class="HOEnZb"><font color="#888888">
-- <br>
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, hosted by the Linux Foundation<br>
<br>
</font></span></blockquote></div><br></div>